From 670329ddd4714d45e18d2dda15d7895834727853 Mon Sep 17 00:00:00 2001 From: ioedeveloper Date: Thu, 14 Jan 2021 09:47:56 +0100 Subject: [PATCH] Change data-id for react modal --- apps/remix-ide-e2e/src/tests/publishContract.test.ts | 3 --- .../modal-dialog/src/lib/remix-ui-modal-dialog.tsx | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/publishContract.test.ts b/apps/remix-ide-e2e/src/tests/publishContract.test.ts index 72d9e2ecc9..671893a26e 100644 --- a/apps/remix-ide-e2e/src/tests/publishContract.test.ts +++ b/apps/remix-ide-e2e/src/tests/publishContract.test.ts @@ -45,8 +45,6 @@ module.exports = { browser .waitForElementVisible('#icon-panel') .clickLaunchIcon('fileExplorers') - // .click('*[data-id="treeViewLibrowser/contracts"]') - // .click('*[data-id="treeViewLibrowser/contracts"]') .openFile('browser/contracts/1_Storage.sol') .clickLaunchIcon('udapp') .waitForElementPresent('*[data-id="contractDropdownIpfsCheckbox"]') @@ -65,7 +63,6 @@ module.exports = { .refresh() .waitForElementVisible('[data-id="treeViewLitreeViewItembrowser/contracts"]') .click('[data-id="treeViewLitreeViewItembrowser/contracts"]') - // .click('*[data-id="treeViewLibrowser/contracts"]') .openFile('browser/contracts/1_Storage.sol') .clickLaunchIcon('udapp') .waitForElementPresent('*[data-id="contractDropdownIpfsCheckbox"]') diff --git a/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx b/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx index c2401174a7..929c23786b 100644 --- a/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx +++ b/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx @@ -42,7 +42,7 @@ export const ModalDialog = (props: ModalDialogProps) => { return (
{ onKeyDown={({ keyCode }) => { modalKeyEvent(keyCode) }} >
-
+
{props.title && props.title}
{!props.showCancelIcon && @@ -70,10 +70,10 @@ export const ModalDialog = (props: ModalDialogProps) => { }
-
+
{ props.children ? props.children : props.message }
-
+
{/* todo add autofocus ^^ */} { props.ok &&