From e08f417abc5d25180fbfbd6072f46962541cd8d4 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:01:47 +0200 Subject: [PATCH 01/13] login github test --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index afe5c5576b..55755e31e6 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index daa7d17baa..0945da1c36 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -25,7 +25,7 @@ module.exports = { .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, - 'login to github #group1 #group2': function (browser: NightwatchBrowser) { + 'login to github #flaky #group1 #group2': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') From 6470d97e3a446e3008ac557dd8169860b2c06d40 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:18:58 +0200 Subject: [PATCH 02/13] group1 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 0945da1c36..d7c793ff85 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -25,7 +25,7 @@ module.exports = { .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, - 'login to github #flaky #group1 #group2': function (browser: NightwatchBrowser) { + 'login to github #group1 #group2': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') @@ -45,7 +45,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #group1': function (browser: NightwatchBrowser) { + 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') From 3b23d3959d89ff9508a7188c56e94db5d8f1d5cf Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:32:35 +0200 Subject: [PATCH 03/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index d7c793ff85..b18938fd08 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -22,6 +22,7 @@ module.exports = { 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('filePanel') + .pause(1000) .waitForElementVisible('*[data-id="filepanel-login-github"]') .click('*[data-id="filepanel-login-github"]') }, From acff4445c8648d98ccbb57ba919ef645210a510c Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:40:34 +0200 Subject: [PATCH 04/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index b18938fd08..c264fee0ed 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -213,6 +213,7 @@ module.exports = { .waitForElementVisible('*[data-id="github-panel"]') .click('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="disconnect-github"]') + .pause(1000) .click('*[data-id="disconnect-github"]') .waitForElementNotPresent('*[data-id="connected-as-bunsenstraat"]') }, From fca3bbdaecbc3ed753aa6b5416139ecff3d49342 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:48:04 +0200 Subject: [PATCH 05/13] add pauses --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index c264fee0ed..bb6263091c 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -31,8 +31,11 @@ module.exports = { .waitForElementVisible('*[data-id="github-panel"]') .waitForElementVisible('*[data-id="gitubUsername"]') .setValue('*[data-id="githubToken"]', process.env.dgit_token) + .pause(1000) .setValue('*[data-id="gitubUsername"]', 'git') + .pause(1000) .setValue('*[data-id="githubEmail"]', 'git@example.com') + .pause(1000) .click('*[data-id="saveGitHubCredentials"]') }, 'check if the settings are loaded #group1 #group2': function (browser: NightwatchBrowser) { From 4f87cea6399748b261f7cc7873fa5d63cf017ced Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 09:58:13 +0200 Subject: [PATCH 06/13] add pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index bb6263091c..553987faf9 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -121,6 +121,7 @@ module.exports = { .click('*[data-id="remotes-panel"]') .waitForElementVisible('*[data-id="remotes-panel-content"]') + .pause(2000) .waitForElementVisible({ selector: '//*[@data-id="remotes-panel-content"]//*[@data-id="remote-detail-origin-default"]', locateStrategy: 'xpath' From 5faa068d58ba54c0a7f040edd93b17274165d635 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:11:07 +0200 Subject: [PATCH 07/13] group2 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 553987faf9..e4875bb6c6 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -49,7 +49,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { + 'clone a repository #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') @@ -227,7 +227,7 @@ module.exports = { .waitForElementNotPresent('*[data-id="filepanel-connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="filepanel-login-github"]') }, - 'add a remote #group2': function (browser: NightwatchBrowser) { + 'add a remote #flaky #group2': function (browser: NightwatchBrowser) { browser .pause(1000) .clickLaunchIcon('dgit') From 198edd0fd1cf61ce270933055d89c71b07ade433 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:20:08 +0200 Subject: [PATCH 08/13] more pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index e4875bb6c6..c83fedc251 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -290,6 +290,7 @@ module.exports = { selector: "//div[@id='commands-local-branch-select']//div[contains(@class, 'singleValue') and contains(text(), 'main')]", locateStrategy: 'xpath' }) + .pause(1000) .getAttribute({ selector: '//*[@data-id="sourcecontrol-pull"]', locateStrategy: 'xpath' From 60dd763f6a4101838a3a18a33913f75e6f8be752 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:30:50 +0200 Subject: [PATCH 09/13] pause --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index c83fedc251..1da36253c1 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -16,8 +16,10 @@ module.exports = { 'Update settings for git #group1 #group2': function (browser: NightwatchBrowser) { browser. clickLaunchIcon('dgit') + .pause(1000) .waitForElementVisible('*[data-id="initgit-btn"]') .click('*[data-id="initgit-btn"]') + .pause(1000) }, 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser From fa99c663f9d72540e7006f267678e6eee4557ce9 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:31:23 +0200 Subject: [PATCH 10/13] assert --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 1da36253c1..69d44f3f3e 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -19,7 +19,7 @@ module.exports = { .pause(1000) .waitForElementVisible('*[data-id="initgit-btn"]') .click('*[data-id="initgit-btn"]') - .pause(1000) + .waitForElementNotPresent('*[data-id="initgit-btn"]') }, 'launch github login via FE #group1 #group2': function (browser: NightwatchBrowser) { browser From eab6eeb4d0def83f11689fe21e37499bffd3cc20 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:32:34 +0200 Subject: [PATCH 11/13] assert --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 69d44f3f3e..fed04a7493 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -45,6 +45,7 @@ module.exports = { .waitForElementVisible('*[data-id="connected-as-bunsenstraat"]') .waitForElementVisible('*[data-id="connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="connected-link-bunsenstraat"]') + .waitForElementVisible('*[data-id="remotes-panel"]') }, 'check the FE for the auth user #group1 #group2': function (browser: NightwatchBrowser) { browser From a3ff757225d02aba3caf8a0fd6db741b17e3da93 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 10:43:17 +0200 Subject: [PATCH 12/13] group1 --- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index fed04a7493..780b2783ba 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -52,7 +52,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #group1': function (browser: NightwatchBrowser) { + 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') From c5dc4c6b6b06ee663564f7be166d967de31aa536 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Sat, 31 Aug 2024 11:00:04 +0200 Subject: [PATCH 13/13] turn off flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/dgit_github.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 55755e31e6..afe5c5576b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts index 780b2783ba..22bece4727 100644 --- a/apps/remix-ide-e2e/src/tests/dgit_github.test.ts +++ b/apps/remix-ide-e2e/src/tests/dgit_github.test.ts @@ -52,7 +52,7 @@ module.exports = { .clickLaunchIcon('filePanel') .waitForElementVisible('*[data-id="filepanel-connected-img-bunsenstraat"]') }, - 'clone a repository #flaky #group1': function (browser: NightwatchBrowser) { + 'clone a repository #group1': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('dgit') .click('*[data-id="clone-panel"]') @@ -230,7 +230,7 @@ module.exports = { .waitForElementNotPresent('*[data-id="filepanel-connected-img-bunsenstraat"]') .waitForElementVisible('*[data-id="filepanel-login-github"]') }, - 'add a remote #flaky #group2': function (browser: NightwatchBrowser) { + 'add a remote #group2': function (browser: NightwatchBrowser) { browser .pause(1000) .clickLaunchIcon('dgit')