Merge pull request #1174 from ethereum/yann300-patch-32

Validate input using BigNumber

apps/remix-ide/src/app/tabs/runTab/settings.js

@@ -1,3 +1,4 @@
+import { BN } from 'ethereumjs-util'
 const $ = require('jquery')
 const yo = require('yo-yo')
 const remixLib = require('@remix-project/remix-lib')
@@ -65,14 +66,26 @@ class SettingsUI {
 
   validateValue () {
     const valueEl = this.el.querySelector('#value')
-    valueEl.value = parseInt(valueEl.value)
+    if (!valueEl.value) {
-    // assign 0 if given value is
+      // assign 0 if given value is
-    // - empty
+      // - empty
-    // - not valid (for ex 4345-54)
+      valueEl.value = 0
-    // - contains only '0's (for ex 0000) copy past or edit
+      return
-    if (!valueEl.value) valueEl.value = 0
+    }
+
+    let v
+    try {
+      v = new BN(valueEl.value, 10)
+      valueEl.value = v.toString(10)
+    } catch (e) {
+      // assign 0 if given value is
+      // - not valid (for ex 4345-54)
+      // - contains only '0's (for ex 0000) copy past or edit
+      valueEl.value = 0
+    }
+
     // if giveen value is negative(possible with copy-pasting) set to 0
-    if (valueEl.value < 0) valueEl.value = 0
+    if (v.lt(0)) valueEl.value = 0
   }
 
   render () {

libs/remix-lib/src/execution/txRunner.ts

@@ -118,7 +118,17 @@ export class TxRunner {
     this.executionContext.vm().stateManager.getAccount(Address.fromString(from)).then((res) => {
       // See https://github.com/ethereumjs/ethereumjs-tx/blob/master/docs/classes/transaction.md#constructor
       // for initialization fields and their types
-      value = value ? parseInt(value) : 0
+      if (!value) value = 0
+      if (typeof value === 'string') {
+        if (value.startsWith('0x')) value = new BN(value.replace('0x', ''), 'hex')
+        else {
+          try {
+            value = new BN(value, 10)
+          } catch (e) {
+            return callback('Unable to parse the value ' + e.message)
+          }
+        }
+      }
       const tx = Transaction.fromTxData({
         nonce: new BN(res.nonce),
         gasPrice: '0x1',