From 126a2c6b78f0fcae3e3aec78163ee537c7df7740 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Tue, 23 Jan 2024 17:14:04 +0100 Subject: [PATCH 01/11] timeout --- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 2fe57cadbe..6ae320ae2d 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -271,7 +271,7 @@ module.exports = { .waitForElementPresent('.fa-spinner') .waitForElementVisible({ selector: '*[data-id="treeViewLitreeViewItem.git"]', - timeout: 60000 + timeout: 240000 }) .waitForElementContainsText('[data-id="workspacesSelect"]', 'test-branch-submodule') .waitForElementVisible('[data-id="updatesubmodules"]') @@ -279,7 +279,7 @@ module.exports = { .waitForElementPresent('.fa-spinner') .waitForElementVisible({ selector: '*[data-id="treeViewLitreeViewItem.git"]', - timeout: 60000 + timeout: 240000 }) .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') @@ -319,7 +319,7 @@ module.exports = { .waitForElementPresent('.fa-spinner') .waitForElementVisible({ selector: '*[data-id="treeViewLitreeViewItem.git"]', - timeout: 60000 + timeout: 240000 }) .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') From 42303241acb06933f4d590a9138df90533f9f906 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Tue, 23 Jan 2024 18:30:09 +0100 Subject: [PATCH 02/11] flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 17a37c5d3c..443d6ef53e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 6ae320ae2d..9ed8b0f340 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -295,7 +295,7 @@ module.exports = { .click('[data-id="treeViewDivtreeViewItemrecursive/plugins"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/plugins/build"]') }, - 'When switching branches the submodules should disappear #group4': function (browser: NightwatchBrowser) { + 'When switching branches the submodules should disappear #flaky #group4': function (browser: NightwatchBrowser) { browser .waitForElementVisible('[data-id="workspaceGitBranchesDropdown"]') .click('[data-id="workspaceGitBranchesDropdown"]') From a7034330db38de23bdf7297156055f4ef552d94d Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Tue, 23 Jan 2024 19:14:55 +0100 Subject: [PATCH 03/11] add log --- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 6ae320ae2d..d60235a276 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -258,6 +258,9 @@ module.exports = { 'Should clone a repository with submodules #group4': function (browser: NightwatchBrowser) { browser + .captureBrowserExceptions((event) => { + console.log('>>> Exception:', event); + }) .clickLaunchIcon('filePanel') .waitForElementVisible('[data-id="workspaceMenuDropdown"]') .click('[data-id="workspaceMenuDropdown"]') From 19ad24294caf96a895b71f270fffa35fde9d817e Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Tue, 23 Jan 2024 19:23:53 +0100 Subject: [PATCH 04/11] logs --- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index c147fa4a35..92671d394d 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -258,7 +258,7 @@ module.exports = { 'Should clone a repository with submodules #group4': function (browser: NightwatchBrowser) { browser - .captureBrowserExceptions((event) => { + .captureBrowserConsoleLogs((event) => { console.log('>>> Exception:', event); }) .clickLaunchIcon('filePanel') From c90d0046ee69b76e0ca328013714f3aa10075244 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Tue, 23 Jan 2024 19:35:09 +0100 Subject: [PATCH 05/11] disable headless --- apps/remix-ide-e2e/nightwatch.ts | 2 +- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/nightwatch.ts b/apps/remix-ide-e2e/nightwatch.ts index 7e05269897..b50a8d50fa 100644 --- a/apps/remix-ide-e2e/nightwatch.ts +++ b/apps/remix-ide-e2e/nightwatch.ts @@ -33,7 +33,7 @@ module.exports = { 'window-size=2560,1440', 'start-fullscreen', '--no-sandbox', - '--headless', + //'--headless', '--verbose', '--user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36' ] diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 92671d394d..5ca03db393 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -258,8 +258,10 @@ module.exports = { 'Should clone a repository with submodules #group4': function (browser: NightwatchBrowser) { browser - .captureBrowserConsoleLogs((event) => { + .captureBrowserExceptions((event) => { console.log('>>> Exception:', event); + }).captureBrowserConsoleLogs((event) => { + console.log('>>> Console:', event); }) .clickLaunchIcon('filePanel') .waitForElementVisible('[data-id="workspaceMenuDropdown"]') From 54541028e584b0ba61184a5169dfb3a198bf558b Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 24 Jan 2024 10:58:42 +0100 Subject: [PATCH 06/11] browser log --- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 5ca03db393..4b1234e681 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -258,11 +258,6 @@ module.exports = { 'Should clone a repository with submodules #group4': function (browser: NightwatchBrowser) { browser - .captureBrowserExceptions((event) => { - console.log('>>> Exception:', event); - }).captureBrowserConsoleLogs((event) => { - console.log('>>> Console:', event); - }) .clickLaunchIcon('filePanel') .waitForElementVisible('[data-id="workspaceMenuDropdown"]') .click('[data-id="workspaceMenuDropdown"]') @@ -284,8 +279,10 @@ module.exports = { .waitForElementPresent('.fa-spinner') .waitForElementVisible({ selector: '*[data-id="treeViewLitreeViewItem.git"]', - timeout: 240000 - }) + timeout: 240000, + abortOnFailure: false, + suppressNotFoundErrors: true + }).getBrowserLogs().end() .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive"]') From 04114f37923cfeaa12f65c2fe4f964804dbb43d3 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 24 Jan 2024 11:09:30 +0100 Subject: [PATCH 07/11] set timeout --- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 2 +- apps/remix-ide/src/remixEngine.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 4b1234e681..257d302122 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -282,7 +282,7 @@ module.exports = { timeout: 240000, abortOnFailure: false, suppressNotFoundErrors: true - }).getBrowserLogs().end() + }).getBrowserLogs() .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive"]') diff --git a/apps/remix-ide/src/remixEngine.js b/apps/remix-ide/src/remixEngine.js index 5c0657ce22..cb37c77e51 100644 --- a/apps/remix-ide/src/remixEngine.js +++ b/apps/remix-ide/src/remixEngine.js @@ -10,7 +10,7 @@ export class RemixEngine extends Engine { setPluginOption ({ name, kind }) { if (kind === 'provider') return { queueTimeout: 60000 * 2 } if (name === 'LearnEth') return { queueTimeout: 60000 } - if (name === 'dGitProvider') return { queueTimeout: 60000 * 4 } + if (name === 'dGitProvider') return { queueTimeout: 60000 * 20 } if (name === 'slither') return { queueTimeout: 60000 * 4 } // Requires when a solc version is installed if (name === 'hardhat') return { queueTimeout: 60000 * 4 } if (name === 'truffle') return { queueTimeout: 60000 * 4 } From c06589487ff0065d37a55b1578fbd08f56298c06 Mon Sep 17 00:00:00 2001 From: filip mertens Date: Wed, 24 Jan 2024 13:16:02 +0100 Subject: [PATCH 08/11] test change --- .../src/tests/workspace_git.test.ts | 90 ++++++++++++------- 1 file changed, 58 insertions(+), 32 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index 257d302122..e83635716f 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -282,31 +282,44 @@ module.exports = { timeout: 240000, abortOnFailure: false, suppressNotFoundErrors: true - }).getBrowserLogs() - .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive"]') + }) .pause(2000) - .click('[data-id="treeViewDivtreeViewItemwebsite"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite/index.html"]') - .click('[data-id="treeViewDivtreeViewItemplugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins/README.md"]') - .click('[data-id="treeViewDivtreeViewItemrecursive"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/README.md"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/plugins"]') - .click('[data-id="treeViewDivtreeViewItemrecursive/plugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/plugins/build"]') + // check recursive submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2/submodule2.ts"]') + // check test-branch-submodule-2 submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2/submodule2.ts"]') + // check libdeep submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2/submodule2.ts"]') + // check libdeep2 submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2/recursive"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2/submodule2.ts"]') }, 'When switching branches the submodules should disappear #flaky #group4': function (browser: NightwatchBrowser) { browser .waitForElementVisible('[data-id="workspaceGitBranchesDropdown"]') .click('[data-id="workspaceGitBranchesDropdown"]') .waitForElementVisible('[data-id="custom-dropdown-menu"]') - .waitForElementContainsText('[data-id="custom-dropdown-items"]', 'origin/second') - .waitForElementPresent('[data-id="workspaceGit-origin/second"]') - .click('[data-id="workspaceGit-origin/second"]') - .waitForElementNotPresent('[data-id="treeViewDivtreeViewItemplugins"]') - .waitForElementNotPresent('[data-id="treeViewDivtreeViewItemwebsite"]') + .waitForElementContainsText('[data-id="custom-dropdown-items"]', 'origin/empty') + .waitForElementPresent('[data-id="workspaceGit-origin/empty"]') + .click('[data-id="workspaceGit-origin/empty"]') + .waitForElementNotPresent('[data-id="treeViewDivtreeViewItemlibdeep"]') + .waitForElementNotPresent('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .waitForElementNotPresent('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') }, 'When switching to main update the modules #group4': function (browser: NightwatchBrowser) { browser @@ -323,21 +336,34 @@ module.exports = { selector: '*[data-id="treeViewLitreeViewItem.git"]', timeout: 240000 }) - .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite"]') .pause(2000) - .click('[data-id="treeViewDivtreeViewItemwebsite"]') - .click('[data-id="treeViewDivtreeViewItemwebsite"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemwebsite/index.html"]') - .click('[data-id="treeViewDivtreeViewItemplugins"]') - .click('[data-id="treeViewDivtreeViewItemplugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemplugins/README.md"]') - .click('[data-id="treeViewDivtreeViewItemrecursive"]') - .click('[data-id="treeViewDivtreeViewItemrecursive"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/README.md"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/plugins"]') - .click('[data-id="treeViewDivtreeViewItemrecursive/plugins"]') - .waitForElementVisible('[data-id="treeViewDivtreeViewItemrecursive/plugins/build"]') + // check recursive submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-recursive/test-branch-submodule-2/submodule2.ts"]') + // check test-branch-submodule-2 submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemtest-branch-submodule-2/submodule2.ts"]') + // check libdeep submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep/test-branch-submodule-2/submodule2.ts"]') + // check libdeep2 submodule + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2/recursive"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2"]') + .click('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2"]') + .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2/submodule2.ts"]') }, // GIT SUBMODULES E2E ENDS From 2bbcf4a4f8cc8a6f0454b7ad8b5592980c4431ce Mon Sep 17 00:00:00 2001 From: filip mertens Date: Wed, 24 Jan 2024 13:23:54 +0100 Subject: [PATCH 09/11] reset engine --- apps/remix-ide/src/remixEngine.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide/src/remixEngine.js b/apps/remix-ide/src/remixEngine.js index cb37c77e51..5c0657ce22 100644 --- a/apps/remix-ide/src/remixEngine.js +++ b/apps/remix-ide/src/remixEngine.js @@ -10,7 +10,7 @@ export class RemixEngine extends Engine { setPluginOption ({ name, kind }) { if (kind === 'provider') return { queueTimeout: 60000 * 2 } if (name === 'LearnEth') return { queueTimeout: 60000 } - if (name === 'dGitProvider') return { queueTimeout: 60000 * 20 } + if (name === 'dGitProvider') return { queueTimeout: 60000 * 4 } if (name === 'slither') return { queueTimeout: 60000 * 4 } // Requires when a solc version is installed if (name === 'hardhat') return { queueTimeout: 60000 * 4 } if (name === 'truffle') return { queueTimeout: 60000 * 4 } From 8c9463d5d31515514237d841b0eabbbc19a385bc Mon Sep 17 00:00:00 2001 From: filip mertens Date: Wed, 24 Jan 2024 13:25:04 +0100 Subject: [PATCH 10/11] headless --- apps/remix-ide-e2e/nightwatch.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/nightwatch.ts b/apps/remix-ide-e2e/nightwatch.ts index b50a8d50fa..7e05269897 100644 --- a/apps/remix-ide-e2e/nightwatch.ts +++ b/apps/remix-ide-e2e/nightwatch.ts @@ -33,7 +33,7 @@ module.exports = { 'window-size=2560,1440', 'start-fullscreen', '--no-sandbox', - //'--headless', + '--headless', '--verbose', '--user-agent=Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36' ] From 911b6ac1e03e508900624f956be0a8b8ab818399 Mon Sep 17 00:00:00 2001 From: filip mertens Date: Wed, 24 Jan 2024 13:34:37 +0100 Subject: [PATCH 11/11] turn off flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/workspace_git.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 443d6ef53e..17a37c5d3c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts index e83635716f..fb74ce1bee 100644 --- a/apps/remix-ide-e2e/src/tests/workspace_git.test.ts +++ b/apps/remix-ide-e2e/src/tests/workspace_git.test.ts @@ -309,7 +309,7 @@ module.exports = { .click('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2"]') .waitForElementVisible('[data-id="treeViewDivtreeViewItemlibdeep2/recursive/test-branch-submodule-2/submodule2.ts"]') }, - 'When switching branches the submodules should disappear #flaky #group4': function (browser: NightwatchBrowser) { + 'When switching branches the submodules should disappear #group4': function (browser: NightwatchBrowser) { browser .waitForElementVisible('[data-id="workspaceGitBranchesDropdown"]') .click('[data-id="workspaceGitBranchesDropdown"]')