Merge pull request #446 from ethereum/fix-lint

Fixed linting bug

.eslintrc

@@ -6,7 +6,6 @@
       "sourceType": "module",
       "project": "./tsconfig.json"
     },
-    "ignorePatterns": ["**/*"],
     "plugins": ["@typescript-eslint", "@nrwl/nx"],
     "extends": [
       "eslint:recommended",

apps/remix-ide/.eslintrc

@@ -3,7 +3,7 @@
         "browser": true,
         "es6": true
     },
-    "extends": "eslint:recommended",
+    "extends": "../../.eslintrc",
     "globals": {
         "Atomics": "readonly",
         "SharedArrayBuffer": "readonly"
@@ -13,296 +13,10 @@
         "sourceType": "module"
     },
     "rules": {
-        "accessor-pairs": "error",
+        "@typescript-eslint/no-var-requires": "off",
-        "array-bracket-newline": "off",
+        "@typescript-eslint/no-empty-function": "off",
-        "array-bracket-spacing": [
+        "@typescript-eslint/explicit-module-boundary-types": "off",
-            "off",
+        "@typescript-eslint/no-this-alias": "off",
-            "never"
-        ],
-        "array-callback-return": "off",
-        "array-element-newline": "off",
-        "arrow-body-style": "off",
-        "arrow-parens": [
-            "off",
-            "always"
-        ],
-        "arrow-spacing": [
-            "error",
-            {
-                "after": true,
-                "before": true
-            }
-        ],
-        "block-scoped-var": "off",
-        "block-spacing": "error",
-        "brace-style": [
-            "off",
-            "1tbs"
-        ],
-        "callback-return": "off",
-        "camelcase": "off",
-        "capitalized-comments": "off",
-        "class-methods-use-this": "off",
-        "comma-dangle": "off",
-        "comma-spacing": [
-            "error",
-            {
-                "after": true,
-                "before": false
-            }
-        ],
-        "comma-style": [
-            "error",
-            "last"
-        ],
-        "complexity": "off",
-        "computed-property-spacing": [
-            "off",
-            "never"
-        ],
-        "consistent-return": "off",
-        "consistent-this": "off",
-        "curly": "off",
-        "default-case": "error",
-        "default-case-last": "off",
-        "default-param-last": "off",
-        "dot-location": "off",
-        "dot-notation": "off",
-        "eol-last": "error",
-        "eqeqeq": "off",
-        "func-call-spacing": "error",
-        "func-name-matching": "error",
-        "func-names": "off",
-        "func-style": [
-            "off",
-            "declaration"
-        ],
-        "function-call-argument-newline": [
-            "off",
-            "consistent"
-        ],
-        "function-paren-newline": "off",
-        "generator-star-spacing": "error",
-        "global-require": "off",
-        "grouped-accessor-pairs": "error",
-        "guard-for-in": "off",
-        "handle-callback-err": "error",
-        "id-blacklist": "error",
-        "id-length": "off",
-        "id-match": "error",
-        "implicit-arrow-linebreak": [
-            "off",
-            "beside"
-        ],
-        "indent": "off",
-        "indent-legacy": "off",
-        "init-declarations": "off",
-        "jsx-quotes": "error",
-        "key-spacing": "error",
-        "keyword-spacing": [
-            "error",
-            {
-                "after": true,
-                "before": true
-            }
-        ],
-        "line-comment-position": "off",
-        "linebreak-style": [
-            "error",
-            "unix"
-        ],
-        "lines-around-comment": "off",
-        "lines-around-directive": "off",
-        "lines-between-class-members": [
-            "off",
-            "always"
-        ],
-        "max-classes-per-file": "off",
-        "max-depth": "off",
-        "max-len": "off",
-        "max-lines": "off",
-        "max-lines-per-function": "off",
-        "max-nested-callbacks": "error",
-        "max-params": "off",
-        "max-statements": "off",
-        "max-statements-per-line": "off",
-        "multiline-comment-style": [
-            "off",
-            "separate-lines"
-        ],
-        "new-cap": "off",
-        "new-parens": "error",
-        "newline-after-var": "off",
-        "newline-before-return": "off",
-        "newline-per-chained-call": "off",
-        "no-alert": "error",
-        "no-array-constructor": "error",
-        "no-await-in-loop": "off",
-        "no-bitwise": "off",
-        "no-buffer-constructor": "error",
-        "no-caller": "error",
-        "no-catch-shadow": "error",
-        "no-confusing-arrow": "off",
-        "no-console": "off",
-        "no-constructor-return": "error",
-        "no-continue": "error",
-        "no-div-regex": "error",
-        "no-duplicate-imports": "error",
-        "no-else-return": "off",
-        "no-empty-function": "off",
-        "no-eq-null": "off",
-        "no-eval": "error",
-        "no-extend-native": "error",
-        "no-extra-bind": "error",
-        "no-extra-label": "error",
-        "no-extra-parens": "off",
-        "no-floating-decimal": "error",
-        "no-implicit-coercion": "off",
-        "no-implicit-globals": "error",
-        "no-implied-eval": "error",
-        "no-inline-comments": "off",
-        "no-invalid-this": "off",
-        "no-iterator": "error",
-        "no-label-var": "error",
-        "no-labels": "error",
-        "no-lone-blocks": "off",
-        "no-lonely-if": "off",
-        "no-loop-func": "off",
-        "no-magic-numbers": "off",
-        "no-mixed-operators": "off",
-        "no-mixed-requires": "error",
-        "no-multi-assign": "off",
-        "no-multi-spaces": "off",
-        "no-multi-str": "error",
-        "no-multiple-empty-lines": "error",
-        "no-native-reassign": "error",
-        "no-negated-condition": "off",
-        "no-negated-in-lhs": "error",
-        "no-nested-ternary": "off",
-        "no-new": "error",
-        "no-new-func": "error",
-        "no-new-object": "error",
-        "no-new-require": "error",
-        "no-new-wrappers": "error",
-        "no-octal-escape": "error",
-        "no-param-reassign": "off",
-        "no-path-concat": "error",
-        "no-plusplus": "off",
-        "no-process-env": "off",
-        "no-process-exit": "off",
-        "no-proto": "error",
-        "no-restricted-exports": "off",
-        "no-restricted-globals": "error",
-        "no-restricted-imports": "error",
-        "no-restricted-modules": "error",
-        "no-restricted-properties": "error",
-        "no-restricted-syntax": "error",
-        "no-return-assign": "error",
-        "no-return-await": "off",
-        "no-script-url": "error",
-        "no-self-compare": "error",
-        "no-sequences": "error",
-        "no-shadow": "off",
-        "no-spaced-func": "error",
-        "no-sync": "off",
-        "no-tabs": "error",
-        "no-template-curly-in-string": "error",
-        "no-ternary": "off",
-        "no-throw-literal": "error",
-        "no-trailing-spaces": "error",
-        "no-undef-init": "error",
-        "no-undefined": "off",
-        "no-underscore-dangle": "off",
-        "no-unmodified-loop-condition": "error",
-        "no-unneeded-ternary": "error",
-        "no-unused-expressions": "off",
-        "no-use-before-define": "off",
-        "no-useless-backreference": "off",
-        "no-useless-call": "error",
-        "no-useless-computed-key": "error",
-        "no-useless-concat": "off",
-        "no-useless-constructor": "error",
-        "no-useless-rename": "error",
-        "no-useless-return": "off",
-        "no-var": "off",
-        "no-void": "off",
-        "no-warning-comments": "off",
-        "no-whitespace-before-property": "error",
-        "nonblock-statement-body-position": "error",
-        "object-curly-newline": "off",
-        "object-curly-spacing": "off",
-        "object-shorthand": "off",
-        "one-var": "off",
-        "one-var-declaration-per-line": "error",
-        "operator-assignment": "off",
-        "operator-linebreak": "error",
-        "padded-blocks": "off",
-        "padding-line-between-statements": "error",
-        "prefer-arrow-callback": "off",
-        "prefer-const": "off",
-        "prefer-destructuring": "off",
-        "prefer-exponentiation-operator": "error",
-        "prefer-named-capture-group": "off",
-        "prefer-numeric-literals": "error",
-        "prefer-object-spread": "error",
-        "prefer-promise-reject-errors": "off",
-        "prefer-reflect": "off",
-        "prefer-regex-literals": "error",
-        "prefer-rest-params": "off",
-        "prefer-spread": "off",
-        "prefer-template": "off",
-        "quote-props": "off",
-        "quotes": "off",
-        "radix": "off",
-        "require-atomic-updates": "off",
-        "require-await": "off",
-        "require-jsdoc": "off",
-        "require-unicode-regexp": "off",
-        "rest-spread-spacing": "error",
-        "semi": "off",
-        "semi-spacing": "error",
-        "semi-style": "off",
-        "sort-keys": [
-            "off",
-            "asc"
-        ],
-        "sort-vars": "off",
-        "space-before-blocks": "error",
-        "space-before-function-paren": "error",
-        "space-in-parens": [
-            "error",
-            "never"
-        ],
-        "space-infix-ops": "error",
-        "space-unary-ops": "error",
-        "spaced-comment": [
-            "off",
-            "always"
-        ],
-        "strict": "off",
-        "switch-colon-spacing": "off",
-        "symbol-description": "error",
-        "template-curly-spacing": [
-            "error",
-            "never"
-        ],
-        "template-tag-spacing": [
-            "off",
-            "never"
-        ],
-        "unicode-bom": [
-            "error",
-            "never"
-        ],
-        "valid-jsdoc": "off",
-        "vars-on-top": "off",
-        "wrap-iife": "error",
-        "wrap-regex": "off",
-        "yield-star-spacing": "error",
-        "yoda": [
-            "error",
-            "never"
-        ],
         "no-unused-vars": "off",
         "no-redeclare": "off",
         "no-empty": "off",

apps/remix-ide/src/app/files/compiler-metadata.js

@@ -24,7 +24,7 @@ class CompilerMetadata extends Plugin {
     return path + '/' + this.innerPath + '/' + contractName + '.json'
   }
 
-  _MetadataFileName(path, contractName) {
+  _MetadataFileName (path, contractName) {
     return path + '/' + this.innerPath + '/' + contractName + '_metadata' + '.json'
   }
 
@@ -58,7 +58,7 @@ class CompilerMetadata extends Plugin {
 
               let parsedMetadata
               try {
-                parsedMetadata = JSON.parse(contract.object.metadata)      
+                parsedMetadata = JSON.parse(contract.object.metadata)
               } catch (e) {
                 console.log(e)
               }

apps/remix-ide/src/app/tabs/settings-tab.js

@@ -163,7 +163,7 @@ module.exports = class SettingsTab extends ViewPlugin {
 
     function onchangeGenerateContractMetadata (event) {
       const isChecked = self.config.get('settings/generate-contract-metadata')
-      
+
       self.config.set('settings/generate-contract-metadata', !isChecked)
       elementStateChanged(self._view.generateContractMetadataLabel, isChecked)
     }
@@ -186,7 +186,7 @@ module.exports = class SettingsTab extends ViewPlugin {
       self.config.set('settings/personal-mode', !isChecked)
       elementStateChanged(self._view.personalLabel, isChecked)
     }
-    function elementStateChanged(el, isChanged){
+    function elementStateChanged (el, isChanged) {
       if (isChanged) {
         el.classList.remove("text-dark")
         el.classList.add("text-secondary")

apps/remix-ide/src/lib/commands.js

@@ -25,7 +25,7 @@ const allCommands = [
   {'ethers.utils.RLP': 'This encoding method is used internally for several aspects of Ethereum, such as encoding transactions and determining contract addresses.'},
   {'ethers.Wallet': 'A wallet manages a private/public key pair which is used to cryptographically sign transactions and prove ownership on the Ethereum network.'},
   {'ethers.version': 'Contains the version of the ethers container object.'},
-  
+
   {'web3.eth': 'Eth module for interacting with the Ethereum network.'},
   {'web3.eth.accounts': 'The web3.eth.accounts contains functions to generate Ethereum accounts and sign transactions and data.'},
   {'web3.eth.abi': 'The web3.eth.abi functions let you de- and encode parameters to ABI (Application Binary Interface) for function calls to the EVM (Ethereum Virtual Machine).'},

apps/remix-ide/src/universal-dapp-styles.js

@@ -1,4 +1,4 @@
-var csjs = require('csjs-inject')
+const csjs = require('csjs-inject')
 
 var css = csjs`
   .instanceTitleContainer {

workspace.json

@@ -75,13 +75,11 @@
             "linter": "eslint",
             "config": "apps/remix-ide/.eslintrc",
             "files": [
-              "apps/remix-ide/**/*.js"
+              "apps/remix-ide/src/**/*.js"
             ],
-            "exclude": ["**/node_modules/**",
+            "exclude": [
-              "apps/remix-ide/build/**/*.js",
+              "**/node_modules/**",
               "apps/remix-ide/src/app/editor/mode-solidity.js",
-              "apps/remix-ide/soljson.js",
-              "apps/remix-ide/js/**/*.js",
               "apps/remix-ide/src/assets/js/**/*.js"
             ]
           }