Merge pull request #1250 from ethereum/cleanup-useEffect

cleanup workspaces useEffect after unmount
4 years ago · 776780c2b6
parent 099e05faa1 9507e0eeb2
commit 776780c2b6
1 changed files with 5 additions and 1 deletions
--- a/libs/remix-ui/workspace/src/lib/remix-ui-workspace.tsx
+++ b/libs/remix-ui/workspace/src/lib/remix-ui-workspace.tsx
@ -71,7 +71,7 @@ export const Workspace = (props: WorkspaceProps) => {
  }

  useEffect(() => {
-    const getWorkspaces = async () => {
+    let getWorkspaces = async () => {
      if (props.workspaces && Array.isArray(props.workspaces)) {
        if (props.workspaces.length > 0 && state.currentWorkspace === NO_WORKSPACE) {
          props.workspace.setWorkspace(props.workspaces[0])
@ -87,6 +87,10 @@ export const Workspace = (props: WorkspaceProps) => {
    }

    getWorkspaces()
+
+    return () => {
+      getWorkspaces = async () => {}
+    }
  }, [props.workspaces])

  const localhostDisconnect = () => {