Merge pull request #1919 from ethereum/fixConfig

Fix config
pull/1/head
yann300 6 years ago committed by GitHub
commit 7b7a721310
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      src/app.js
  2. 7
      src/app/tabs/settings-tab.js
  3. 11
      src/app/tabs/theme-module.js

@ -123,10 +123,10 @@ class App {
var fileStorage = new Storage('sol:') var fileStorage = new Storage('sol:')
registry.put({api: fileStorage, name: 'fileStorage'}) registry.put({api: fileStorage, name: 'fileStorage'})
var configStorage = new Storage('config:') var configStorage = new Storage('config-v0.8:')
registry.put({api: configStorage, name: 'configStorage'}) registry.put({api: configStorage, name: 'configStorage'})
self._components.config = new Config(fileStorage) self._components.config = new Config(configStorage)
registry.put({api: self._components.config, name: 'config'}) registry.put({api: self._components.config, name: 'config'})
self._components.gistHandler = new GistHandler() self._components.gistHandler = new GistHandler()
@ -335,7 +335,7 @@ Please make a backup of your contracts and start using http://remix.ethereum.org
registry.put({api: networkModule, name: 'network'}) registry.put({api: networkModule, name: 'network'})
// ----------------- theme module ---------------------------- // ----------------- theme module ----------------------------
const themeModule = new ThemeModule() const themeModule = new ThemeModule(registry)
registry.put({api: themeModule, name: 'themeModule'}) registry.put({api: themeModule, name: 'themeModule'})
// ----------------- editor panel ---------------------- // ----------------- editor panel ----------------------

@ -35,11 +35,6 @@ module.exports = class SettingsTab extends BaseApi {
} }
} /* eslint-enable */ } /* eslint-enable */
this.event = new EventManager() this.event = new EventManager()
this.initTheme()
}
initTheme () {
this.currentTheme = this._deps.themeModule.currentTheme()
} }
createThemeCheckies () { createThemeCheckies () {
@ -54,7 +49,7 @@ module.exports = class SettingsTab extends BaseApi {
<input type="radio" onchange=${event => { onswitchTheme(event, aTheme.name) }} class="align-middle form-check-input" name="theme" id="${aTheme.name}" > <input type="radio" onchange=${event => { onswitchTheme(event, aTheme.name) }} class="align-middle form-check-input" name="theme" id="${aTheme.name}" >
<label class="form-check-label" for="${aTheme.name}">${aTheme.name} (${aTheme.quality})</label> <label class="form-check-label" for="${aTheme.name}">${aTheme.name} (${aTheme.quality})</label>
</div>` </div>`
if (this.currentTheme === aTheme.name) el.querySelector('input').setAttribute('checked', 'checked') if (this._deps.themeModule.active === aTheme.name) el.querySelector('input').setAttribute('checked', 'checked')
return el return el
})} })}
</div>` </div>`

@ -1,6 +1,5 @@
import { BaseApi } from 'remix-plugin' import { BaseApi } from 'remix-plugin'
import { EventEmitter } from 'events' import { EventEmitter } from 'events'
const Storage = require('remix-lib').Storage
const themes = [ const themes = [
{name: 'Cerulean', quality: 'light', url: 'https://bootswatch.com/4/cerulean/bootstrap.min.css'}, {name: 'Cerulean', quality: 'light', url: 'https://bootswatch.com/4/cerulean/bootstrap.min.css'},
@ -25,12 +24,14 @@ const profile = {
export class ThemeModule extends BaseApi { export class ThemeModule extends BaseApi {
constructor () { constructor (registry) {
super(profile) super(profile)
this.events = new EventEmitter() this.events = new EventEmitter()
this.storage = new Storage('style:') this._deps = {
config: registry.get('config').api
}
this.themes = themes.reduce((acc, theme) => ({ ...acc, [theme.name]: theme }), {}) this.themes = themes.reduce((acc, theme) => ({ ...acc, [theme.name]: theme }), {})
this.active = this.storage.exists('theme') ? this.storage.get('theme') : 'Cerulean' this.active = this._deps.config.get('settings/theme') ? this._deps.config.get('settings/theme') : 'Flatly'
} }
/** Return the active theme */ /** Return the active theme */
@ -53,7 +54,7 @@ export class ThemeModule extends BaseApi {
} }
const next = themeName || this.active // Name const next = themeName || this.active // Name
const nextTheme = this.themes[next] // Theme const nextTheme = this.themes[next] // Theme
this.storage.set('theme', next) this._deps.config.set('settings/theme', next)
document.getElementById('theme-link').setAttribute('href', nextTheme.url) document.getElementById('theme-link').setAttribute('href', nextTheme.url)
document.documentElement.style.setProperty('--theme', nextTheme.quality) document.documentElement.style.setProperty('--theme', nextTheme.quality)
if (themeName) this.active = themeName if (themeName) this.active = themeName

Loading…
Cancel
Save