From 7fcf4453b2c42ac40e549ac75acdb2f2c677a8fc Mon Sep 17 00:00:00 2001 From: Joseph Izang Date: Tue, 16 Nov 2021 14:48:53 +0100 Subject: [PATCH] fix review comments from @ioedeveloper --- apps/remix-ide-e2e/src/helpers/init.ts | 2 +- apps/remix-ide-e2e/src/tests/plugin_api.ts | 1 - package-lock.json | 5 - package.json | 1 - workspace.json | 120 +-------------------- 5 files changed, 2 insertions(+), 127 deletions(-) diff --git a/apps/remix-ide-e2e/src/helpers/init.ts b/apps/remix-ide-e2e/src/helpers/init.ts index 1064018f63..a5926bd028 100644 --- a/apps/remix-ide-e2e/src/helpers/init.ts +++ b/apps/remix-ide-e2e/src/helpers/init.ts @@ -5,7 +5,7 @@ require('dotenv').config() export default function (browser: NightwatchBrowser, callback: VoidFunction, url?: string, preloadPlugins = true): void { browser .url(url || 'http://127.0.0.1:8080') - .pause(10000) + .pause(6000) .switchBrowserTab(0) .waitForElementVisible('[id="remixTourSkipbtn"]') .click('[id="remixTourSkipbtn"]') diff --git a/apps/remix-ide-e2e/src/tests/plugin_api.ts b/apps/remix-ide-e2e/src/tests/plugin_api.ts index ba1cab26ee..2ad4d82144 100644 --- a/apps/remix-ide-e2e/src/tests/plugin_api.ts +++ b/apps/remix-ide-e2e/src/tests/plugin_api.ts @@ -112,7 +112,6 @@ const clickAndCheckLog = async (browser: NightwatchBrowser, buttonText: string, if (methodResult && typeof methodResult !== 'string') { methodResult = JSON.stringify(methodResult) } if (eventResult && typeof eventResult !== 'string') { eventResult = JSON.stringify(eventResult) } if (buttonText) { - console.log('this is buttonText in this test', buttonText) await clickButton(browser, buttonText) } await debugValues(browser, 'methods', methodResult) diff --git a/package-lock.json b/package-lock.json index f23ab3f7b6..78b44c9554 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15422,11 +15422,6 @@ } } }, - "core-js": { - "version": "3.18.2", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-3.18.2.tgz", - "integrity": "sha512-zNhPOUoSgoizoSQFdX1MeZO16ORRb9FFQLts8gSYbZU5FcgXhp24iMWMxnOQo5uIaIG7/6FA/IqJPwev1o9ZXQ==" - }, "core-js-compat": { "version": "3.19.1", "resolved": "https://registry.npmjs.org/core-js-compat/-/core-js-compat-3.19.1.tgz", diff --git a/package.json b/package.json index 5a6030a591..eafe773515 100644 --- a/package.json +++ b/package.json @@ -161,7 +161,6 @@ "chokidar": "^2.1.8", "color-support": "^1.1.3", "commander": "^2.20.3", - "core-js": "^3.6.5", "deep-equal": "^1.0.1", "document-register-element": "1.13.1", "ethereumjs-util": "^7.0.10", diff --git a/workspace.json b/workspace.json index df30e7038e..22600e7994 100644 --- a/workspace.json +++ b/workspace.json @@ -1099,20 +1099,6 @@ "linter": "eslint" } }, - "@remix-ui-verticaliconspanel": { - "root": "libs/@remix-ui/verticaliconspanel", - "sourceRoot": "libs/@remix-ui/verticaliconspanel/src", - "projectType": "library", - "architect": { - "lint": { - "builder": "@nrwl/linter:eslint", - "options": { - "lintFilePatterns": [ - "libs/@remix-ui/verticaliconspanel/**/*.{ts,tsx,js,jsx}" - ] - } - } - }, "@nrwl/web": { "application": { "linter": "eslint" @@ -1126,16 +1112,6 @@ "linter": "eslint" } } - } - }, - "cli": { - "defaultCollection": "@nrwl/react" - }, - "schematics": { - "@nrwl/workspace": { - "library": { - "linter": "eslint" - } }, "cli": { "defaultCollection": "@nrwl/react" @@ -1174,99 +1150,5 @@ "linter": "eslint" } }, - "@remix-ui-verticaliconspanel": { - "root": "libs/@remix-ui/verticaliconspanel", - "sourceRoot": "libs/@remix-ui/verticaliconspanel/src", - "projectType": "library", - "architect": { - "lint": { - "builder": "@nrwl/linter:eslint", - "options": { - "lintFilePatterns": [ - "libs/@remix-ui/verticaliconspanel/**/*.{ts,tsx,js,jsx}" - ] - } - } - }, - "@nrwl/web": { - "application": { - "linter": "eslint" - } - }, - "@nrwl/node": { - "application": { - "linter": "eslint" - }, - "library": { - "linter": "eslint" - } - } - } - }, - "cli": { - "defaultCollection": "@nrwl/react" - }, - "schematics": { - "@nrwl/workspace": { - "library": { - "linter": "eslint" - } - }, - "@nrwl/cypress": { - "cypress-project": { - "linter": "eslint" - } - }, - "@nrwl/react": { - "application": { - "style": "css", - "linter": "eslint", - "babel": true - }, - "component": { - "style": "css" - }, - "library": { - "style": "css", - "linter": "eslint" - } - }, - "@nrwl/next": { - "application": { - "linter": "eslint" - } - }, - "@nrwl/web": { - "application": { - "linter": "eslint" - } - }, - "@nrwl/node": { - "application": { - "linter": "eslint" - }, - "library": { - "linter": "eslint" - } - }, - "@nrwl/nx-plugin": { - "plugin": { - "linter": "eslint" - } - }, - "@nrwl/nest": { - "application": { - "linter": "eslint" - } - }, - "@nrwl/express": { - "application": { - "linter": "eslint" - }, - "library": { - "linter": "eslint" - } - } - }, - "defaultProject": "remix-ide" + "defaultProject": "remix-ide" }