From 8bfd802f087dc7770d38fd12bd4e170d1c2b8dc3 Mon Sep 17 00:00:00 2001
From: yann300 <yann.levreau@gmail.com>
Date: Fri, 17 Aug 2018 12:44:25 +0200
Subject: [PATCH] refactor plugin loading/removing

---
 src/app/panels/righthand-panel.js | 17 +--------
 src/app/tabs/settings-tab.js      | 60 +++++++++++++++++++++++++------
 2 files changed, 51 insertions(+), 26 deletions(-)

diff --git a/src/app/panels/righthand-panel.js b/src/app/panels/righthand-panel.js
index e1852c9b5d..077f0d4334 100644
--- a/src/app/panels/righthand-panel.js
+++ b/src/app/panels/righthand-panel.js
@@ -15,10 +15,8 @@ const SupportTab = require('../tabs/support-tab')
 const PluginTab = require('../tabs/plugin-tab')
 const TestTab = require('../tabs/test-tab')
 const RunTab = require('../tabs/run-tab')
-const plugins = require('../plugin/plugins')
 const DraggableContent = require('../ui/draggableContent')
 
-var toolTip = require('../ui/tooltip')
 const EventManager = remixLib.EventManager
 const styles = styleguide.chooser()
 
@@ -71,23 +69,10 @@ module.exports = class RighthandPanel {
       test: new TestTab(self._components.registry)
     }
 
-    self.event.register('plugin-loadRequest', json => {
+    self._components.settings.event.register('plugin-loadRequest', json => {
       self.loadPlugin(json)
     })
 
-    self.event.register('plugin-name-loadRequest', name => {
-      var plugin = plugins[name]
-      if (plugin) {
-        if (!self._components.pluginManager.plugins[plugin.title]) {
-          self.loadPlugin(plugin)
-        } else {
-          toolTip(name + ' already loaded')
-        }
-      } else {
-        toolTip('unknown plugin ' + name)
-      }
-    })
-
     self.loadPlugin = function (json) {
       var modal = new DraggableContent(() => {
         self._components.pluginManager.unregister(json)
diff --git a/src/app/tabs/settings-tab.js b/src/app/tabs/settings-tab.js
index fbb1557774..4978d7e8f5 100644
--- a/src/app/tabs/settings-tab.js
+++ b/src/app/tabs/settings-tab.js
@@ -2,8 +2,8 @@ var yo = require('yo-yo')
 var csjs = require('csjs-inject')
 var remixLib = require('remix-lib')
 
+const defaultPlugins = require('../plugin/plugins')
 var globalRegistry = require('../../global/registry')
-var modal = require('../ui/modal-dialog-custom')
 var tooltip = require('../ui/tooltip')
 var copyToClipboard = require('../ui/copy-to-clipboard')
 var styleGuide = require('../ui/styles-guide/theme-chooser')
@@ -30,6 +30,7 @@ module.exports = class SettingsTab {
       optionVM: null, personal: null, warnPersonalMode: null,
       pluginInput: null, versionSelector: null, version: null,
       theme: { dark: null, light: null },
+      plugins: {},
       config: {
         general: null, themes: null,
         plugin: null
@@ -109,15 +110,15 @@ module.exports = class SettingsTab {
           <label for="themeDark">Dark Theme</label>
         </div>
       </div>`
+    self._view.config.plugins = yo`<div></div>`
     self._view.config.plugin = yo`
       <div class="${css.info}">
         <div class=${css.title}>Plugin</div>
         <div class="${css.crowNoFlex}">
-          <input onclick=${() => { onLoadPlugin('oraclize') }} type="button" value="Oraclize" class="${css.pluginLoad}">
-          <input onclick=${() => { onLoadPlugin('etherscan-general') }} type="button" value="Etherscan-general" class="${css.pluginLoad}">
           <div>Load plugin from JSON description: </div>
           ${self._view.pluginInput}
           <input onclick=${onloadPluginJson} type="button" value="Load" class="${css.pluginLoad}">
+          ${self._view.config.plugins}
         </div>
       </div>`
     self._view.el = yo`
@@ -127,21 +128,57 @@ module.exports = class SettingsTab {
         ${self._view.gistToken}
         ${self._view.config.themes}
       </div>`
-    function onchangeOption (event) {
-      self._deps.config.set('settings/always-use-vm', !self._deps.config.get('settings/always-use-vm'))
+
+    function loadPlugins (plugins, opt) {
+      for (var k in plugins) {
+        var plugin = plugins[k]
+        if (!self._view.plugins[plugin.title]) self._view.plugins[plugin.title] = {}
+        self._view.plugins[plugin.title].json = plugin
+        self._view.plugins[plugin.title].el = yo`<div class="${css.pluginLoad}">
+        <div style="display: inline-block" onclick=${() => { onLoadPlugin(plugin.title) }}>${plugin.title}</div>
+        ${opt.removable ? yo`<span class="removePlugin" onclick=${() => { onRemovePlugin(plugin.title) }}><i class="fa fa-close"></i></span>` : yo`<span></span>`}
+        </div>`
+        self._view.config.plugins.appendChild(self._view.plugins[plugin.title].el)
+      }
     }
+
+    function getSavedPlugin () {
+      var savedPlugin = self._deps.config.get('settings/plugins-list')
+      return savedPlugin ? JSON.parse(savedPlugin) : {}
+    }
+    function setSavedPlugin (savedPlugins) {
+      self._deps.config.set('settings/plugins-list', JSON.stringify(savedPlugins))
+    }
+    loadPlugins(defaultPlugins, {removable: false})
+    loadPlugins(getSavedPlugin(), {removable: true})
+
     function onLoadPlugin (name) {
-      // @TODO: BAD! REFACTOR: no module should trigger events of another modules emitter
-      self._deps.righthandpanel.event.trigger('plugin-name-loadRequest', [name])
+      self.event.trigger('plugin-loadRequest', [self._view.plugins[name].json])
+    }
+    function onRemovePlugin (name) {
+      var savedPlugin = getSavedPlugin()
+      delete savedPlugin[name]
+      setSavedPlugin(savedPlugin)
+      if (self._view.plugins[name]) {
+        self._view.plugins[name].el.parentNode.removeChild(self._view.plugins[name].el)
+        delete self._view.plugins[name]
+      }
     }
     function onloadPluginJson (event) {
       try {
         var json = JSON.parse(self._view.pluginInput.value)
       } catch (e) {
-        return modal.alert('cannot parse the plugin definition to JSON')
+        return tooltip('cannot parse the plugin definition to JSON')
       }
-      // @TODO: BAD! REFACTOR: no module should trigger events of another modules emitter
-      self._deps.righthandpanel.event.trigger('plugin-loadRequest', [json])
+      var savedPlugin = getSavedPlugin()
+      if (self._view.plugins[json.title]) return tooltip('Plugin already loaded')
+      savedPlugin[json.title] = json
+      setSavedPlugin(savedPlugin)
+      loadPlugins([json], {removable: true})
+    }
+
+    function onchangeOption (event) {
+      self._deps.config.set('settings/always-use-vm', !self._deps.config.get('settings/always-use-vm'))
     }
     function onswitch2darkTheme (event) {
       styleGuide.switchTheme('dark')
@@ -218,6 +255,9 @@ const css = csjs`
     width: inherit;
     display: inline-block;
   }
+  .removePlugin {
+    cursor: pointer;
+  }
   i.warnIt {
     color: ${styles.appProperties.warningText_Color};
   }