From bbbb25e22acf2f40240bd7b478910cc7746011d6 Mon Sep 17 00:00:00 2001 From: aniket-engg Date: Tue, 9 Feb 2021 21:29:11 +0530 Subject: [PATCH 1/2] reset staticAnalysis after deactivation --- apps/remix-ide/src/app/tabs/analysis-tab.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/apps/remix-ide/src/app/tabs/analysis-tab.js b/apps/remix-ide/src/app/tabs/analysis-tab.js index 7128c3fe87..bfefc6d758 100644 --- a/apps/remix-ide/src/app/tabs/analysis-tab.js +++ b/apps/remix-ide/src/app/tabs/analysis-tab.js @@ -28,6 +28,9 @@ class AnalysisTab extends ViewPlugin { } render () { + const listOfPlugins = localStorage.getItem('workspace') + // Reset state if plugin is deactivated + if (!listOfPlugins.includes('solidityStaticAnalysis')) this.staticanalysis = null if (!this.staticanalysis) this.staticanalysis = new StaticAnalysis(this.registry, this) this.staticanalysis.event.register('staticAnaysisWarning', (count) => { if (count > 0) { From 065b91ab450c29d64d4dc907c402dc326a1883de Mon Sep 17 00:00:00 2001 From: aniket-engg Date: Wed, 10 Feb 2021 15:58:22 +0530 Subject: [PATCH 2/2] remove localStorage --- apps/remix-ide/src/app/tabs/analysis-tab.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/remix-ide/src/app/tabs/analysis-tab.js b/apps/remix-ide/src/app/tabs/analysis-tab.js index bfefc6d758..4406ba875e 100644 --- a/apps/remix-ide/src/app/tabs/analysis-tab.js +++ b/apps/remix-ide/src/app/tabs/analysis-tab.js @@ -28,10 +28,7 @@ class AnalysisTab extends ViewPlugin { } render () { - const listOfPlugins = localStorage.getItem('workspace') - // Reset state if plugin is deactivated - if (!listOfPlugins.includes('solidityStaticAnalysis')) this.staticanalysis = null - if (!this.staticanalysis) this.staticanalysis = new StaticAnalysis(this.registry, this) + this.staticanalysis = new StaticAnalysis(this.registry, this) this.staticanalysis.event.register('staticAnaysisWarning', (count) => { if (count > 0) { this.emit('statusChanged', { key: count, title: `${count} warning${count === 1 ? '' : 's'}`, type: 'warning' })