From 9861d4c96c7f6c1dc5026f55aae33c80cd029eca Mon Sep 17 00:00:00 2001 From: Joseph Izang Date: Tue, 28 Feb 2023 17:12:20 +0100 Subject: [PATCH] address comments from @aniket-engg --- .../solidity-uml-gen/src/lib/components/UmlDownload.tsx | 8 -------- .../solidity-uml-gen/src/lib/solidity-uml-gen.tsx | 2 -- .../src/lib/utilities/UmlDownloadStrategy.ts | 1 - 3 files changed, 11 deletions(-) diff --git a/libs/remix-ui/solidity-uml-gen/src/lib/components/UmlDownload.tsx b/libs/remix-ui/solidity-uml-gen/src/lib/components/UmlDownload.tsx index feba73b050..69bbd20610 100644 --- a/libs/remix-ui/solidity-uml-gen/src/lib/components/UmlDownload.tsx +++ b/libs/remix-ui/solidity-uml-gen/src/lib/components/UmlDownload.tsx @@ -72,10 +72,6 @@ export default function UmlDownload(props: UmlDownloadProps) { { - _paq.push(['trackEvent', 'solidityumlgen', 'download', 'downloadAsPng']) - props.download('png') - }} className='far fa-image pl-2' > @@ -103,10 +99,6 @@ export default function UmlDownload(props: UmlDownloadProps) { { - _paq.push(['trackEvent', 'solUmlgen', 'download', 'downloadAsPdf']) - props.download('pdf') - }} className='far fa-file-pdf pl-2' > diff --git a/libs/remix-ui/solidity-uml-gen/src/lib/solidity-uml-gen.tsx b/libs/remix-ui/solidity-uml-gen/src/lib/solidity-uml-gen.tsx index 565f90c795..07baae3c46 100644 --- a/libs/remix-ui/solidity-uml-gen/src/lib/solidity-uml-gen.tsx +++ b/libs/remix-ui/solidity-uml-gen/src/lib/solidity-uml-gen.tsx @@ -42,10 +42,8 @@ export function RemixUiSolidityUmlGen ({ updatedSvg, loading, fileName }: RemixU const download = useCallback((fileType: UmlFileType) => { if (umlCopy.length === 0) { - console.log('svg not valid yet!') return } - console.log({ umlCopy }) umlDownloader.download(umlCopy, fileName, fileType) }, [updatedSvg, fileName]) diff --git a/libs/remix-ui/solidity-uml-gen/src/lib/utilities/UmlDownloadStrategy.ts b/libs/remix-ui/solidity-uml-gen/src/lib/utilities/UmlDownloadStrategy.ts index 1816980143..24d6124b29 100644 --- a/libs/remix-ui/solidity-uml-gen/src/lib/utilities/UmlDownloadStrategy.ts +++ b/libs/remix-ui/solidity-uml-gen/src/lib/utilities/UmlDownloadStrategy.ts @@ -59,7 +59,6 @@ class ImageUmlDownloadStrategy implements IUmlDownloadStrategy { const a = document.createElement('a') a.download = fileName.split('/')[1].split('.')[0].concat('.png') a.href = png - console.log('about to click the link to download the png!!!') a.click() } img.src = url