From a28916d551452d5e23300e0d7a700c4187cf1f9b Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 22 Aug 2019 10:33:15 +0200 Subject: [PATCH 1/3] listen on vyper compiler --- src/app/tabs/runTab/model/dropdownlogic.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/app/tabs/runTab/model/dropdownlogic.js b/src/app/tabs/runTab/model/dropdownlogic.js index 2c90db2920..46ae90ddff 100644 --- a/src/app/tabs/runTab/model/dropdownlogic.js +++ b/src/app/tabs/runTab/model/dropdownlogic.js @@ -28,13 +28,19 @@ class DropdownLogic { // TODO: can be moved up; the event in contractDropdown will have to refactored a method instead listenToCompilationEvents () { - this.runView.on('solidity', 'compilationFinished', (file, source, languageVersion, data) => { + let broadcastCompilationResult = (file, source, languageVersion, data) => { // TODO check whether the tab is configured let compiler = new CompilerAbstract(languageVersion, data, source) this.compilersArtefacts[languageVersion] = compiler this.compilersArtefacts['__last'] = compiler - this.event.trigger('newlyCompiled', [true, data, source, compiler, languageVersion]) - }) + this.event.trigger('newlyCompiled', [true, data, source, compiler, languageVersion, file]) + } + this.runView.on('solidity', 'compilationFinished', (file, source, languageVersion, data) => + broadcastCompilationResult(file, source, languageVersion, data) + ) + this.runView.on('vyper', 'compilationFinished', (file, source, languageVersion, data) => + broadcastCompilationResult(file, source, languageVersion, data) + ) } loadContractFromAddress (address, confirmCb, cb) { From f330fa750181bd806cb9066370eb3f26f85a3298 Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 22 Aug 2019 10:33:31 +0200 Subject: [PATCH 2/3] add file name --- src/app/tabs/runTab/contractDropdown.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/tabs/runTab/contractDropdown.js b/src/app/tabs/runTab/contractDropdown.js index 94d84d0179..ab9aa864ea 100644 --- a/src/app/tabs/runTab/contractDropdown.js +++ b/src/app/tabs/runTab/contractDropdown.js @@ -17,14 +17,14 @@ class ContractDropdownUI { } listenToEvents () { - this.dropdownLogic.event.register('newlyCompiled', (success, data, source, compiler, compilerFullName) => { + this.dropdownLogic.event.register('newlyCompiled', (success, data, source, compiler, compilerFullName, file) => { if (!document.querySelector(`.${css.contractNames.classNames[0]}`)) return var contractNames = document.querySelector(`.${css.contractNames.classNames[0]}`) contractNames.innerHTML = '' if (success) { this.selectContractNames.removeAttribute('disabled') this.dropdownLogic.getCompiledContracts(compiler, compilerFullName).forEach((contract) => { - contractNames.appendChild(yo``) + contractNames.appendChild(yo``) }) } else { this.selectContractNames.setAttribute('disabled', true) From dfe338d050bc40a95e7b026d847d67e5855aba74 Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 22 Aug 2019 10:57:42 +0200 Subject: [PATCH 3/3] fix tests --- src/app/tabs/runTab/contractDropdown.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/tabs/runTab/contractDropdown.js b/src/app/tabs/runTab/contractDropdown.js index ab9aa864ea..da3acb8886 100644 --- a/src/app/tabs/runTab/contractDropdown.js +++ b/src/app/tabs/runTab/contractDropdown.js @@ -24,7 +24,7 @@ class ContractDropdownUI { if (success) { this.selectContractNames.removeAttribute('disabled') this.dropdownLogic.getCompiledContracts(compiler, compilerFullName).forEach((contract) => { - contractNames.appendChild(yo``) + contractNames.appendChild(yo``) }) } else { this.selectContractNames.setAttribute('disabled', true) @@ -124,7 +124,7 @@ class ContractDropdownUI { getSelectedContract () { var contract = this.selectContractNames.children[this.selectContractNames.selectedIndex] - var contractName = contract.innerHTML + var contractName = contract.getAttribute('value') var compilerAtributeName = contract.getAttribute('compiler') return this.dropdownLogic.getSelectedContract(contractName, compilerAtributeName)