From a20b9186c5d8c82ff16c0e9a7ab3ce7e0e81a913 Mon Sep 17 00:00:00 2001
From: bunsenstraat <filip@give.it>
Date: Tue, 9 Jan 2024 07:04:01 +0100
Subject: [PATCH] resolves comments

---
 apps/remix-ide/src/app/files/fileProvider.ts    |  1 -
 .../plugins/electron/compilerLoaderPlugin.ts    |  5 -----
 .../plugins/electron/electronConfigPlugin.ts    |  7 -------
 .../src/app/plugins/electron/isoGitPlugin.ts    | 17 -----------------
 .../src/app/plugins/electron/templatesPlugin.ts |  2 --
 .../lib/components/homeTabFeaturedPlugins.tsx   |  4 ++--
 6 files changed, 2 insertions(+), 34 deletions(-)

diff --git a/apps/remix-ide/src/app/files/fileProvider.ts b/apps/remix-ide/src/app/files/fileProvider.ts
index 81c8c740ec..715b5d3bff 100644
--- a/apps/remix-ide/src/app/files/fileProvider.ts
+++ b/apps/remix-ide/src/app/files/fileProvider.ts
@@ -287,7 +287,6 @@ export default class FileProvider {
           // ^ ret does not accept path starting with '/'
         }
       }
-      //console.log(`resolveDirectory ${path} took ${Date.now() - startTime} ms`)
       if (cb) cb(null, ret)
       return ret
     } catch (error) {
diff --git a/apps/remix-ide/src/app/plugins/electron/compilerLoaderPlugin.ts b/apps/remix-ide/src/app/plugins/electron/compilerLoaderPlugin.ts
index e2e59cd0cf..04b6c8ba1c 100644
--- a/apps/remix-ide/src/app/plugins/electron/compilerLoaderPlugin.ts
+++ b/apps/remix-ide/src/app/plugins/electron/compilerLoaderPlugin.ts
@@ -46,11 +46,6 @@ export class compilerLoaderPlugin extends Plugin {
 
     this.emit('jsonBinDataLoaded', response)
   }
-
-  async onActivation(): Promise<void> {
-
-  }
-
 }
 
 export class compilerLoaderPluginDesktop extends ElectronPlugin {
diff --git a/apps/remix-ide/src/app/plugins/electron/electronConfigPlugin.ts b/apps/remix-ide/src/app/plugins/electron/electronConfigPlugin.ts
index 3289b4a845..324d2774be 100644
--- a/apps/remix-ide/src/app/plugins/electron/electronConfigPlugin.ts
+++ b/apps/remix-ide/src/app/plugins/electron/electronConfigPlugin.ts
@@ -8,12 +8,5 @@ export class electronConfig extends ElectronPlugin {
       description: 'electronconfig',
     })
     this.methods = []
-    
   }
-
-  onActivation(): void {
-
-  }
-
-
 }
\ No newline at end of file
diff --git a/apps/remix-ide/src/app/plugins/electron/isoGitPlugin.ts b/apps/remix-ide/src/app/plugins/electron/isoGitPlugin.ts
index 049cd33900..9363a533ba 100644
--- a/apps/remix-ide/src/app/plugins/electron/isoGitPlugin.ts
+++ b/apps/remix-ide/src/app/plugins/electron/isoGitPlugin.ts
@@ -8,22 +8,5 @@ export class isoGitPlugin extends ElectronPlugin {
       description: 'isogit',
     })
     this.methods = []
-    
   }
-
-  async onActivation(): Promise<void> {
-
-    setTimeout(async () => {
-      const version = await this.call('isogit', 'version')
-      if(version){
-      //this.call('terminal', 'log', version)
-      }else{
-      //this.call('terminal', 'log', 'Git is not installed on the system. Using builtin git instead. Performance will be affected. It is better to install git on the system and configure the credentials to connect to GitHub etc.')
-      }
-  
-  
-    }, 5000)
-  }
-
-
 }
\ No newline at end of file
diff --git a/apps/remix-ide/src/app/plugins/electron/templatesPlugin.ts b/apps/remix-ide/src/app/plugins/electron/templatesPlugin.ts
index 3bc4286244..4e0c2df15c 100644
--- a/apps/remix-ide/src/app/plugins/electron/templatesPlugin.ts
+++ b/apps/remix-ide/src/app/plugins/electron/templatesPlugin.ts
@@ -8,6 +8,4 @@ export class electronTemplates extends ElectronPlugin {
       description: 'templates',
     })
   }
-  onActivation(): void {
-  } 
 }
diff --git a/libs/remix-ui/home-tab/src/lib/components/homeTabFeaturedPlugins.tsx b/libs/remix-ui/home-tab/src/lib/components/homeTabFeaturedPlugins.tsx
index fc83101850..74a439979b 100644
--- a/libs/remix-ui/home-tab/src/lib/components/homeTabFeaturedPlugins.tsx
+++ b/libs/remix-ui/home-tab/src/lib/components/homeTabFeaturedPlugins.tsx
@@ -74,8 +74,8 @@ function HomeTabFeaturedPlugins({plugin}: HomeTabFeaturedPluginsProps) {
   }
   const startCookbook = async () => {
     await plugin.appManager.activatePlugin(['cookbookdev'])
-    plugin.verticalIcons.select('cookbook.dev')
-    _paq.push(['trackEvent', 'hometabActivate', 'userActivate', 'cookbook.dev'])
+    plugin.verticalIcons.select('cookbookdev')
+    _paq.push(['trackEvent', 'hometabActivate', 'userActivate', 'cookbookdev'])
   }
   const startSolidityUnitTesting = async () => {
     await plugin.appManager.activatePlugin(['solidity', 'solidityUnitTesting'])