From 0c16c8cd29f1bb9e76e4d1afee63c25c959324ac Mon Sep 17 00:00:00 2001 From: Alex Beregszaszi Date: Sat, 10 Sep 2016 19:48:37 +0100 Subject: [PATCH] Fix click handler for warnings/errors --- src/app/renderer.js | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/app/renderer.js b/src/app/renderer.js index 82a61be019..021b7bd8c1 100644 --- a/src/app/renderer.js +++ b/src/app/renderer.js @@ -34,6 +34,7 @@ function Renderer (editor, web3, updateFiles, udapp, executionContext, formalVer } Renderer.prototype.error = function (message, container, noAnnotations) { + var self = this; var type = utils.errortype(message); var $pre = $('
').text(message);
   var $error = $('
').prepend($pre); @@ -46,8 +47,8 @@ Renderer.prototype.error = function (message, container, noAnnotations) { var errFile = err[1]; var errLine = parseInt(err[2], 10) - 1; var errCol = err[4] ? parseInt(err[4], 10) : 0; - if (!noAnnotations && (errFile === '' || errFile === utils.fileNameFromKey(this.editor.getCacheFile()))) { - this.editor.addAnnotation({ + if (!noAnnotations && (errFile === '' || errFile === utils.fileNameFromKey(self.editor.getCacheFile()))) { + self.editor.addAnnotation({ row: errLine, column: errCol, text: message, @@ -55,13 +56,13 @@ Renderer.prototype.error = function (message, container, noAnnotations) { }); } $error.click(function (ev) { - if (errFile !== '' && errFile !== utils.fileNameFromKey(this.editor.getCacheFile()) && this.editor.hasFile(errFile)) { + if (errFile !== '' && errFile !== utils.fileNameFromKey(self.editor.getCacheFile()) && self.editor.hasFile(errFile)) { // Switch to file - this.editor.setCacheFile(utils.fileKey(errFile)); - this.updateFiles(); + self.editor.setCacheFile(utils.fileKey(errFile)); + self.updateFiles(); // @TODO could show some error icon in files with errors } - this.editor.handleErrorClick(errLine, errCol); + self.editor.handleErrorClick(errLine, errCol); }); $error.find('.close').click(function (ev) { ev.preventDefault();