From 3a4334f6d960002773b46ec50e2383fb02312846 Mon Sep 17 00:00:00 2001 From: yann300 Date: Tue, 18 Sep 2018 09:15:44 +0200 Subject: [PATCH 1/3] alert if panic error --- src/app/tabs/compile-tab.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js index ef83cf1f27..397ad6b46d 100644 --- a/src/app/tabs/compile-tab.js +++ b/src/app/tabs/compile-tab.js @@ -138,6 +138,13 @@ module.exports = class CompileTab { if (data['error']) { error = true self._deps.renderer.error(data['error'].formattedMessage, self._view.errorContainer, {type: data['error'].severity || 'error'}) + if (data['error'].mode === 'panic') { + return modalDialogCustom.alert(yo`

+ The compiler returned with the following internal error:
${data['error'].formattedMessage}.
+ The compiler might be in a non-sane state, please be careful and do not use further compilation data to deploy to mainnet. + It is heavily recommended to use another browser (not affected by this issue) until the issue is finally fixed.

+ Please join remix gitter channel for more information.
`) + } } if (data.errors && data.errors.length) { error = true @@ -447,6 +454,10 @@ module.exports = class CompileTab { } const css = csjs` + .panicError { + color: red; + font-size: 20px; + } .crow { display: flex; overflow: auto; From 495ed2d7caf15278a8d951e78c8a85b3178dddfb Mon Sep 17 00:00:00 2001 From: yann300 Date: Tue, 18 Sep 2018 15:59:22 +0200 Subject: [PATCH 2/3] styling --- src/app/tabs/compile-tab.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js index 397ad6b46d..fe233c08af 100644 --- a/src/app/tabs/compile-tab.js +++ b/src/app/tabs/compile-tab.js @@ -139,7 +139,7 @@ module.exports = class CompileTab { error = true self._deps.renderer.error(data['error'].formattedMessage, self._view.errorContainer, {type: data['error'].severity || 'error'}) if (data['error'].mode === 'panic') { - return modalDialogCustom.alert(yo`

+ return modalDialogCustom.alert(yo`
The compiler returned with the following internal error:
${data['error'].formattedMessage}.
The compiler might be in a non-sane state, please be careful and do not use further compilation data to deploy to mainnet. It is heavily recommended to use another browser (not affected by this issue) until the issue is finally fixed.

From b291fecb32539396695d8391888c3eed14fad4da Mon Sep 17 00:00:00 2001 From: yann300 Date: Wed, 19 Sep 2018 12:20:51 +0200 Subject: [PATCH 3/3] Update compile-tab.js --- src/app/tabs/compile-tab.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js index fe233c08af..17dd086717 100644 --- a/src/app/tabs/compile-tab.js +++ b/src/app/tabs/compile-tab.js @@ -142,7 +142,7 @@ module.exports = class CompileTab { return modalDialogCustom.alert(yo`
The compiler returned with the following internal error:
${data['error'].formattedMessage}.
The compiler might be in a non-sane state, please be careful and do not use further compilation data to deploy to mainnet. - It is heavily recommended to use another browser (not affected by this issue) until the issue is finally fixed.

+ It is heavily recommended to use another browser not affected by this issue (Firefox is known to not be affected).
Please join remix gitter channel for more information.
`) } }