address review comments from @ioedeveloper

pull/1671/head
Joseph Izang 3 years ago
parent a7327583f6
commit b645b10b1a
  1. 35
      .eslintrc.json
  2. 3
      libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx
  3. 7
      libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx

@ -1,35 +0,0 @@
{
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nrwl/nx"],
"overrides": [
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {
"@nrwl/nx/enforce-module-boundaries": [
"error",
{
"enforceBuildableLibDependency": true,
"allow": [],
"depConstraints": [
{
"sourceTag": "*",
"onlyDependOnLibsWithTags": ["*"]
}
]
}
]
}
},
{
"files": ["*.ts", "*.tsx"],
"extends": ["plugin:@nrwl/nx/typescript"],
"rules": {}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nrwl/nx/javascript"],
"rules": {}
}
]
}

@ -3,8 +3,9 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import VerticalIconsContextMenu from '../vertical-icons-context-menu'
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import React, { Fragment, SyntheticEvent, useRef, useState } from 'react'
import React, { Fragment, SyntheticEvent, useEffect, useRef, useState } from 'react'
import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel'
// import * as helper from '../../../../../../apps/remix-ide/src/lib/helper'
interface IconProps {
verticalIconPlugin: VerticalIcons

@ -1,11 +1,9 @@
/* eslint-disable no-use-before-define */
/* eslint-disable @typescript-eslint/no-unused-vars */
import React, {
import {
Fragment,
useEffect,
useReducer,
useRef,
useState
useRef
} from 'react'
import './remix-ui-vertical-icons-panel.css'
@ -25,7 +23,6 @@ export function RemixUiVerticalIconsPanel ({
}: RemixUiVerticalIconsPanelProps) {
const scrollableRef = useRef<any>()
const iconPanelRef = useRef<any>()
// const [first] = useState(localStorage.getItem('firstTime'))
function onThemeChanged (themeType: any) {
const invert = themeType === 'dark' ? 1 : 0

Loading…
Cancel
Save