From 45da22c19cf99b25bfc42d1bf144a223f0105ed9 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Tue, 13 Nov 2018 16:32:18 +0100
Subject: [PATCH 01/10] added check/uncheck all to testing tab

---
 src/app/tabs/styles/test-tab-styles.js |  7 +++++-
 src/app/tabs/test-tab.js               | 30 +++++++++++++++++++++++---
 2 files changed, 33 insertions(+), 4 deletions(-)

diff --git a/src/app/tabs/styles/test-tab-styles.js b/src/app/tabs/styles/test-tab-styles.js
index cc79dc8f18..7a3c663a79 100644
--- a/src/app/tabs/styles/test-tab-styles.js
+++ b/src/app/tabs/styles/test-tab-styles.js
@@ -45,6 +45,8 @@ var css = csjs`
   .buttons {
     ${styles.rightPanel.testTab.box_listTests};
     margin: 2%;
+    display: flex;
+    align-items: center;
   }
   .runButton {
     ${styles.rightPanel.testTab.button_runTests};
@@ -58,6 +60,9 @@ var css = csjs`
     font-weight: bold;
     margin-bottom: 1em;
   }
+  .label {
+    display: flex;
+    align-items: center;
+  }
 `
-
 module.exports = css
diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index bb85ba84a2..7aab707694 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -101,7 +101,7 @@ module.exports = class TestTab {
 
     self._deps.filePanel.event.register('newTestFileCreated', file => {
       var testList = document.querySelector("[class^='testList']")
-      var test = yo`<label><input onchange=${(e) => toggleCheckbox(e, file)} type="checkbox" checked="true">${file}</label>`
+      var test = yo`<label><input class="singleTest" onchange=${(e) => toggleCheckbox(e, file)} type="checkbox" checked="true">${file}</label>`
       testList.appendChild(test)
       self.data.allTests.push(file)
       self.data.selectedTests.push(file)
@@ -133,13 +133,29 @@ module.exports = class TestTab {
 
     function listTests () {
       var tests = self.data.allTests
-      return tests.map(test => yo`<label><input onchange =${(e) => toggleCheckbox(e, test)} type="checkbox" checked="true">${test} </label>`)
+      return tests.map(test => yo`<label><input class="singleTest" onchange =${(e) => toggleCheckbox(e, test)} type="checkbox" checked="true">${test} </label>`)
     }
 
     function toggleCheckbox (e, test) {
       var selectedTests = self.data.selectedTests
       selectedTests = e.target.checked ? [...selectedTests, test] : selectedTests.filter(el => el !== test)
       self.data.selectedTests = selectedTests
+      var selectAll = document.querySelector('[id="checkAllTests"]')
+      if (e.target.checked) {
+        selectAll.checked = true
+      }
+    }
+
+    function checkAll (event) {
+      var all = self.testList.children
+     
+      var checkBoxes = document.querySelectorAll('input.singleTest')
+      var isAnySelected = document.querySelectorAll('input.singleTest:checked').length != 0
+      // checks/unchecks all
+      checkBoxes.forEach (function(checkBox) {
+        checkBox.checked = !isAnySelected
+      })
+      event.target.checked = !isAnySelected
     }
 
     var runTests = function () {
@@ -182,7 +198,15 @@ module.exports = class TestTab {
         <div class="${css.tests}">
           ${self.testList}
           <div class=${css.buttons}>
-            <div class=${css.runButton} onclick=${runTests}>Run Tests</div>
+            <div class=${css.runButton}  onclick=${runTests}>Run Tests</div>
+            <label class="${css.label}" for="checkAllTests">
+              <input id="checkAllTests"
+                type="checkbox"
+                onclick="${function (event) { checkAll(event) }}"
+                checked="true"
+              >
+              Check/Uncheck all
+            </label>
           </div>
           ${testsOutput}
           ${testsSummary}

From 1b3c35788e8b7802fb8cd66a4a719053e3ad6b3e Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Wed, 21 Nov 2018 18:32:23 +0100
Subject: [PATCH 02/10] fixes syntax errors

---
 src/app/staticanalysis/staticAnalysisView.js | 16 +++++++---------
 src/app/tabs/test-tab.js                     | 10 ++++++----
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 8e5abef71a..3af5c3a858 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -139,14 +139,9 @@ staticAnalysisView.prototype.checkAll = function (event) {
   if (!this.view) {
     return
   }
-  var all = this.view.querySelectorAll('[name="staticanalysismodule"]')
-  var isAnySelected = false
-  for (var i = 0; i < all.length; i++) {
-    if (all[i].checked === true) {
-      isAnySelected = true
-      break
-    }
-  }
+  var all = this.view.querySelectorAll('[id="staticanalysismodule]"')
+  var isAnySelected =  this.view.querySelectorAll('[id="staticanalysismodule]":checked').length !== 0;
+  
   for (var j = 0; j < all.length; j++) {
     all[j].checked = !isAnySelected
   }
@@ -154,9 +149,12 @@ staticAnalysisView.prototype.checkAll = function (event) {
 }
 
 staticAnalysisView.prototype.checkModule = function (event) {
-  var selectAll = this.view.querySelector('[id="checkallstaticanalysis" ]')
+  var selectAll = this.view.querySelector('[id="checkallstaticanalysis"]')
+  var selected = this.view.querySelectorAll('[id="staticanalysismodule]":checked')
   if (event.target.checked) {
     selectAll.checked = true
+  } else if (selected.length === 0) {
+    selectAll.checked = false
   }
 }
 
diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index 7aab707694..e8ff527357 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -144,15 +144,17 @@ module.exports = class TestTab {
       if (e.target.checked) {
         selectAll.checked = true
       }
+      if (selectedTests.length === 0) {
+        selectAll.checked = false
+      }
+
     }
 
     function checkAll (event) {
-      var all = self.testList.children
-     
       var checkBoxes = document.querySelectorAll('input.singleTest')
-      var isAnySelected = document.querySelectorAll('input.singleTest:checked').length != 0
+      var isAnySelected = document.querySelectorAll('input.singleTest:checked').length !== 0
       // checks/unchecks all
-      checkBoxes.forEach (function(checkBox) {
+      checkBoxes.forEach(function (checkBox) {
         checkBox.checked = !isAnySelected
       })
       event.target.checked = !isAnySelected

From b5660d263fc56d6b465f84ed4f2a9c18694c2c85 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Sun, 25 Nov 2018 21:42:37 +0100
Subject: [PATCH 03/10] check all for tests

---
 src/app/staticanalysis/staticAnalysisView.js | 39 ++++++++++----------
 src/app/tabs/test-tab.js                     | 29 +++++++--------
 2 files changed, 32 insertions(+), 36 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 3af5c3a858..7c8d9a8fb6 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -50,7 +50,7 @@ staticAnalysisView.prototype.render = function () {
         ${this.modulesView}
       </div>
       <div class="${css.buttons}">
-        <button class=${css.buttonRun} onclick=${function () { self.run() }} >Run</button>
+        <button class="${css.buttonRun}" onclick="${function () { self.run() }}" >Run</button>
         <label class="${css.label}" for="autorunstaticanalysis">
           <input id="autorunstaticanalysis"
             type="checkbox"
@@ -59,8 +59,8 @@ staticAnalysisView.prototype.render = function () {
           >
           Auto run
         </label>
-        <label class="${css.label}" for="checkallstaticanalysis">
-          <input id="checkallstaticanalysis"
+        <label class="${css.label}" for="checkAllTests">
+          <input id="checkAllTests"
             type="checkbox"
             onclick="${function (event) { self.checkAll(event) }}"
             style="vertical-align:bottom"
@@ -135,27 +135,25 @@ staticAnalysisView.prototype.run = function () {
   }
 }
 
-staticAnalysisView.prototype.checkAll = function (event) {
-  if (!this.view) {
-    return
-  }
-  var all = this.view.querySelectorAll('[id="staticanalysismodule]"')
-  var isAnySelected =  this.view.querySelectorAll('[id="staticanalysismodule]":checked').length !== 0;
-  
-  for (var j = 0; j < all.length; j++) {
-    all[j].checked = !isAnySelected
+staticAnalysisView.prototype.checkModule = function (event) {
+  let selected = document.querySelectorAll('[name="staticanalysismodule"]:checked')
+  let checkAll = document.querySelector('[id="checkAllTests"]')
+  if (event.target.checked) {
+    checkAll.checked = true
+  } else if (!selected.length) {
+    checkAll.checked = false
   }
-  event.target.checked = !isAnySelected
 }
 
-staticAnalysisView.prototype.checkModule = function (event) {
-  var selectAll = this.view.querySelector('[id="checkallstaticanalysis"]')
-  var selected = this.view.querySelectorAll('[id="staticanalysismodule]":checked')
-  if (event.target.checked) {
-    selectAll.checked = true
-  } else if (selected.length === 0) {
-    selectAll.checked = false
+staticAnalysisView.prototype.checkAll = function (event) {
+  if (!this.view) {
+    return
   }
+  var checkBoxes = this.view.querySelectorAll('[name="staticanalysismodule"]')
+  var selectionsCount =  this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length;
+  // checks/unchecks all
+  checkBoxes.forEach(checkbox => checkbox.checked = !selectionsCount)
+  event.target.checked = !selectionsCount
 }
 
 staticAnalysisView.prototype.renderModules = function () {
@@ -168,6 +166,7 @@ staticAnalysisView.prototype.renderModules = function () {
         <label class="${css.label}">
           <input id="staticanalysismodule_${categoryId}_${i}"
             type="checkbox"
+            class="staticAnalysisItem"
             name="staticanalysismodule"
             index=${item._index}
             checked="true"
diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index e8ff527357..edf8a524af 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -137,29 +137,26 @@ module.exports = class TestTab {
     }
 
     function toggleCheckbox (e, test) {
-      var selectedTests = self.data.selectedTests
+      let selectedTests = self.data.selectedTests
       selectedTests = e.target.checked ? [...selectedTests, test] : selectedTests.filter(el => el !== test)
       self.data.selectedTests = selectedTests
-      var selectAll = document.querySelector('[id="checkAllTests"]')
+      let checkAll = document.querySelector('[id="checkAllTests"]')
       if (e.target.checked) {
-        selectAll.checked = true
+        checkAll.checked = true
+      } else if (!selectedTests.length) {
+        checkAll.checked = false
       }
-      if (selectedTests.length === 0) {
-        selectAll.checked = false
-      }
-
     }
 
     function checkAll (event) {
-      var checkBoxes = document.querySelectorAll('input.singleTest')
-      var isAnySelected = document.querySelectorAll('input.singleTest:checked').length !== 0
+      const checkBoxes = document.querySelectorAll('.singleTest')
+      const selectionsCount = document.querySelectorAll('.singleTest:checked').length
       // checks/unchecks all
-      checkBoxes.forEach(function (checkBox) {
-        checkBox.checked = !isAnySelected
-      })
-      event.target.checked = !isAnySelected
+      checkBoxes.forEach(checkbox => checkbox.checked = !selectionsCount)
+      event.target.checked = !selectionsCount
     }
 
+
     var runTests = function () {
       testsOutput.innerHTML = ''
       testsSummary.innerHTML = ''
@@ -195,12 +192,12 @@ module.exports = class TestTab {
           <br/>
           For more details, see
           How to test smart contracts guide in our documentation.
-          <div class=${css.generateTestFile} onclick=${generateTestFile}>Generate test file</div>
+          <div class="${css.generateTestFile}" onclick="${generateTestFile}">Generate test file</div>
         </div>
         <div class="${css.tests}">
           ${self.testList}
-          <div class=${css.buttons}>
-            <div class=${css.runButton}  onclick=${runTests}>Run Tests</div>
+          <div class="${css.buttons}">
+            <div class="${css.runButton}"  onclick="${runTests}">Run Tests</div>
             <label class="${css.label}" for="checkAllTests">
               <input id="checkAllTests"
                 type="checkbox"

From eb189dcca4a9b5b5b32943d48f98c60a2bcab6e0 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Sun, 25 Nov 2018 22:01:23 +0100
Subject: [PATCH 04/10] fixes labels to be clickable.

---
 src/app/staticanalysis/staticAnalysisView.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 7c8d9a8fb6..3f3e8bfc2e 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -59,8 +59,8 @@ staticAnalysisView.prototype.render = function () {
           >
           Auto run
         </label>
-        <label class="${css.label}" for="checkAllTests">
-          <input id="checkAllTests"
+        <label class="${css.label}" for="checkAllEntries">
+          <input id="checkAllEntries"
             type="checkbox"
             onclick="${function (event) { self.checkAll(event) }}"
             style="vertical-align:bottom"
@@ -137,7 +137,7 @@ staticAnalysisView.prototype.run = function () {
 
 staticAnalysisView.prototype.checkModule = function (event) {
   let selected = document.querySelectorAll('[name="staticanalysismodule"]:checked')
-  let checkAll = document.querySelector('[id="checkAllTests"]')
+  let checkAll = document.querySelector('[id="checkAllEntries"]')
   if (event.target.checked) {
     checkAll.checked = true
   } else if (!selected.length) {

From 218772ab695af92bc81812f9ae26f4c37c41da29 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 29 Nov 2018 16:16:41 +0100
Subject: [PATCH 05/10] fixes bug in checkall for test tab

---
 src/app/tabs/test-tab.js | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index edf8a524af..a70bfdcc96 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -101,7 +101,7 @@ module.exports = class TestTab {
 
     self._deps.filePanel.event.register('newTestFileCreated', file => {
       var testList = document.querySelector("[class^='testList']")
-      var test = yo`<label><input class="singleTest" onchange=${(e) => toggleCheckbox(e, file)} type="checkbox" checked="true">${file}</label>`
+      var test = yo`<label class="singleTestLabel"><input class="singleTest" onchange=${(e) => toggleCheckbox(e.target.checked, file)} type="checkbox" checked="true">${file}</label>`
       testList.appendChild(test)
       self.data.allTests.push(file)
       self.data.selectedTests.push(file)
@@ -133,15 +133,17 @@ module.exports = class TestTab {
 
     function listTests () {
       var tests = self.data.allTests
-      return tests.map(test => yo`<label><input class="singleTest" onchange =${(e) => toggleCheckbox(e, test)} type="checkbox" checked="true">${test} </label>`)
+      return tests.map(test => yo`<label class="singleTestLabel"><input class="singleTest" onchange =${(e) => toggleCheckbox(e.target.checked, test)} type="checkbox" checked="true">${test} </label>`)
     }
 
-    function toggleCheckbox (e, test) {
+    function toggleCheckbox (eChecked, test) {
+      if (!self.data.selectedTests)
+        self.data.selectedTests = document.querySelectorAll('.singleTest:checked')
       let selectedTests = self.data.selectedTests
-      selectedTests = e.target.checked ? [...selectedTests, test] : selectedTests.filter(el => el !== test)
+      selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => {el !== test})
       self.data.selectedTests = selectedTests
       let checkAll = document.querySelector('[id="checkAllTests"]')
-      if (e.target.checked) {
+      if (eChecked) {
         checkAll.checked = true
       } else if (!selectedTests.length) {
         checkAll.checked = false
@@ -149,14 +151,17 @@ module.exports = class TestTab {
     }
 
     function checkAll (event) {
-      const checkBoxes = document.querySelectorAll('.singleTest')
+      let checkBoxes = document.querySelectorAll('.singleTest')
+      const checkboxesLabels = document.querySelectorAll(".singleTestLabel")
       const selectionsCount = document.querySelectorAll('.singleTest:checked').length
       // checks/unchecks all
-      checkBoxes.forEach(checkbox => checkbox.checked = !selectionsCount)
+      for (let i = 0; i < checkBoxes.length; i++) {
+        checkBoxes[i].checked = !selectionsCount;
+        toggleCheckbox(!selectionsCount, checkboxesLabels[i].innerText)
+      }
       event.target.checked = !selectionsCount
     }
 
-
     var runTests = function () {
       testsOutput.innerHTML = ''
       testsSummary.innerHTML = ''

From 4adce90817f356c4a9c87f72b038beb9f959856e Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 29 Nov 2018 16:33:00 +0100
Subject: [PATCH 06/10] fixes tests

---
 src/app/staticanalysis/staticAnalysisView.js | 4 ++--
 src/app/tabs/test-tab.js                     | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 3f3e8bfc2e..38c464d207 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -150,9 +150,9 @@ staticAnalysisView.prototype.checkAll = function (event) {
     return
   }
   var checkBoxes = this.view.querySelectorAll('[name="staticanalysismodule"]')
-  var selectionsCount =  this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length;
+  var selectionsCount = this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length
   // checks/unchecks all
-  checkBoxes.forEach(checkbox => checkbox.checked = !selectionsCount)
+  checkBoxes.forEach((checkbox) => { checkbox.checked = !selectionsCount })
   event.target.checked = !selectionsCount
 }
 
diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index a70bfdcc96..598ab2d711 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -137,10 +137,11 @@ module.exports = class TestTab {
     }
 
     function toggleCheckbox (eChecked, test) {
-      if (!self.data.selectedTests)
+      if (!self.data.selectedTests) {
         self.data.selectedTests = document.querySelectorAll('.singleTest:checked')
+      }
       let selectedTests = self.data.selectedTests
-      selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => {el !== test})
+      selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => el !== test)
       self.data.selectedTests = selectedTests
       let checkAll = document.querySelector('[id="checkAllTests"]')
       if (eChecked) {
@@ -152,11 +153,11 @@ module.exports = class TestTab {
 
     function checkAll (event) {
       let checkBoxes = document.querySelectorAll('.singleTest')
-      const checkboxesLabels = document.querySelectorAll(".singleTestLabel")
+      const checkboxesLabels = document.querySelectorAll('.singleTestLabel')
       const selectionsCount = document.querySelectorAll('.singleTest:checked').length
       // checks/unchecks all
       for (let i = 0; i < checkBoxes.length; i++) {
-        checkBoxes[i].checked = !selectionsCount;
+        checkBoxes[i].checked = !selectionsCount
         toggleCheckbox(!selectionsCount, checkboxesLabels[i].innerText)
       }
       event.target.checked = !selectionsCount

From 92b68fe77085121a22ab735569c288c3d4da7318 Mon Sep 17 00:00:00 2001
From: Liana Husikyan <liana@ethereum.org>
Date: Mon, 10 Dec 2018 21:32:50 +0100
Subject: [PATCH 07/10] Update staticAnalysisView.js

---
 src/app/staticanalysis/staticAnalysisView.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 38c464d207..70be1cf655 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -149,11 +149,9 @@ staticAnalysisView.prototype.checkAll = function (event) {
   if (!this.view) {
     return
   }
-  var checkBoxes = this.view.querySelectorAll('[name="staticanalysismodule"]')
-  var selectionsCount = this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length
   // checks/unchecks all
-  checkBoxes.forEach((checkbox) => { checkbox.checked = !selectionsCount })
-  event.target.checked = !selectionsCount
+  var checkBoxes = this.view.querySelectorAll('[name="staticanalysismodule"]')
+  checkBoxes.forEach((checkbox) => { checkbox.checked = event.target.checked })
 }
 
 staticAnalysisView.prototype.renderModules = function () {

From ebae4c369a98ca2b5e1b5899f0ca033413ee6b06 Mon Sep 17 00:00:00 2001
From: Liana Husikyan <liana@ethereum.org>
Date: Mon, 10 Dec 2018 21:34:01 +0100
Subject: [PATCH 08/10] Update test-tab.js

---
 src/app/tabs/test-tab.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index 598ab2d711..2a13c6876e 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -154,13 +154,11 @@ module.exports = class TestTab {
     function checkAll (event) {
       let checkBoxes = document.querySelectorAll('.singleTest')
       const checkboxesLabels = document.querySelectorAll('.singleTestLabel')
-      const selectionsCount = document.querySelectorAll('.singleTest:checked').length
       // checks/unchecks all
       for (let i = 0; i < checkBoxes.length; i++) {
-        checkBoxes[i].checked = !selectionsCount
-        toggleCheckbox(!selectionsCount, checkboxesLabels[i].innerText)
+        checkBoxes[i].checked = event.target.checked
+        toggleCheckbox(event.target.checkedt, checkboxesLabels[i].innerText)
       }
-      event.target.checked = !selectionsCount
     }
 
     var runTests = function () {

From e71e41819bf7ccdb2b852c1d4af8cef58d40656f Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 10 Jan 2019 14:37:29 +0100
Subject: [PATCH 09/10] fixed typo

---
 src/app/tabs/test-tab.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index 2a13c6876e..45f890a898 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -157,7 +157,7 @@ module.exports = class TestTab {
       // checks/unchecks all
       for (let i = 0; i < checkBoxes.length; i++) {
         checkBoxes[i].checked = event.target.checked
-        toggleCheckbox(event.target.checkedt, checkboxesLabels[i].innerText)
+        toggleCheckbox(event.target.checked, checkboxesLabels[i].innerText)
       }
     }
 

From a5f4758f43c28239856248e7073948f9bcd0067f Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 10 Jan 2019 15:27:24 +0100
Subject: [PATCH 10/10] changed document.querySelector... to this.view.query...

---
 src/app/staticanalysis/staticAnalysisView.js |  4 ++--
 src/app/tabs/test-tab.js                     | 10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index 70be1cf655..f34ed76173 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -136,8 +136,8 @@ staticAnalysisView.prototype.run = function () {
 }
 
 staticAnalysisView.prototype.checkModule = function (event) {
-  let selected = document.querySelectorAll('[name="staticanalysismodule"]:checked')
-  let checkAll = document.querySelector('[id="checkAllEntries"]')
+  let selected = this.view.querySelectorAll('[name="staticanalysismodule"]:checked')
+  let checkAll = this.view.querySelector('[id="checkAllEntries"]')
   if (event.target.checked) {
     checkAll.checked = true
   } else if (!selected.length) {
diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js
index 45f890a898..db04e7e024 100644
--- a/src/app/tabs/test-tab.js
+++ b/src/app/tabs/test-tab.js
@@ -100,7 +100,7 @@ module.exports = class TestTab {
     }
 
     self._deps.filePanel.event.register('newTestFileCreated', file => {
-      var testList = document.querySelector("[class^='testList']")
+      var testList = self.view.querySelector("[class^='testList']")
       var test = yo`<label class="singleTestLabel"><input class="singleTest" onchange=${(e) => toggleCheckbox(e.target.checked, file)} type="checkbox" checked="true">${file}</label>`
       testList.appendChild(test)
       self.data.allTests.push(file)
@@ -138,12 +138,12 @@ module.exports = class TestTab {
 
     function toggleCheckbox (eChecked, test) {
       if (!self.data.selectedTests) {
-        self.data.selectedTests = document.querySelectorAll('.singleTest:checked')
+        self.data.selectedTests = self._view.el.querySelectorAll('.singleTest:checked')
       }
       let selectedTests = self.data.selectedTests
       selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => el !== test)
       self.data.selectedTests = selectedTests
-      let checkAll = document.querySelector('[id="checkAllTests"]')
+      let checkAll = self._view.el.querySelector('[id="checkAllTests"]')
       if (eChecked) {
         checkAll.checked = true
       } else if (!selectedTests.length) {
@@ -152,8 +152,8 @@ module.exports = class TestTab {
     }
 
     function checkAll (event) {
-      let checkBoxes = document.querySelectorAll('.singleTest')
-      const checkboxesLabels = document.querySelectorAll('.singleTestLabel')
+      let checkBoxes = self._view.el.querySelectorAll('.singleTest')
+      const checkboxesLabels = self._view.el.querySelectorAll('.singleTestLabel')
       // checks/unchecks all
       for (let i = 0; i < checkBoxes.length; i++) {
         checkBoxes[i].checked = event.target.checked