From bd45d397e8e40bb15cdb04564535da68cfbd5eed Mon Sep 17 00:00:00 2001 From: jesush Date: Fri, 21 Sep 2018 03:41:58 -0400 Subject: [PATCH] Fix sendCompilationResults API call --- src/app/plugin/pluginAPI.js | 4 ++-- src/app/plugin/pluginManager.js | 6 +++--- src/app/tabs/run-tab.js | 5 +++-- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/app/plugin/pluginAPI.js b/src/app/plugin/pluginAPI.js index 591d08410f..e83b6c618b 100644 --- a/src/app/plugin/pluginAPI.js +++ b/src/app/plugin/pluginAPI.js @@ -45,8 +45,8 @@ module.exports = (pluginManager, fileProviders, fileManager, compiler, udapp) => getCompilationResult: (mod, cb) => { cb(null, compiler.lastCompilationResult) }, - sendCompilationResult: (mod, file, languageVersion, data, cb) => { - pluginManager.receivedDataFrom('sendCompilationResult', mod, file, languageVersion, data) + sendCompilationResult: (mod, file, source, languageVersion, data, cb) => { + pluginManager.receivedDataFrom('sendCompilationResult', mod, [file, source, languageVersion, data]) } }, udapp: { diff --git a/src/app/plugin/pluginManager.js b/src/app/plugin/pluginManager.js index 808da385d8..b6f55e50ca 100644 --- a/src/app/plugin/pluginManager.js +++ b/src/app/plugin/pluginManager.js @@ -195,10 +195,10 @@ module.exports = class PluginManager { this.post(this.origins[origin], value) } } - receivedDataFrom (methodName, mod) { + receivedDataFrom (methodName, mod, argumentsArray) { // TODO check whether 'mod' as right to do that - arguments.shift() - this.event.trigger(methodName, [arguments]) + console.log(argumentsArray) + this.event.trigger(methodName, argumentsArray) } post (name, value) { const self = this diff --git a/src/app/tabs/run-tab.js b/src/app/tabs/run-tab.js index afa6f87b2d..ff56e2dfd4 100644 --- a/src/app/tabs/run-tab.js +++ b/src/app/tabs/run-tab.js @@ -306,9 +306,10 @@ function contractDropdown (events, self) { } } - self._deps.pluginManager.event.register('sendCompilationResult', (mod, file, source, languageVersion, data) => { + self._deps.pluginManager.event.register('sendCompilationResult', (file, source, languageVersion, data) => { // TODO check whether the tab is configured - newlyCompiled(true, data, source) + self._deps.compiler.ldCompilationResult(file, source, languageVersion, data) + newlyCompiled(true) }) self._deps.compiler.event.register('compilationFinished', newlyCompiled)