From c1f6b6fba66847c7b335d173ef04236157be38b7 Mon Sep 17 00:00:00 2001
From: ioedeveloper <daviddisu8@gmail.com>
Date: Tue, 17 Aug 2021 13:03:55 +0100
Subject: [PATCH] Fixed failing pluginManager test

---
 apps/remix-ide-e2e/src/tests/pluginManager.spec.ts  | 13 ++++++++++---
 .../modal-dialog/src/lib/remix-ui-modal-dialog.tsx  |  6 +++++-
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/apps/remix-ide-e2e/src/tests/pluginManager.spec.ts b/apps/remix-ide-e2e/src/tests/pluginManager.spec.ts
index 85d0b31aca..5ced71ee7a 100644
--- a/apps/remix-ide-e2e/src/tests/pluginManager.spec.ts
+++ b/apps/remix-ide-e2e/src/tests/pluginManager.spec.ts
@@ -2,6 +2,10 @@
 import { NightwatchBrowser } from 'nightwatch'
 import init from '../helpers/init'
 
+declare global {
+  interface Window { testmode: boolean; }
+}
+
 const testData = {
   pluginName: 'remixIde',
   pluginDisplayName: 'Remix IDE',
@@ -105,13 +109,16 @@ module.exports = {
 
   'Should connect a local plugin': function (browser: NightwatchBrowser) {
     browser.waitForElementVisible('*[data-id="pluginManagerComponentPluginManager"]')
+      .execute(function () {
+        window.testmode = true
+      })
       .click('*[data-id="pluginManagerComponentPluginSearchButton"]')
       .waitForElementVisible('*[data-id="pluginManagerLocalPluginModalDialogModalDialogContainer-react"]')
       .click('*[data-id="pluginManagerLocalPluginModalDialogModalDialogModalBody-react"]')
       .waitForElementVisible('*[data-id="localPluginName"]')
-      .setValue('*[data-id="localPluginName"]', testData.pluginName)
-      .setValue('*[data-id="localPluginDisplayName"]', testData.pluginDisplayName)
-      .setValue('*[data-id="localPluginUrl"]', testData.pluginUrl)
+      .clearValue('*[data-id="localPluginName"]').setValue('*[data-id="localPluginName"]', testData.pluginName)
+      .clearValue('*[data-id="localPluginDisplayName"]').setValue('*[data-id="localPluginDisplayName"]', testData.pluginDisplayName)
+      .clearValue('*[data-id="localPluginUrl"]').setValue('*[data-id="localPluginUrl"]', testData.pluginUrl)
       .click('*[data-id="localPluginRadioButtoniframe"]')
       .click('*[data-id="localPluginRadioButtonsidePanel"]')
       .click('*[data-id="pluginManagerLocalPluginModalDialogModalDialogModalFooter-react"]')
diff --git a/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx b/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx
index 6a764a85e2..2e43962fb3 100644
--- a/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx
+++ b/libs/remix-ui/modal-dialog/src/lib/remix-ui-modal-dialog.tsx
@@ -3,6 +3,10 @@ import { ModalDialogProps } from './types' // eslint-disable-line
 
 import './remix-ui-modal-dialog.css'
 
+declare global {
+  interface Window { testmode: boolean; }
+}
+
 export const ModalDialog = (props: ModalDialogProps) => {
   const [state, setState] = useState({
     toggleBtn: true
@@ -21,7 +25,7 @@ export const ModalDialog = (props: ModalDialogProps) => {
       if (!e.currentTarget.contains(e.relatedTarget)) {
         e.stopPropagation()
         if (document.activeElement !== this) {
-          handleHide()
+          !window.testmode && handleHide()
         }
       }
     }