From c974638a6b706e95029dc78c5700c1b8fd8fdb9c Mon Sep 17 00:00:00 2001 From: filip mertens Date: Fri, 30 Dec 2022 09:40:47 +0100 Subject: [PATCH] fix filename error --- libs/remix-ui/editor/src/lib/providers/definitionProvider.ts | 3 +++ libs/remix-ui/editor/src/lib/providers/referenceProvider.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libs/remix-ui/editor/src/lib/providers/definitionProvider.ts b/libs/remix-ui/editor/src/lib/providers/definitionProvider.ts index 9d6daee730..25edeb3459 100644 --- a/libs/remix-ui/editor/src/lib/providers/definitionProvider.ts +++ b/libs/remix-ui/editor/src/lib/providers/definitionProvider.ts @@ -29,6 +29,9 @@ export class RemixDefinitionProvider implements monaco.languages.DefinitionProvi } } } + if (!jumpLocation || !jumpLocation.fileName) { + return [] + } return [{ uri: this.monaco.Uri.parse(jumpLocation.fileName), range: { diff --git a/libs/remix-ui/editor/src/lib/providers/referenceProvider.ts b/libs/remix-ui/editor/src/lib/providers/referenceProvider.ts index 36380c54a0..410dbe588d 100644 --- a/libs/remix-ui/editor/src/lib/providers/referenceProvider.ts +++ b/libs/remix-ui/editor/src/lib/providers/referenceProvider.ts @@ -28,7 +28,7 @@ export class RemixReferenceProvider implements monaco.languages.ReferenceProvide fileTarget = fileTarget.file const fileContent = await this.props.plugin.call('fileManager', 'readFile', fileInNode) const lineColumn = await this.props.plugin.call('codeParser', 'getLineColumnOfPosition', position) - console.log(position, fileTarget, lineColumn) + try { this.props.plugin.call('editor', 'addModel', fileTarget, fileContent) } catch (e) {