From 02c0dd29e5d7bab4c8a29f379e3593235de0009e Mon Sep 17 00:00:00 2001 From: filip mertens Date: Thu, 5 May 2022 08:33:32 +0200 Subject: [PATCH 1/3] turn on flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/specialFunctions.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 11c6ede82b..cc732d6931 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.2.3 jobs: diff --git a/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts b/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts index bcdc3c4977..0271b0cdd8 100644 --- a/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts +++ b/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts @@ -165,7 +165,7 @@ module.exports = { }) }) }, - 'Use special functions receive/fallback - receive and fallback are declared, sending data and wei #group6': function (browser: NightwatchBrowser) { + 'Use special functions receive/fallback - receive and fallback are declared, sending data and wei #group6 #flaky': function (browser: NightwatchBrowser) { browser.waitForElementVisible('#icon-panel', 10000) .testContracts('receiveAndFallbackBothPayable.sol', sources[4]['receiveAndFallbackBothPayable.sol'], ['CheckSpecials']) .clickLaunchIcon('udapp') From 76d6a6ab10f8c98279f63a8fad820db6c9791fb0 Mon Sep 17 00:00:00 2001 From: filip mertens Date: Thu, 5 May 2022 08:35:24 +0200 Subject: [PATCH 2/3] Revert "turn on flaky" This reverts commit 02c0dd29e5d7bab4c8a29f379e3593235de0009e. --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/specialFunctions.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index cc732d6931..11c6ede82b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.2.3 jobs: diff --git a/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts b/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts index 0271b0cdd8..bcdc3c4977 100644 --- a/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts +++ b/apps/remix-ide-e2e/src/tests/specialFunctions.test.ts @@ -165,7 +165,7 @@ module.exports = { }) }) }, - 'Use special functions receive/fallback - receive and fallback are declared, sending data and wei #group6 #flaky': function (browser: NightwatchBrowser) { + 'Use special functions receive/fallback - receive and fallback are declared, sending data and wei #group6': function (browser: NightwatchBrowser) { browser.waitForElementVisible('#icon-panel', 10000) .testContracts('receiveAndFallbackBothPayable.sol', sources[4]['receiveAndFallbackBothPayable.sol'], ['CheckSpecials']) .clickLaunchIcon('udapp') From bd8a0f48fbbbaef1ac9e9aec6d6ce7b505243204 Mon Sep 17 00:00:00 2001 From: filip mertens Date: Thu, 5 May 2022 11:22:11 +0200 Subject: [PATCH 3/3] no logs in ff --- apps/remix-ide-e2e/src/commands/getBrowserLogs.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/apps/remix-ide-e2e/src/commands/getBrowserLogs.ts b/apps/remix-ide-e2e/src/commands/getBrowserLogs.ts index d2e07cb7a4..d1da53488a 100644 --- a/apps/remix-ide-e2e/src/commands/getBrowserLogs.ts +++ b/apps/remix-ide-e2e/src/commands/getBrowserLogs.ts @@ -4,10 +4,12 @@ import EventEmitter from 'events' class GetBrowserLogs extends EventEmitter { command(this: NightwatchBrowser): NightwatchBrowser { this.api.getLog('browser', function (logs) { - logs.forEach(function (log) { - console.log(log) + if (logs && Array.isArray(logs)) { + logs.forEach(function (log) { + console.log(log) + } + ) } - ) }).perform(() => { this.emit('complete') })