From bee8df3b7f1fc24a173b185b54db0d6db0b0fb14 Mon Sep 17 00:00:00 2001 From: yann300 Date: Wed, 29 Sep 2021 09:39:43 +0200 Subject: [PATCH 1/6] refactor and fix remix-debug tests --- libs/remix-debug/package.json | 1 + libs/remix-debug/test/debugger.ts | 25 +++--- libs/remix-debug/test/decoder/localDecoder.ts | 19 ++--- .../test/decoder/localsTests/calldata.ts | 21 +++-- .../test/decoder/localsTests/int.ts | 16 ++-- .../test/decoder/localsTests/misc.ts | 16 ++-- .../test/decoder/localsTests/misc2.ts | 14 ++-- .../test/decoder/localsTests/structArray.ts | 14 ++-- .../test/decoder/stateTests/mapping.ts | 39 +++++---- libs/remix-debug/test/decoder/vmCall.ts | 76 ----------------- libs/remix-debug/test/tests.ts | 2 +- libs/remix-debug/test/vmCall.ts | 83 ++++++++----------- .../src/web3Provider/web3VmProvider.ts | 5 ++ libs/remix-simulator/src/vm-context.ts | 62 +++++++------- 14 files changed, 157 insertions(+), 236 deletions(-) delete mode 100644 libs/remix-debug/test/decoder/vmCall.ts diff --git a/libs/remix-debug/package.json b/libs/remix-debug/package.json index 3659c0d4ae..5be0192f86 100644 --- a/libs/remix-debug/package.json +++ b/libs/remix-debug/package.json @@ -24,6 +24,7 @@ "@ethereumjs/vm": "^5.5.0", "@remix-project/remix-astwalker": "^0.0.37", "@remix-project/remix-lib": "^0.5.7", + "@remix-project/remix-simulator": "^0.2.7", "async": "^2.6.2", "commander": "^2.19.0", "deep-equal": "^1.0.1", diff --git a/libs/remix-debug/test/debugger.ts b/libs/remix-debug/test/debugger.ts index ff859f7d4d..e98f24d839 100644 --- a/libs/remix-debug/test/debugger.ts +++ b/libs/remix-debug/test/debugger.ts @@ -7,7 +7,6 @@ import { BreakpointManager } from '../src/code/breakpointManager' var compiler = require('solc') var vmCall = require('./vmCall') -var remixLib = require('@remix-project/remix-lib') var ballot = `pragma solidity >=0.4.22 <0.8.0; @@ -151,19 +150,17 @@ contract Ballot { `; (async () => { - var privateKey = Buffer.from('dae9801649ba2d95a21e688b56f77905e5667c44ce868ec83f82e838712a2c7a', 'hex') - var vm = await vmCall.initVM(privateKey) + var privateKey = Buffer.from('503f38a9c967ed597e47fe25643985f032b072db8075426a92110f82df48dfcb', 'hex') var output = compiler.compile(compilerInput(ballot)) output = JSON.parse(output) - var web3VM = new remixLib.vm.Web3VMProvider() - web3VM.setVM(vm) const param = '0000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000000148656c6c6f20576f726c64210000000000000000000000000000000000000000' - vmCall.sendTx(vm, {nonce: 0, privateKey: privateKey}, null, 0, output.contracts['test.sol']['Ballot'].evm.bytecode.object + param, (error, txHash) => { - console.log(error, txHash) + const web3 = await vmCall.getWeb3() + vmCall.sendTx(web3, {nonce: 0, privateKey: privateKey}, null, 0, output.contracts['test.sol']['Ballot'].evm.bytecode.object + param, (error, hash) => { + console.log(error, hash) if (error) { throw error } else { - web3VM.eth.getTransaction(txHash, (error, tx) => { + web3.eth.getTransaction(hash, (error, tx) => { if (error) { throw error } else { @@ -171,7 +168,7 @@ contract Ballot { compilationResult: function () { return { data: output } }, - web3: web3VM + web3: web3 }) debugManager.callTree.event.register('callTreeReady', () => { @@ -230,7 +227,7 @@ function testDebugging (debugManager) { var storageView = debugManager.storageViewAt(196, address) storageView.storageRange().then((storage) => { - t.equal(JSON.stringify(storage), JSON.stringify({ '0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563': { key: '0x0000000000000000000000000000000000000000000000000000000000000000', value: '0x0000000000000000000000004b0897b0513fdc7c541b6d9d7e929c4e5364d2db' } })) + t.equal(JSON.stringify(storage), JSON.stringify({ '0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563': { key: '0x0000000000000000000000000000000000000000000000000000000000000000', value: '0x0000000000000000000000005b38da6a701c568545dcfcb03fcb875f56beddc4' } })) }).catch((error) => { if (error) return t.end(error) }) @@ -245,7 +242,7 @@ function testDebugging (debugManager) { const state = await debugManager.extractStateAt(312) const decodedState = await debugManager.decodeStateAt(312, state) console.log(decodedState) - t.equal(decodedState['chairperson'].value, '0x4B0897B0513FDC7C541B6D9D7E929C4E5364D2DB') + t.equal(decodedState['chairperson'].value, '0x5B38DA6A701C568545DCFCB03FCB875F56BEDDC4') t.equal(decodedState['chairperson'].type, 'address') t.equal(decodedState['proposals'].value[0].value.voteCount.value, '0') t.equal(decodedState['proposals'].value[0].value.voteCount.type, 'uint256') @@ -259,13 +256,15 @@ function testDebugging (debugManager) { tape('traceManager.decodeLocalsAt', async (t) => { t.plan(1) - const tested = JSON.parse('{"proposalNames":{"value":[{"value":"0x48656C6C6F20576F726C64210000000000000000000000000000000000000000","type":"bytes32"}],"length":"0x1","type":"bytes32[]","cursor":1,"hasNext":false},"p":{"value":"45","type":"uint256"},"addressLocal":{"value":"0x4B0897B0513FDC7C541B6D9D7E929C4E5364D2DB","type":"address"},"i":{"value":"2","type":"uint256"},"proposalsLocals":{"value":[{"value":{"name":{"value":"0x48656C6C6F20576F726C64210000000000000000000000000000000000000000","type":"bytes32"},"voteCount":{"value":"0","type":"uint256"}},"type":"struct Ballot.Proposal"}],"length":"0x1","type":"struct Ballot.Proposal[]"}}') + const tested = JSON.parse('{"proposalNames":{"value":[{"value":"0x48656C6C6F20576F726C64210000000000000000000000000000000000000000","type":"bytes32"}],"length":"0x1","type":"bytes32[]","cursor":1,"hasNext":false},"p":{"value":"45","type":"uint256"},"addressLocal":{"value":"0x5B38DA6A701C568545DCFCB03FCB875F56BEDDC4","type":"address"},"i":{"value":"2","type":"uint256"},"proposalsLocals":{"value":[{"value":{"name":{"value":"0x48656C6C6F20576F726C64210000000000000000000000000000000000000000","type":"bytes32"},"voteCount":{"value":"0","type":"uint256"}},"type":"struct Ballot.Proposal"}],"length":"0x1","type":"struct Ballot.Proposal[]"}}') try { const address = debugManager.traceManager.getCurrentCalledAddressAt(327) const location = await debugManager.sourceLocationFromVMTraceIndex(address, 327) debugManager.decodeLocalsAt(327, location, (error, decodedlocals) => { if (error) return t.end(error) - t.ok(deepequal(decodedlocals, tested), `locals does not match. expected: ${JSON.stringify(tested)} - current: ${decodedlocals}`) + const res = deepequal(decodedlocals, tested) + console.log(res) + t.ok(res, `test if locals does match. expected: ${JSON.stringify(tested)} - current: ${JSON.stringify(decodedlocals)}`) }) } catch (error) { return t.end(error) diff --git a/libs/remix-debug/test/decoder/localDecoder.ts b/libs/remix-debug/test/decoder/localDecoder.ts index 2a8f4f8997..fc79752e08 100644 --- a/libs/remix-debug/test/decoder/localDecoder.ts +++ b/libs/remix-debug/test/decoder/localDecoder.ts @@ -5,7 +5,7 @@ var intLocal = require('./contracts/intLocal') var miscLocal = require('./contracts/miscLocal') var structArrayLocal = require('./contracts/structArrayLocal') var calldataLocal = require('./contracts/calldata') -var vmCall = require('./vmCall') +var vmCall = require('../vmCall') var intLocalTest = require('./localsTests/int') var miscLocalTest = require('./localsTests/misc') var misc2LocalTest = require('./localsTests/misc2') @@ -15,29 +15,28 @@ var compilerInput = require('../helpers/compilerHelper').compilerInput tape('solidity', function (t) { t.test('local decoder', async function (st) { - var privateKey = Buffer.from('dae9801649ba2d95a21e688b56f77905e5667c44ce868ec83f82e838712a2c7a', 'hex') - var vm = await vmCall.initVM(st, privateKey) - await test(st, vm, privateKey) + var privateKey = Buffer.from('503f38a9c967ed597e47fe25643985f032b072db8075426a92110f82df48dfcb', 'hex') + await test(st, privateKey) }) }) -async function test (st, vm, privateKey) { +async function test (st, privateKey) { var output = compiler.compile(compilerInput(intLocal.contract)) output = JSON.parse(output) - await intLocalTest(st, vm, privateKey, output.contracts['test.sol']['intLocal'].evm.bytecode.object, output) + await intLocalTest(st, privateKey, output.contracts['test.sol']['intLocal'].evm.bytecode.object, output) output = compiler.compile(compilerInput(miscLocal.contract)) output = JSON.parse(output) - await miscLocalTest(st, vm, privateKey, output.contracts['test.sol']['miscLocal'].evm.bytecode.object, output) + await miscLocalTest(st, privateKey, output.contracts['test.sol']['miscLocal'].evm.bytecode.object, output) output = compiler.compile(compilerInput(miscLocal.contract)) output = JSON.parse(output) - await misc2LocalTest(st, vm, privateKey, output.contracts['test.sol']['miscLocal2'].evm.bytecode.object, output) + await misc2LocalTest(st, privateKey, output.contracts['test.sol']['miscLocal2'].evm.bytecode.object, output) output = compiler.compile(compilerInput(structArrayLocal.contract)) output = JSON.parse(output) - await structArrayLocalTest(st, vm, privateKey, output.contracts['test.sol']['structArrayLocal'].evm.bytecode.object, output) + await structArrayLocalTest(st, privateKey, output.contracts['test.sol']['structArrayLocal'].evm.bytecode.object, output) output = compiler.compile(compilerInput(calldataLocal.contract)) output = JSON.parse(output) - await calldataLocalTest(st, vm, privateKey, output.contracts['test.sol']['calldataLocal'].evm.bytecode.object, output) + await calldataLocalTest(st, privateKey, output.contracts['test.sol']['calldataLocal'].evm.bytecode.object, output) st.end() } diff --git a/libs/remix-debug/test/decoder/localsTests/calldata.ts b/libs/remix-debug/test/decoder/localsTests/calldata.ts index 8f7d3b5fa8..2cab6ced8d 100644 --- a/libs/remix-debug/test/decoder/localsTests/calldata.ts +++ b/libs/remix-debug/test/decoder/localsTests/calldata.ts @@ -1,7 +1,7 @@ 'use strict' import deepequal from 'deep-equal' -import { sendTx } from '../vmCall' +import * as vmCall from '../../vmCall' import { TraceManager } from '../../../src/trace/traceManager' import { CodeManager } from '../../../src/code/codeManager' import { SolidityProxy } from '../../../src/solidity-decoder/solidityProxy' @@ -9,23 +9,26 @@ import { InternalCallTree } from '../../../src/solidity-decoder/internalCallTree import { EventManager } from '../../../src/eventManager' import * as helper from './helper' -module.exports = async function (st, vm, privateKey, contractBytecode, compilationResult) { +module.exports = async function (st, privateKey, contractBytecode, compilationResult) { let txHash + let web3 try { - let data = await sendTx(vm, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode) - const to = (data as any).result.createdAddress.toString() + web3 = await (vmCall as any).getWeb3() + let hash = await (vmCall as any).sendTx(web3, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode) + const receipt = await web3.eth.getTransactionReceipt(hash) + const to = receipt.contractAddress + console.log('to', to) // call to level11 - data = await sendTx(vm, { nonce: 1, privateKey: privateKey }, to, 0, 'a372a595000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000001520000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000015400000000000000000000000000000000000000000000000000000000000000') - txHash = (data as any).hash + txHash = await (vmCall as any).sendTx(web3, { nonce: 1, privateKey: privateKey }, to, 0, 'a372a595000000000000000000000000000000000000000000000000000000000000000300000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000001520000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000015400000000000000000000000000000000000000000000000000000000000000') } catch (e) { return st.fail(e) } - return new Promise((resolve) => { - vm.web3.eth.getTransaction(txHash, function (error, tx) { + return new Promise((resolve) => { + web3.eth.getTransaction(txHash, function (error, tx) { if (error) { return st.fail(error) } - var traceManager = new TraceManager({ web3: vm.web3 }) + var traceManager = new TraceManager({ web3 }) var codeManager = new CodeManager(traceManager) codeManager.clear() var solidityProxy = new SolidityProxy({ getCurrentCalledAddressAt: traceManager.getCurrentCalledAddressAt.bind(traceManager), getCode: codeManager.getCode.bind(codeManager) }) diff --git a/libs/remix-debug/test/decoder/localsTests/int.ts b/libs/remix-debug/test/decoder/localsTests/int.ts index b8e0200ff5..9bf1c4307f 100644 --- a/libs/remix-debug/test/decoder/localsTests/int.ts +++ b/libs/remix-debug/test/decoder/localsTests/int.ts @@ -1,6 +1,6 @@ 'use strict' -import { sendTx } from '../vmCall' +import * as vmCall from '../../vmCall' import { TraceManager } from '../../../src/trace/traceManager' import { CodeManager } from '../../../src/code/codeManager' import { contractCreationToken } from '../../../src/trace/traceHelper' @@ -9,19 +9,19 @@ import { InternalCallTree } from '../../../src/solidity-decoder/internalCallTree import { EventManager } from '../../../src/eventManager' import * as helper from './helper' -module.exports = function (st, vm, privateKey, contractBytecode, compilationResult) { - return new Promise((resolve) => { - sendTx(vm, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, data) { +module.exports = function (st, privateKey, contractBytecode, compilationResult) { + return new Promise(async (resolve) => { + let web3 = await (vmCall as any).getWeb3(); + (vmCall as any).sendTx(web3, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, hash) { if (error) { return st.fail(error) } - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, function (error, tx) { + web3.eth.getTransaction(hash, function (error, tx) { if (error) { return st.fail(error) } tx.to = contractCreationToken('0') - var traceManager = new TraceManager({ web3: vm.web3 }) + var traceManager = new TraceManager({ web3 }) var codeManager = new CodeManager(traceManager) codeManager.clear() var solidityProxy = new SolidityProxy({ getCurrentCalledAddressAt: traceManager.getCurrentCalledAddressAt.bind(traceManager), getCode: codeManager.getCode.bind(codeManager) }) @@ -125,6 +125,6 @@ module.exports = function (st, vm, privateKey, contractBytecode, compilationResu }) }) }) - }) + }) } diff --git a/libs/remix-debug/test/decoder/localsTests/misc.ts b/libs/remix-debug/test/decoder/localsTests/misc.ts index 7d59d2fbe7..6caaa01311 100644 --- a/libs/remix-debug/test/decoder/localsTests/misc.ts +++ b/libs/remix-debug/test/decoder/localsTests/misc.ts @@ -1,5 +1,5 @@ 'use strict' -import { sendTx } from '../vmCall' +import * as vmCall from '../../vmCall' import { contractCreationToken } from '../../../src/trace/traceHelper' import { SolidityProxy } from '../../../src/solidity-decoder/solidityProxy' import { InternalCallTree } from '../../../src/solidity-decoder/internalCallTree' @@ -8,19 +8,19 @@ import * as helper from './helper' import { TraceManager } from '../../../src/trace/traceManager' import { CodeManager } from '../../../src/code/codeManager' -module.exports = function (st, vm, privateKey, contractBytecode, compilationResult) { - return new Promise((resolve) => { - sendTx(vm, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, data) { +module.exports = function (st, privateKey, contractBytecode, compilationResult) { + return new Promise(async (resolve) => { + const web3 = await (vmCall as any).getWeb3(); + (vmCall as any).sendTx(web3, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, hash) { if (error) { return st.fail(error) } - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, function (error, tx) { + web3.eth.getTransaction(hash, function (error, tx) { if (error) { return st.fail(error) } tx.to = contractCreationToken('0') - var traceManager = new TraceManager({ web3: vm.web3 }) + var traceManager = new TraceManager({ web3 }) var codeManager = new CodeManager(traceManager) codeManager.clear() var solidityProxy = new SolidityProxy({ getCurrentCalledAddressAt: traceManager.getCurrentCalledAddressAt.bind(traceManager), getCode: codeManager.getCode.bind(codeManager) }) @@ -36,7 +36,7 @@ module.exports = function (st, vm, privateKey, contractBytecode, compilationResu st.equals(locals['boolFalse'].value, false) st.equals(locals['boolTrue'].value, true) st.equals(locals['testEnum'].value, 'three') - st.equals(locals['sender'].value, '0x4B0897B0513FDC7C541B6D9D7E929C4E5364D2DB') + st.equals(locals['sender'].value, '0x5B38DA6A701C568545DCFCB03FCB875F56BEDDC4') st.equals(locals['_bytes1'].value, '0x99') st.equals(locals['__bytes1'].value, '0x99') st.equals(locals['__bytes2'].value, '0x99AB') diff --git a/libs/remix-debug/test/decoder/localsTests/misc2.ts b/libs/remix-debug/test/decoder/localsTests/misc2.ts index f28e0a2cde..813db7542a 100644 --- a/libs/remix-debug/test/decoder/localsTests/misc2.ts +++ b/libs/remix-debug/test/decoder/localsTests/misc2.ts @@ -1,5 +1,5 @@ 'use strict' -import { sendTx } from '../vmCall' +import * as vmCall from '../../vmCall' import { contractCreationToken } from '../../../src/trace/traceHelper' import { SolidityProxy } from '../../../src/solidity-decoder/solidityProxy' import { InternalCallTree } from '../../../src/solidity-decoder/internalCallTree' @@ -8,19 +8,19 @@ import * as helper from './helper' import { TraceManager } from '../../../src/trace/traceManager' import { CodeManager } from '../../../src/code/codeManager' -module.exports = function (st, vm, privateKey, contractBytecode, compilationResult) { - return new Promise((resolve) => { - sendTx(vm, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, data) { +module.exports = function (st, privateKey, contractBytecode, compilationResult) { + return new Promise(async (resolve) => { + const web3 = await (vmCall as any).getWeb3(); + (vmCall as any).sendTx(web3, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, hash) { if (error) { return st.fail(error) } - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, function (error, tx) { + web3.eth.getTransaction(hash, function (error, tx) { if (error) { return st.fail(error) } tx.to = contractCreationToken('0') - var traceManager = new TraceManager({ web3: vm.web3 }) + var traceManager = new TraceManager({ web3 }) var codeManager = new CodeManager(traceManager) codeManager.clear() var solidityProxy = new SolidityProxy({ getCurrentCalledAddressAt: traceManager.getCurrentCalledAddressAt.bind(traceManager), getCode: codeManager.getCode.bind(codeManager) }) diff --git a/libs/remix-debug/test/decoder/localsTests/structArray.ts b/libs/remix-debug/test/decoder/localsTests/structArray.ts index 9041e9ea7b..725674ee8c 100644 --- a/libs/remix-debug/test/decoder/localsTests/structArray.ts +++ b/libs/remix-debug/test/decoder/localsTests/structArray.ts @@ -1,5 +1,5 @@ 'use strict' -import { sendTx } from '../vmCall' +import * as vmCall from '../../vmCall' import { contractCreationToken } from '../../../src/trace/traceHelper' import { SolidityProxy } from '../../../src/solidity-decoder/solidityProxy' import { InternalCallTree } from '../../../src/solidity-decoder/internalCallTree' @@ -8,19 +8,19 @@ import * as helper from './helper' import { TraceManager } from '../../../src/trace/traceManager' import { CodeManager } from '../../../src/code/codeManager' -module.exports = function (st, vm, privateKey, contractBytecode, compilationResult) { - return new Promise((resolve) => { - sendTx(vm, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, data) { +module.exports = function (st, privateKey, contractBytecode, compilationResult) { + return new Promise(async (resolve) => { + const web3 = await (vmCall as any).getWeb3(); + (vmCall as any).sendTx(web3, { nonce: 0, privateKey: privateKey }, null, 0, contractBytecode, function (error, hash) { if (error) { return st.fail(error) } - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, function (error, tx) { + web3.eth.getTransaction(hash, function (error, tx) { if (error) { return st.fail(error) } tx.to = contractCreationToken('0') - var traceManager = new TraceManager({ web3: vm.web3 }) + var traceManager = new TraceManager({ web3 }) var codeManager = new CodeManager(traceManager) codeManager.clear() var solidityProxy = new SolidityProxy({ getCurrentCalledAddressAt: traceManager.getCurrentCalledAddressAt.bind(traceManager), getCode: codeManager.getCode.bind(codeManager) }) diff --git a/libs/remix-debug/test/decoder/stateTests/mapping.ts b/libs/remix-debug/test/decoder/stateTests/mapping.ts index 671bf4b9b6..9f82c7b495 100644 --- a/libs/remix-debug/test/decoder/stateTests/mapping.ts +++ b/libs/remix-debug/test/decoder/stateTests/mapping.ts @@ -2,57 +2,62 @@ import { compilerInput } from '../../helpers/compilerHelper' import { TraceManager } from '../../../src/trace/traceManager' import { compile } from 'solc' import * as stateDecoder from '../../../src/solidity-decoder/stateDecoder' -import { sendTx, initVM } from '../vmCall' +import * as vmCall from '../../vmCall' import { StorageResolver } from '../../../src/storage/storageResolver' import { StorageViewer } from '../../../src/storage/storageViewer' +import { Address, bufferToHex } from 'ethereumjs-util' module.exports = async function testMappingStorage (st, cb) { + console.log('start testMappingStorage') var mappingStorage = require('../contracts/mappingStorage') - var privateKey = Buffer.from('dae9801649ba2d95a21e688b56f77905e5667c44ce868ec83f82e838712a2c7a', 'hex') - var vm = await initVM(st, privateKey) + var privateKey = Buffer.from('503f38a9c967ed597e47fe25643985f032b072db8075426a92110f82df48dfcb', 'hex') var output = compile(compilerInput(mappingStorage.contract)) - output = JSON.parse(output) - sendTx(vm, {nonce: 0, privateKey: privateKey}, null, 0, output.contracts['test.sol']['SimpleMappingState'].evm.bytecode.object, function (error, data) { + output = JSON.parse(output); + console.log('BYTECODE', output.contracts['test.sol']['SimpleMappingState'].evm.bytecode.object); + const web3 = await (vmCall as any).getWeb3(); + (vmCall as any).sendTx(web3, {nonce: 0, privateKey: privateKey}, null, 0, output.contracts['test.sol']['SimpleMappingState'].evm.bytecode.object, function (error, hash) { if (error) { console.log(error) st.end(error) } else { - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, (error, tx) => { + web3.eth.getTransactionReceipt(hash, (error, tx) => { if (error) { console.log(error) st.end(error) } else { - testMapping(st, vm, privateKey, tx.contractAddress, output, cb) + // const storage = await this.vm.stateManager.dumpStorage(data.to) + console.log(tx); + // (vmCall as any).web3().eth.getCode(tx.contractAddress).then((code) => console.log('code:', code)) + // (vmCall as any).web3().debug.traceTransaction(hash).then((code) => console.log('trace:', code)) + testMapping(st, privateKey, tx.contractAddress, output, web3, cb) + // st.end() } }) } }) } -function testMapping (st, vm, privateKey, contractAddress, output, cb) { - sendTx(vm, {nonce: 1, privateKey: privateKey}, contractAddress, 0, '2fd0a83a00000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000001074686973206973206120737472696e6700000000000000000000000000000000', - function (error, data) { +function testMapping (st, privateKey, contractAddress, output, web3, cb) { + (vmCall as any).sendTx(web3, {nonce: 1, privateKey: privateKey}, contractAddress, 0, '2fd0a83a00000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000001074686973206973206120737472696e6700000000000000000000000000000000', + function (error, hash) { if (error) { console.log(error) st.end(error) - } else { - const txHash = data.hash - vm.web3.eth.getTransaction(txHash, (error, tx) => { + } else { + web3.eth.getTransaction(hash, (error, tx) => { if (error) { console.log(error) st.end(error) } else { - var traceManager = new TraceManager({web3: vm.web3}) + var traceManager = new TraceManager({web3}) traceManager.resolveTrace(tx).then(() => { var storageViewer = new StorageViewer({ stepIndex: 268, tx: tx, address: contractAddress - }, new StorageResolver({web3: vm.web3}), traceManager) + }, new StorageResolver({web3}), traceManager) var stateVars = stateDecoder.extractStateVariables('SimpleMappingState', output.sources) stateDecoder.decodeState(stateVars, storageViewer).then((result) => { - console.log('ok', JSON.stringify(result)) st.equal(result['_num'].value, '1') st.equal(result['_num'].type, 'uint256') st.equal(result['_iBreakSolidityState'].type, 'mapping(string => uint256)') diff --git a/libs/remix-debug/test/decoder/vmCall.ts b/libs/remix-debug/test/decoder/vmCall.ts deleted file mode 100644 index a0d2040e7c..0000000000 --- a/libs/remix-debug/test/decoder/vmCall.ts +++ /dev/null @@ -1,76 +0,0 @@ -'use strict' -import { Transaction as Tx } from '@ethereumjs/tx' -import { Block } from '@ethereumjs/block' -import { BN, bufferToHex, Address } from 'ethereumjs-util' -import { vm as remixlibVM } from '@remix-project/remix-lib' -import VM from '@ethereumjs/vm' -import Common from '@ethereumjs/common' - -export function sendTx (vm, from, to, value, data, cb?) { - cb = cb || (() => {}) - return new Promise ((resolve, reject) => { - var tx = new Tx({ - nonce: new BN(from.nonce++), - // gasPrice: new BN(1), - gasLimit: new BN(3000000, 10), - to: to, - value: new BN(value, 10), - data: Buffer.from(data, 'hex') - }) - tx = tx.sign(from.privateKey) - - var block = Block.fromBlockData({ - header: { - timestamp: new Date().getTime() / 1000 | 0, - number: 0 - } - }) // still using default common - - try { - vm.runTx({block: block, tx: tx, skipBalance: true, skipNonce: true}).then(function (result) { - setTimeout(() => { - const hash = bufferToHex(tx.hash()) - cb(null, { hash, result }) - resolve({ hash, result }) - }, 500) - }).catch((error) => { - console.error(error) - cb(error) - reject(error) - }) - } catch (e) { - console.error(e) - } - }) -} - -async function createVm (hardfork) { - const common = new Common({ chain: 'mainnet', hardfork }) - const vm = new VM({ common }) - await vm.init() - return { vm, stateManager: vm.stateManager } -} - -/* - Init VM / Send Transaction -*/ -export async function initVM (st, privateKey) { - var VM = await createVm('berlin') - const vm = VM.vm - - var address = Address.fromPrivateKey(privateKey) - - try { - let account = await vm.stateManager.getAccount(address) - account.balance = new BN('f00000000000000001', 16) - await vm.stateManager.putAccount(address, account) - } catch (error) { - console.log(error) - } - - var web3Provider = new remixlibVM.Web3VMProvider() - web3Provider.setVM(vm) - vm.web3 = web3Provider - return vm -} - diff --git a/libs/remix-debug/test/tests.ts b/libs/remix-debug/test/tests.ts index b105d02f12..87f8c01972 100644 --- a/libs/remix-debug/test/tests.ts +++ b/libs/remix-debug/test/tests.ts @@ -1,5 +1,5 @@ 'use strict' - +require('./vmCall') require('./traceManager') require('./codeManager') require('./disassembler') diff --git a/libs/remix-debug/test/vmCall.ts b/libs/remix-debug/test/vmCall.ts index a640c4d1b8..351563c0b3 100644 --- a/libs/remix-debug/test/vmCall.ts +++ b/libs/remix-debug/test/vmCall.ts @@ -1,63 +1,52 @@ 'use strict' import { Block } from '@ethereumjs/block' +import { Transaction } from '@ethereumjs/tx' import VM from '@ethereumjs/vm' +import { rlp, keccak, bufferToHex } from 'ethereumjs-util' +import { extendWeb3 } from '../src/init' var utileth = require('ethereumjs-util') var Tx = require('@ethereumjs/tx').Transaction var BN = require('ethereumjs-util').BN var remixLib = require('@remix-project/remix-lib') +const { Provider, extend } = require('@remix-project/remix-simulator') +const Web3 = require('web3') -function sendTx (vm, from, to, value, data, cb) { - var tx = new Tx({ - nonce: new BN(from.nonce++), - // gasPrice: new BN(1), - gasLimit: new BN(3000000, 10), - to: to, - value: new BN(value, 10), - data: Buffer.from(data, 'hex') - }) - tx = tx.sign(from.privateKey) - var block = Block.fromBlockData({ - header: { - timestamp: new Date().getTime() / 1000 | 0, - number: 0 - } - }) // still using default common - vm.runTx({block: block, tx: tx, skipBalance: true, skipNonce: true}).then(function (result) { - setTimeout(() => { - cb(null, utileth.bufferToHex(tx.hash())) - }, 500) - }).catch((error) => { - console.error(error) - cb(error) - }) +async function getWeb3 () { + const remixSimulatorProvider = new Provider({ fork: 'berlin' }) + await remixSimulatorProvider.init() + await remixSimulatorProvider.Accounts.resetAccounts() + const web3 = new Web3(remixSimulatorProvider) + extendWeb3(web3) + return web3 } -/* - Init VM / Send Transaction -*/ -async function initVM (privateKey) { - var address = utileth.Address.fromPrivateKey(privateKey) - var vm = new VM({ - activatePrecompiles: true - }) - await vm.init() - +async function sendTx (web3, from, to, value, data, cb) { try { - let account = await vm.stateManager.getAccount(address) - account.balance = new BN('f00000000000000001', 16) - await vm.stateManager.putAccount(address, account) - } catch (error) { - console.log(error) - } - - var web3Provider = new remixLib.vm.Web3VMProvider() - web3Provider.setVM(vm) - vm.web3 = web3Provider - return vm + cb = cb || (() => {}) + console.log('TX', { + from: utileth.Address.fromPrivateKey(from.privateKey).toString('hex'), + to, + value, + data, + gas: 7000000 + }) + const receipt = await web3.eth.sendTransaction({ + from: utileth.Address.fromPrivateKey(from.privateKey).toString('hex'), + to, + value, + data, + gas: 7000000 + }) + console.log('end tx') + cb(null, receipt.transactionHash) + return receipt.transactionHash + } catch (e) { + cb(e) + } } module.exports = { - sendTx: sendTx, - initVM: initVM + sendTx, + getWeb3 } diff --git a/libs/remix-lib/src/web3Provider/web3VmProvider.ts b/libs/remix-lib/src/web3Provider/web3VmProvider.ts index a431507687..f5b5d9f92a 100644 --- a/libs/remix-lib/src/web3Provider/web3VmProvider.ts +++ b/libs/remix-lib/src/web3Provider/web3VmProvider.ts @@ -107,6 +107,7 @@ export class Web3VmProvider { async txWillProcess (data) { this.incr++ this.processingHash = bufferToHex(data.hash()) + this.vmTraces[this.processingHash] = { gas: '0x0', return: '0x0', @@ -114,19 +115,23 @@ export class Web3VmProvider { } const tx = {} tx['hash'] = this.processingHash + tx['from'] = toChecksumAddress(data.getSenderAddress().toString()) if (data.to) { tx['to'] = toChecksumAddress(data.to.toString()) } + this.processingAddress = tx['to'] tx['input'] = bufferToHex(data.data) tx['gas'] = data.gasLimit.toString(10) if (data.value) { tx['value'] = data.value.toString(10) } + this.txs[this.processingHash] = tx this.txsReceipt[this.processingHash] = tx this.storageCache[this.processingHash] = {} + if (data.to) { try { // dumpStorage throws error as 'Missing Node in DB' diff --git a/libs/remix-simulator/src/vm-context.ts b/libs/remix-simulator/src/vm-context.ts index b9cb6a4151..a9f7c7eeec 100644 --- a/libs/remix-simulator/src/vm-context.ts +++ b/libs/remix-simulator/src/vm-context.ts @@ -24,31 +24,27 @@ class StateManagerCommonStorageDump extends StateManager { return super.putContractStorage(address, key, value) } - async dumpStorage (address) { - let trie - try { - trie = await this._getStorageTrie(address) - } catch (e) { - console.log(e) - throw e - } - return new Promise((resolve, reject) => { - try { - const storage = {} - const stream = trie.createReadStream() - stream.on('data', (val) => { - const value = rlp.decode(val.value) - storage['0x' + val.key.toString('hex')] = { - key: this.keyHashes[val.key.toString('hex')], - value: '0x' + value.toString('hex') - } + async dumpStorage (address): Promise { + return new Promise((resolve, reject) => { + this._getStorageTrie(address) + .then((trie) => { + const storage = {} + const stream = trie.createReadStream() + + stream.on('data', (val) => { + const value = rlp.decode(val.value) + storage['0x' + val.key.toString('hex')] = { + key: this.keyHashes[val.key.toString('hex')], + value: '0x' + value.toString('hex') + } + }) + stream.on('end', () => { + resolve(storage) + }) }) - stream.on('end', function () { - resolve(storage) + .catch((e) => { + reject(e) }) - } catch (e) { - reject(e) - } }) } @@ -60,18 +56,18 @@ class StateManagerCommonStorageDump extends StateManager { } async setStateRoot (stateRoot) { - await this._cache.flush() - - if (stateRoot === this._trie.EMPTY_TRIE_ROOT) { - this._trie.root = stateRoot - this._cache.clear() - this._storageTries = {} - return + console.log('setstateroot', stateRoot.toString('hex')) + if (this._checkpointCount !== 0) { + throw new Error('Cannot set state root with uncommitted checkpoints') } - const hasRoot = await this._trie.checkRoot(stateRoot) - if (!hasRoot) { - throw new Error('State trie does not contain state root') + await this._cache.flush() + + if (!stateRoot.equals(this._trie.EMPTY_TRIE_ROOT)) { + const hasRoot = await this._trie.checkRoot(stateRoot) + if (!hasRoot) { + throw new Error('State trie does not contain state root') + } } this._trie.root = stateRoot From abe8eb2acff8155e7135a40ce97d4add6dc35173 Mon Sep 17 00:00:00 2001 From: yann300 Date: Mon, 4 Oct 2021 10:23:48 +0200 Subject: [PATCH 2/6] remove uneeded space --- libs/remix-lib/src/web3Provider/web3VmProvider.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libs/remix-lib/src/web3Provider/web3VmProvider.ts b/libs/remix-lib/src/web3Provider/web3VmProvider.ts index f5b5d9f92a..a431507687 100644 --- a/libs/remix-lib/src/web3Provider/web3VmProvider.ts +++ b/libs/remix-lib/src/web3Provider/web3VmProvider.ts @@ -107,7 +107,6 @@ export class Web3VmProvider { async txWillProcess (data) { this.incr++ this.processingHash = bufferToHex(data.hash()) - this.vmTraces[this.processingHash] = { gas: '0x0', return: '0x0', @@ -115,23 +114,19 @@ export class Web3VmProvider { } const tx = {} tx['hash'] = this.processingHash - tx['from'] = toChecksumAddress(data.getSenderAddress().toString()) if (data.to) { tx['to'] = toChecksumAddress(data.to.toString()) } - this.processingAddress = tx['to'] tx['input'] = bufferToHex(data.data) tx['gas'] = data.gasLimit.toString(10) if (data.value) { tx['value'] = data.value.toString(10) } - this.txs[this.processingHash] = tx this.txsReceipt[this.processingHash] = tx this.storageCache[this.processingHash] = {} - if (data.to) { try { // dumpStorage throws error as 'Missing Node in DB' From 1ebbf4018dc7ece64c51418f260fcb39bf4faa89 Mon Sep 17 00:00:00 2001 From: yann300 Date: Mon, 4 Oct 2021 10:25:33 +0200 Subject: [PATCH 3/6] remove console.log --- libs/remix-simulator/src/vm-context.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/libs/remix-simulator/src/vm-context.ts b/libs/remix-simulator/src/vm-context.ts index a9f7c7eeec..a562331f9c 100644 --- a/libs/remix-simulator/src/vm-context.ts +++ b/libs/remix-simulator/src/vm-context.ts @@ -56,7 +56,6 @@ class StateManagerCommonStorageDump extends StateManager { } async setStateRoot (stateRoot) { - console.log('setstateroot', stateRoot.toString('hex')) if (this._checkpointCount !== 0) { throw new Error('Cannot set state root with uncommitted checkpoints') } From c93cc86ff51887b4fc7c94a37f073c25eb043b8e Mon Sep 17 00:00:00 2001 From: yann300 Date: Mon, 4 Oct 2021 12:28:52 +0200 Subject: [PATCH 4/6] remove console.log --- libs/remix-debug/test/debugger.ts | 1 - libs/remix-debug/test/decoder/stateTests/mapping.ts | 3 --- libs/remix-debug/test/vmCall.ts | 8 -------- 3 files changed, 12 deletions(-) diff --git a/libs/remix-debug/test/debugger.ts b/libs/remix-debug/test/debugger.ts index e98f24d839..8ce4bed268 100644 --- a/libs/remix-debug/test/debugger.ts +++ b/libs/remix-debug/test/debugger.ts @@ -263,7 +263,6 @@ function testDebugging (debugManager) { debugManager.decodeLocalsAt(327, location, (error, decodedlocals) => { if (error) return t.end(error) const res = deepequal(decodedlocals, tested) - console.log(res) t.ok(res, `test if locals does match. expected: ${JSON.stringify(tested)} - current: ${JSON.stringify(decodedlocals)}`) }) } catch (error) { diff --git a/libs/remix-debug/test/decoder/stateTests/mapping.ts b/libs/remix-debug/test/decoder/stateTests/mapping.ts index 9f82c7b495..f2467efb29 100644 --- a/libs/remix-debug/test/decoder/stateTests/mapping.ts +++ b/libs/remix-debug/test/decoder/stateTests/mapping.ts @@ -8,12 +8,10 @@ import { StorageViewer } from '../../../src/storage/storageViewer' import { Address, bufferToHex } from 'ethereumjs-util' module.exports = async function testMappingStorage (st, cb) { - console.log('start testMappingStorage') var mappingStorage = require('../contracts/mappingStorage') var privateKey = Buffer.from('503f38a9c967ed597e47fe25643985f032b072db8075426a92110f82df48dfcb', 'hex') var output = compile(compilerInput(mappingStorage.contract)) output = JSON.parse(output); - console.log('BYTECODE', output.contracts['test.sol']['SimpleMappingState'].evm.bytecode.object); const web3 = await (vmCall as any).getWeb3(); (vmCall as any).sendTx(web3, {nonce: 0, privateKey: privateKey}, null, 0, output.contracts['test.sol']['SimpleMappingState'].evm.bytecode.object, function (error, hash) { if (error) { @@ -26,7 +24,6 @@ module.exports = async function testMappingStorage (st, cb) { st.end(error) } else { // const storage = await this.vm.stateManager.dumpStorage(data.to) - console.log(tx); // (vmCall as any).web3().eth.getCode(tx.contractAddress).then((code) => console.log('code:', code)) // (vmCall as any).web3().debug.traceTransaction(hash).then((code) => console.log('trace:', code)) testMapping(st, privateKey, tx.contractAddress, output, web3, cb) diff --git a/libs/remix-debug/test/vmCall.ts b/libs/remix-debug/test/vmCall.ts index 351563c0b3..d8d400c58c 100644 --- a/libs/remix-debug/test/vmCall.ts +++ b/libs/remix-debug/test/vmCall.ts @@ -24,13 +24,6 @@ async function getWeb3 () { async function sendTx (web3, from, to, value, data, cb) { try { cb = cb || (() => {}) - console.log('TX', { - from: utileth.Address.fromPrivateKey(from.privateKey).toString('hex'), - to, - value, - data, - gas: 7000000 - }) const receipt = await web3.eth.sendTransaction({ from: utileth.Address.fromPrivateKey(from.privateKey).toString('hex'), to, @@ -38,7 +31,6 @@ async function sendTx (web3, from, to, value, data, cb) { data, gas: 7000000 }) - console.log('end tx') cb(null, receipt.transactionHash) return receipt.transactionHash } catch (e) { From dbf9eb03dbb4a114a43ea5a726afb700017efa84 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Mon, 4 Oct 2021 15:30:22 +0200 Subject: [PATCH 5/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 7560f7e22e..40807bc8cb 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "downloadsolc_assets": "wget --no-check-certificate https://binaries.soliditylang.org/wasm/soljson-v0.8.7+commit.e28d00a7.js -O ./apps/remix-ide/src/assets/js/soljson.js && wget --no-check-certificate https://binaries.soliditylang.org/wasm/soljson-v0.8.7+commit.e28d00a7.js -O ./apps/solidity-compiler/src/assets/js/soljson.js", "make-mock-compiler": "node apps/remix-ide/ci/makeMockCompiler.js", "minify": "uglifyjs --in-source-map inline --source-map-inline -c warnings=false", - "build:production": "NODE_ENV=production npx nx build remix-ide --with-deps --skip-nx-cache && npx nx build remix-ide", + "build:production": "NODE_ENV=production npx nx build remix-ide --with-deps --skip-nx-cache && NODE_ENV=production npx nx build remix-ide", "serve:production": "npx http-server ./dist/apps/remix-ide", "nightwatch_parallel": "npm run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js --env=chrome,firefox", "nightwatch_local_firefox": "npm run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js --env=firefox", From 87526583fb03b4dba1c94fcd0c23cb17ea6f2538 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Mon, 4 Oct 2021 15:49:30 +0200 Subject: [PATCH 6/6] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 40807bc8cb..2eb2e5ff98 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "downloadsolc_assets": "wget --no-check-certificate https://binaries.soliditylang.org/wasm/soljson-v0.8.7+commit.e28d00a7.js -O ./apps/remix-ide/src/assets/js/soljson.js && wget --no-check-certificate https://binaries.soliditylang.org/wasm/soljson-v0.8.7+commit.e28d00a7.js -O ./apps/solidity-compiler/src/assets/js/soljson.js", "make-mock-compiler": "node apps/remix-ide/ci/makeMockCompiler.js", "minify": "uglifyjs --in-source-map inline --source-map-inline -c warnings=false", - "build:production": "NODE_ENV=production npx nx build remix-ide --with-deps --skip-nx-cache && NODE_ENV=production npx nx build remix-ide", + "build:production": "NODE_ENV=production nx build remix-ide --with-deps --skip-nx-cache && NODE_ENV=production nx build remix-ide", "serve:production": "npx http-server ./dist/apps/remix-ide", "nightwatch_parallel": "npm run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js --env=chrome,firefox", "nightwatch_local_firefox": "npm run build:e2e && nightwatch --config dist/apps/remix-ide-e2e/nightwatch.js --env=firefox",