modal alert if error

4 years ago · d73f06001c
parent bb1a2cf9d9
commit d73f06001c
2 changed files with 9 additions and 3 deletions
--- a/apps/remix-ide/src/app/ui/landing-page/landing-page.js
+++ b/apps/remix-ide/src/app/ui/landing-page/landing-page.js
@ -247,10 +247,14 @@ export class LandingPage extends ViewPlugin {
            (loadingMsg) => { tooltip(loadingMsg) },
            (error, content, cleanUrl, type, url) => {
              if (error) {
-                modalDialogCustom.alert(error)
+                modalDialogCustom.alert(error.message || error)
              } else {
-                fileProviders.browser.addExternal(type + '/' + cleanUrl, content, url)
+                try {
+                  fileProviders.workspace.addExternal(type + '/' + cleanUrl, content, url)
                  this.verticalIcons.select('fileExplorers')              
+                } catch (e) {
+                  modalDialogCustom.alert(e.message)
+                }                
              }
            }
          )
--- a/apps/remix-ide/src/lib/gist-handler.js
+++ b/apps/remix-ide/src/lib/gist-handler.js
@ -60,6 +60,8 @@ function GistHandler (_window) {
          if (!errorLoadingFile) {
            const provider = fileManager.getProvider('workspace')
            provider.lastLoadedGistId = gistId
+          } else {
+            modalDialogCustom.alert(errorLoadingFile.message || errorLoadingFile)
          }
        })
      })