From db7d96a9d8620e18978e88c27ace0c3de1d02cdc Mon Sep 17 00:00:00 2001 From: serapath Date: Tue, 5 Sep 2017 05:50:34 +0200 Subject: [PATCH] FIX filter bug on typed input + fix file-explorer standardjs bug --- src/app/files/file-explorer.js | 1 - src/app/panels/terminal.js | 17 ++++------------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/app/files/file-explorer.js b/src/app/files/file-explorer.js index fd4d940e15..d8e408b276 100755 --- a/src/app/files/file-explorer.js +++ b/src/app/files/file-explorer.js @@ -70,7 +70,6 @@ function fileExplorer (appAPI, files) { } }) - var self = this var fileEvents = files.event var treeView = new Treeview({ extractData: function (value, tree, key) { diff --git a/src/app/panels/terminal.js b/src/app/panels/terminal.js index 6186064d29..d787af417e 100644 --- a/src/app/panels/terminal.js +++ b/src/app/panels/terminal.js @@ -433,23 +433,15 @@ class Terminal { commands[value] = true if (!self._INDEX.commandsMain[value]) return self._INDEX.commandsMain[value].forEach(item => { - item.root.steps.forEach(item => { - item.hide = false - self._JOURNAL[item.gidx] = item - }) - item.hide = false + item.root.steps.forEach(item => { self._JOURNAL[item.gidx] = item }) self._JOURNAL[item.gidx] = item }) } else if (filterEvent.type === 'deselect') { commands[value] = false if (!self._INDEX.commandsMain[value]) return self._INDEX.commandsMain[value].forEach(item => { - item.root.steps.forEach(item => { - item.hide = true - self._JOURNAL[item.gidx] = item - }) - item.hide = true - self._JOURNAL[item.gidx] = item + item.root.steps.forEach(item => { self._JOURNAL[item.gidx] = undefined }) + self._JOURNAL[item.gidx] = undefined }) } else if (filterEvent.type === 'search') { if (value !== self.data.activeFilters.input) { @@ -465,9 +457,8 @@ class Terminal { } } var df = document.createDocumentFragment() - // var children = self._JOURNAL.map(item => !item.hide && item.el) self._JOURNAL.forEach(item => { - if (!item.hide && item.el) df.appendChild(item.el) + if (item && item.el && !item.hide) df.appendChild(item.el) }) requestAnimationFrame(function updateDOM () { self._view.journal.innerHTML = ''