From 32ce4f50f23884fd61a9ed40ce8a4fd874bff941 Mon Sep 17 00:00:00 2001 From: yann300 Date: Tue, 12 Jul 2016 11:26:22 +0200 Subject: [PATCH] fix css id --- nightwatch.js | 1 + src/BasicPanel.js | 6 ++---- src/CalldataPanel.js | 4 ++-- src/CallstackPanel.js | 4 ++-- src/MemoryPanel.js | 4 ++-- src/StackPanel.js | 4 ++-- src/StoragePanel.js | 4 ++-- test-browser/init.js | 8 ++++---- 8 files changed, 17 insertions(+), 18 deletions(-) diff --git a/nightwatch.js b/nightwatch.js index c1777a0ca6..4cdbb5964f 100644 --- a/nightwatch.js +++ b/nightwatch.js @@ -62,6 +62,7 @@ module.exports = { 'desiredCapabilities': { 'browserName': 'safari', 'javascriptEnabled': true, + 'platform': 'MAC', 'acceptSslCerts': true, 'build': 'build-' + TRAVIS_JOB_NUMBER, 'tunnel-identifier': 'remix_tests_' + TRAVIS_JOB_NUMBER diff --git a/src/BasicPanel.js b/src/BasicPanel.js index e484cf5a8b..2edbba3eb7 100644 --- a/src/BasicPanel.js +++ b/src/BasicPanel.js @@ -3,11 +3,9 @@ var style = require('./styles/basicStyles') var yo = require('yo-yo') var ui = require('./helpers/ui') -function BasicPanel (_name, _id) { +function BasicPanel (_name) { this.data this.name = _name - this.id = _id - this.view } @@ -21,7 +19,7 @@ BasicPanel.prototype.render = function () { ${this.name}
-
${this.data}
+
${this.data}
` if (!this.view) { diff --git a/src/CalldataPanel.js b/src/CalldataPanel.js index 37aa51cd43..e798ebb0f3 100644 --- a/src/CalldataPanel.js +++ b/src/CalldataPanel.js @@ -5,12 +5,12 @@ var yo = require('yo-yo') function CalldataPanel (_parent, _traceManager) { this.parent = _parent this.traceManager = _traceManager - this.basicPanel = new BasicPanel('Call Data', 'calldatapanel') + this.basicPanel = new BasicPanel('Call Data') this.init() } CalldataPanel.prototype.render = function () { - return yo`
${this.basicPanel.render()}
` + return yo`
${this.basicPanel.render()}
` } CalldataPanel.prototype.init = function () { diff --git a/src/CallstackPanel.js b/src/CallstackPanel.js index 4271a92832..31e38361dc 100644 --- a/src/CallstackPanel.js +++ b/src/CallstackPanel.js @@ -5,12 +5,12 @@ var yo = require('yo-yo') function CallstackPanel (_parent, _traceManager) { this.parent = _parent this.traceManager = _traceManager - this.basicPanel = new BasicPanel('Call Stack', 'callstackpanel') + this.basicPanel = new BasicPanel('Call Stack') this.init() } CallstackPanel.prototype.render = function () { - return yo`
${this.basicPanel.render()}
` + return yo`
${this.basicPanel.render()}
` } CallstackPanel.prototype.init = function () { diff --git a/src/MemoryPanel.js b/src/MemoryPanel.js index 959f7b9665..42d8b6c07c 100644 --- a/src/MemoryPanel.js +++ b/src/MemoryPanel.js @@ -6,12 +6,12 @@ var yo = require('yo-yo') function MemoryPanel (_parent, _traceManager) { this.parent = _parent this.traceManager = _traceManager - this.basicPanel = new BasicPanel('Memory', 'memorypanel') + this.basicPanel = new BasicPanel('Memory') this.init() } MemoryPanel.prototype.render = function () { - return yo`
${this.basicPanel.render()}
` + return yo`
${this.basicPanel.render()}
` } MemoryPanel.prototype.init = function () { diff --git a/src/StackPanel.js b/src/StackPanel.js index df72bc7354..c4916ef483 100644 --- a/src/StackPanel.js +++ b/src/StackPanel.js @@ -6,12 +6,12 @@ var yo = require('yo-yo') function StackPanel (_parent, _traceManager) { this.parent = _parent this.traceManager = _traceManager - this.basicPanel = new BasicPanel('Stack', 'stackpanel') + this.basicPanel = new BasicPanel('Stack') this.init() } StackPanel.prototype.render = function () { - return yo`
${this.basicPanel.render()}
` + return yo`
${this.basicPanel.render()}
` } StackPanel.prototype.init = function () { diff --git a/src/StoragePanel.js b/src/StoragePanel.js index b25f98b51b..fe9160524d 100644 --- a/src/StoragePanel.js +++ b/src/StoragePanel.js @@ -5,12 +5,12 @@ var yo = require('yo-yo') function StoragePanel (_parent, _traceManager) { this.parent = _parent this.traceManager = _traceManager - this.basicPanel = new BasicPanel('Storage Changes', 'storagepanel') + this.basicPanel = new BasicPanel('Storage Changes') this.init() } StoragePanel.prototype.render = function () { - return yo`
${this.basicPanel.render()}
` + return yo`
${this.basicPanel.render()}
` } StoragePanel.prototype.init = function () { diff --git a/test-browser/init.js b/test-browser/init.js index 90b4964ebf..9b853a72e1 100644 --- a/test-browser/init.js +++ b/test-browser/init.js @@ -167,12 +167,12 @@ browser.fireEvent = function (el, key, times, callback) { } function assertPanel (id, browser, value) { - browser.expect.element(id + 'basicpanel').text.to.equal(value) + browser.expect.element(id + ' #basicpanel').text.to.equal(value) return browser } function assertPanelValue (id, browser, index, value) { - getInnerText(id + 'basicpanel', browser, function (result) { + getInnerText(id + ' #basicpanel', browser, function (result) { var values if (result.value.indexOf('\r\n') !== -1) { values = result.value.split('\r\n') @@ -188,8 +188,8 @@ function assertPanelValue (id, browser, index, value) { function getInnerText (id, browser, callback) { browser.execute(function (data) { - return document.getElementById(data).innerText - }, [id.substring(1)], function (result) { + return document.querySelector(data).innerText + }, [id], function (result) { callback(result) }) }