From e797eb09b462af425c6cdaadc89fecbf578ddda9 Mon Sep 17 00:00:00 2001 From: Joseph Izang Date: Tue, 1 Nov 2022 14:44:05 +0100 Subject: [PATCH] fix failing proxy e2e --- apps/remix-ide-e2e/src/tests/proxy.test.ts | 11 ++++++----- .../src/lib/components/contractGUI.tsx | 19 ++++++++++--------- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/proxy.test.ts b/apps/remix-ide-e2e/src/tests/proxy.test.ts index 11f85a4a8e..ef587929e4 100644 --- a/apps/remix-ide-e2e/src/tests/proxy.test.ts +++ b/apps/remix-ide-e2e/src/tests/proxy.test.ts @@ -123,11 +123,12 @@ module.exports = { .click('select.udapp_contractNames option[value=MyInitializedToken]') .waitForElementPresent('[data-id="contractGUIDeployWithProxyLabel"]') .click('[data-id="contractGUIDeployWithProxyLabel"]') - .pause(5000) - .waitForElementPresent('input[title="tokenName"]') - .waitForElementPresent('input[title="tokenSymbol"]') - .setValue('input[title="tokenName"]', 'Remix') - .setValue('input[title="tokenSymbol"]', "R") + .useXpath() + .waitForElementPresent('//*[@id="runTabView"]/div/div[2]/div[3]/div[1]/div/div[1]/div[4]/div/div[1]/input') + .waitForElementPresent('//*[@id="runTabView"]/div/div[2]/div[3]/div[1]/div/div[1]/div[4]/div/div[2]/input') + .setValue('//*[@id="runTabView"]/div/div[2]/div[3]/div[1]/div/div[1]/div[4]/div/div[1]/input', 'Remix') + .setValue('//*[@id="runTabView"]/div/div[2]/div[3]/div[1]/div/div[1]/div[4]/div/div[2]/input', "R") + .useCss() .createContract('') .waitForElementContainsText('[data-id="udappNotifyModalDialogModalTitle-react"]', 'Deploy Implementation & Proxy (ERC1967)') .waitForElementVisible('[data-id="udappNotify-modal-footer-ok-react"]') diff --git a/libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx b/libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx index 0b72cba6ca..42015b36fb 100644 --- a/libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx +++ b/libs/remix-ui/run-tab/src/lib/components/contractGUI.tsx @@ -435,20 +435,21 @@ export function ContractGUI (props: ContractGUIProps) { onChange={(e) => handleDeployProxySelect(e.target.checked)} checked={deployState.deploy} /> - An ERC1967 proxy contract
will be deployed along
with the selected
implementation contract.} placement={"bottom-start"} tooltipClasses="text-wrap" tooltipId="deployWithProxyTooltip" - > + > */} -
+ {/* */}
{props.initializerOptions && @@ -484,12 +485,12 @@ export function ContractGUI (props: ContractGUIProps) { {" "} {inp.name}:{" "} - + > */} { initializeFields.current[index] = el; @@ -498,7 +499,7 @@ export function ContractGUI (props: ContractGUIProps) { className="form-control udapp_input" placeholder={inp.type} /> - + {/* */}
); })} @@ -515,12 +516,12 @@ export function ContractGUI (props: ContractGUIProps) { onChange={(e) => handleUpgradeImpSelect(e.target.checked)} checked={deployState.upgrade} /> - + > */} - + {/* */}