From 3129ab7221d49fa9521a50413334f834b6c3a63d Mon Sep 17 00:00:00 2001 From: yann300 Date: Mon, 24 Jul 2017 10:49:08 +0200 Subject: [PATCH 1/2] add IE test --- ci/browser_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/browser_tests.sh b/ci/browser_tests.sh index 86526fa43a..7343a2e70c 100755 --- a/ci/browser_tests.sh +++ b/ci/browser_tests.sh @@ -41,7 +41,7 @@ done npm run nightwatch_remote_chrome || TEST_EXITCODE=1 npm run nightwatch_remote_firefox || TEST_EXITCODE=1 npm run nightwatch_remote_safari || TEST_EXITCODE=1 -# npm run nightwatch_remote_ie || TEST_EXITCODE=1 +npm run nightwatch_remote_ie || TEST_EXITCODE=1 # npm run nightwatch_remote_parallel || TEST_EXITCODE=1 node ci/sauceDisconnect.js "$SAUCECONNECT_USERNAME" "$SAUCECONNECT_ACCESSKEY" "$SAUCECONNECT_JOBIDENTIFIER" From c9b4b6d6e1166c63b2527d006493891dbc3f2358 Mon Sep 17 00:00:00 2001 From: yann300 Date: Mon, 24 Jul 2017 15:04:31 +0200 Subject: [PATCH 2/2] fix IE --- ci/browser_tests.sh | 2 +- src/app/tabbed-menu.js | 7 ++++--- test-browser/tests/sharedFolderExplorer.js | 5 +++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/ci/browser_tests.sh b/ci/browser_tests.sh index 7343a2e70c..51a5cbbcb5 100755 --- a/ci/browser_tests.sh +++ b/ci/browser_tests.sh @@ -42,7 +42,7 @@ npm run nightwatch_remote_chrome || TEST_EXITCODE=1 npm run nightwatch_remote_firefox || TEST_EXITCODE=1 npm run nightwatch_remote_safari || TEST_EXITCODE=1 npm run nightwatch_remote_ie || TEST_EXITCODE=1 -# npm run nightwatch_remote_parallel || TEST_EXITCODE=1 +# npm run nightwatch_remote_parallel || TEST_EXITCODE=1 => cannot run in parallel because of remixd node ci/sauceDisconnect.js "$SAUCECONNECT_USERNAME" "$SAUCECONNECT_ACCESSKEY" "$SAUCECONNECT_JOBIDENTIFIER" diff --git a/src/app/tabbed-menu.js b/src/app/tabbed-menu.js index 86383c7acc..6630116e2c 100644 --- a/src/app/tabbed-menu.js +++ b/src/app/tabbed-menu.js @@ -4,9 +4,10 @@ var loadingSpinner = require('./loading-spinner') module.exports = tabbedMenu function tabbedMenu (container, appAPI, events, opts) { - container.querySelectorAll('li').forEach(function (el) { - el.onclick = function (ev) { selectTab(this) } - }) + var lis = container.querySelectorAll('li') + for (var li = 0; li < lis.length; ++li) { + lis[li].onclick = function (ev) { selectTab(this) } + } events.app.register('debuggingRequested', () => { selectTab(container.querySelector('li.debugView')) diff --git a/test-browser/tests/sharedFolderExplorer.js b/test-browser/tests/sharedFolderExplorer.js index c5b54fa33c..6378f624e1 100644 --- a/test-browser/tests/sharedFolderExplorer.js +++ b/test-browser/tests/sharedFolderExplorer.js @@ -23,8 +23,9 @@ module.exports = { } function runTests (browser, testData) { - if (browser.options.desiredCapabilities.browserName === 'safari') { - console.log('don\'t run remixd test for safari: sauce labs doesn\'t seems to handle websocket') + var browserName = browser.options.desiredCapabilities.browserName + if (browserName === 'safari' || browserName === 'internet explorer') { + console.log('do not run remixd test for ' + browserName + ': sauce labs doesn\'t seems to handle websocket') browser.end() return }