Merge pull request #638 from ethereum/fixIEtest

add IE test
pull/1/head
yann300 7 years ago committed by GitHub
commit ed24728883
  1. 4
      ci/browser_tests.sh
  2. 7
      src/app/tabbed-menu.js
  3. 5
      test-browser/tests/sharedFolderExplorer.js

@ -41,8 +41,8 @@ done
npm run nightwatch_remote_chrome || TEST_EXITCODE=1
npm run nightwatch_remote_firefox || TEST_EXITCODE=1
npm run nightwatch_remote_safari || TEST_EXITCODE=1
# npm run nightwatch_remote_ie || TEST_EXITCODE=1
# npm run nightwatch_remote_parallel || TEST_EXITCODE=1
npm run nightwatch_remote_ie || TEST_EXITCODE=1
# npm run nightwatch_remote_parallel || TEST_EXITCODE=1 => cannot run in parallel because of remixd
node ci/sauceDisconnect.js "$SAUCECONNECT_USERNAME" "$SAUCECONNECT_ACCESSKEY" "$SAUCECONNECT_JOBIDENTIFIER"

@ -4,9 +4,10 @@ var loadingSpinner = require('./loading-spinner')
module.exports = tabbedMenu
function tabbedMenu (container, appAPI, events, opts) {
container.querySelectorAll('li').forEach(function (el) {
el.onclick = function (ev) { selectTab(this) }
})
var lis = container.querySelectorAll('li')
for (var li = 0; li < lis.length; ++li) {
lis[li].onclick = function (ev) { selectTab(this) }
}
events.app.register('debuggingRequested', () => {
selectTab(container.querySelector('li.debugView'))

@ -23,8 +23,9 @@ module.exports = {
}
function runTests (browser, testData) {
if (browser.options.desiredCapabilities.browserName === 'safari') {
console.log('don\'t run remixd test for safari: sauce labs doesn\'t seems to handle websocket')
var browserName = browser.options.desiredCapabilities.browserName
if (browserName === 'safari' || browserName === 'internet explorer') {
console.log('do not run remixd test for ' + browserName + ': sauce labs doesn\'t seems to handle websocket')
browser.end()
return
}

Loading…
Cancel
Save