diff --git a/.circleci/config.yml b/.circleci/config.yml
index ba1668148f..74c3834eb4 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -26,13 +26,13 @@ jobs:
- checkout
- restore_cache:
keys:
- - dep-bundle-18-{{ checksum "package.json" }}
+ - dep-bundle-20-{{ checksum "package.json" }}
- run: npm install
- save_cache:
- key: dep-bundle-18-{{ checksum "package.json" }}
+ key: dep-bundle-20-{{ checksum "package.json" }}
paths:
- ~/repo/node_modules
- - run: npm run lint && npm run test && npm run downloadsolc && npm run make-mock-compiler && npm run build
+ - run: npm run lint && npm run test && npm run make-mock-compiler && npm run build
- run: ./ci/browser_tests.sh
remix-debugger:
@@ -46,10 +46,10 @@ jobs:
- checkout
- restore_cache:
keys:
- - dep-bundle-13-{{ checksum "package.json" }}
+ - dep-bundle-15-{{ checksum "package.json" }}
- run: npm install
- save_cache:
- key: dep-bundle-13-{{ checksum "package.json" }}
+ key: dep-bundle-15-{{ checksum "package.json" }}
paths:
- ~/repo/node_modules
- run: npm run build_debugger
diff --git a/.travis.yml b/.travis.yml
index 77f8b68b5b..5b0e8e0ceb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,7 +6,7 @@ branches:
- master
- remix_live
script:
- - npm run lint && npm run test && npm run downloadsolc && npm run make-mock-compiler && npm run build
+ - npm run lint && npm run test && npm run make-mock-compiler && npm run build
- ./ci/browser_tests.sh
deploy:
- provider: script
diff --git a/package.json b/package.json
index 66e4a1d6ab..046f6e82cb 100644
--- a/package.json
+++ b/package.json
@@ -37,9 +37,10 @@
"npm-link-local": "^1.1.0",
"npm-run-all": "^4.0.2",
"onchange": "^3.2.1",
- "remix-core": "0.0.15",
- "remix-lib": "0.2.9",
- "remix-solidity": "0.1.11",
+ "remix-debug": "latest",
+ "remix-analyzer": "latest",
+ "remix-lib": "latest",
+ "remix-solidity": "latest",
"remix-tests": "latest",
"remixd": "git+https://github.com/ethereum/remixd.git",
"request": "^2.83.0",
@@ -145,19 +146,18 @@
"scripts": {
"setupremix": "npm run pullremix && npm run linkremixcore && npm run linkremixlib && npm run linkremixsolidity;",
"pullremix": "git clone https://github.com/ethereum/remix",
- "linkremixcore": "cd node_modules && rm -rf remix-core && ln -s ../remix/remix-core remix-core && cd ..",
"linkremixlib": "cd node_modules && rm -rf remix-lib && ln -s ../remix/remix-lib remix-lib && cd ..",
"linkremixsolidity": "cd node_modules && rm -rf remix-solidity && ln -s ../remix/remix-solidity remix-solidity && cd ..",
"build": "browserify src/index.js -o build/app.js --exclude solc",
"build_debugger": "browserify src/app/debugger/remix-debugger/index.js -o src/app/debugger/remix-debugger/build/app.js",
"browsertest": "sleep 5 && npm run nightwatch_local",
"csslint": "csslint --ignore=order-alphabetical --errors='errors,duplicate-properties,empty-rules' --exclude-list='assets/css/font-awesome.min.css' assets/css/",
- "downloadsolc": "rimraf soljson.js && cd node_modules/solc && wget --no-check-certificate https://solc-bin.ethereum.org/soljson.js && cd ../../",
"downloadsolc_root": "wget --no-check-certificate https://solc-bin.ethereum.org/soljson.js",
"lint": "standard | notify-error",
"make-mock-compiler": "node ci/makeMockCompiler.js",
"minify": "uglifyjs --in-source-map inline --source-map-inline -c warnings=false",
"nightwatch_local": "nightwatch --config nightwatch.js --env local",
+ "nightwatch_local_debugger": "nightwatch --config nightwatch_debugger.js --env local",
"nightwatch_remote_chrome": "nightwatch --config nightwatch.js --env chrome",
"nightwatch_remote_firefox": "nightwatch --config nightwatch.js --env default",
"nightwatch_remote_ie": "nightwatch --config nightwatch.js --env ie",
diff --git a/src/app/debugger/debugger.js b/src/app/debugger/debugger.js
index f0bcfd25c0..6cd6eb1cc9 100644
--- a/src/app/debugger/debugger.js
+++ b/src/app/debugger/debugger.js
@@ -1,8 +1,7 @@
'use strict'
-
-var Ethdebugger = require('./remix-debugger/src/ui/Ethdebugger')
+var EthdebuggerUI = require('./remix-debugger/src/ui/EthdebuggerUI')
+var Ethdebugger = require('remix-debug').EthDebugger
var remixLib = require('remix-lib')
-var remixCore = require('remix-core')
var executionContext = require('../../execution-context')
var globlalRegistry = require('../../global/registry')
@@ -22,6 +21,7 @@ function Debugger (container, sourceHighlighter, localRegistry) {
}
this.debugger = new Ethdebugger(
{
+ executionContext: executionContext,
compilationResult: () => {
var compilationResult = this._deps.compiler.lastCompilationResult
if (compilationResult) {
@@ -30,17 +30,21 @@ function Debugger (container, sourceHighlighter, localRegistry) {
return null
}
})
+ this.debugger_ui = new EthdebuggerUI({debugger: this.debugger})
this.sourceMappingDecoder = new remixLib.SourceMappingDecoder()
- container.appendChild(this.debugger.render())
+ //
+ // TODO: render doesn't exist anymore
+ container.appendChild(this.debugger_ui.render())
+ //
this.isActive = false
- this.breakPointManager = new remixCore.code.BreakpointManager(this.debugger, (sourceLocation) => {
+ this.breakPointManager = new remixLib.code.BreakpointManager(this.debugger, (sourceLocation) => {
return self._deps.offsetToLineColumnConverter.offsetToLineColumn(sourceLocation, sourceLocation.file, this._deps.compiler.lastCompilationResult.source.sources)
+ }, (step) => {
+ this.debugger_ui.stepManager.jumpTo(step)
})
this.debugger.setBreakpointManager(this.breakPointManager)
- this.breakPointManager.event.register('breakpointHit', (sourceLocation) => {
- })
var self = this
self._deps.editor.event.register('breakpointCleared', (fileName, row) => {
@@ -70,15 +74,18 @@ function Debugger (container, sourceHighlighter, localRegistry) {
})
// register selected code item, highlight the corresponding source location
- this.debugger.codeManager.event.register('changed', this, function (code, address, index) {
+ this.debugger_ui.event.register('indexChanged', function (index) {
if (self._deps.compiler.lastCompilationResult) {
- self.debugger.callTree.sourceLocationTracker.getSourceLocationFromInstructionIndex(address, index, self._deps.compiler.lastCompilationResult.data.contracts, function (error, rawLocation) {
- if (!error && self._deps.compiler.lastCompilationResult && self._deps.compiler.lastCompilationResult.data) {
- var lineColumnPos = self._deps.offsetToLineColumnConverter.offsetToLineColumn(rawLocation, rawLocation.file, self._deps.compiler.lastCompilationResult.source.sources)
- self._components.sourceHighlighter.currentSourceLocation(lineColumnPos, rawLocation)
- } else {
- self._components.sourceHighlighter.currentSourceLocation(null)
- }
+ self.debugger.traceManager.getCurrentCalledAddressAt(index, (error, address) => {
+ if (error) return console.log(error)
+ self.debugger.callTree.sourceLocationTracker.getSourceLocationFromVMTraceIndex(address, index, self._deps.compiler.lastCompilationResult.data.contracts, function (error, rawLocation) {
+ if (!error && self._deps.compiler.lastCompilationResult && self._deps.compiler.lastCompilationResult.data) {
+ var lineColumnPos = self._deps.offsetToLineColumnConverter.offsetToLineColumn(rawLocation, rawLocation.file, self._deps.compiler.lastCompilationResult.source.sources)
+ self._components.sourceHighlighter.currentSourceLocation(lineColumnPos, rawLocation)
+ } else {
+ self._components.sourceHighlighter.currentSourceLocation(null)
+ }
+ })
})
}
})
@@ -91,9 +98,10 @@ function Debugger (container, sourceHighlighter, localRegistry) {
*/
Debugger.prototype.debug = function (txHash) {
var self = this
- this.debugger.web3().eth.getTransaction(txHash, function (error, tx) {
+
+ this.debugger.web3.eth.getTransaction(txHash, function (error, tx) {
if (!error) {
- self.debugger.debug(tx)
+ self.debugger_ui.debug(tx)
}
})
}
@@ -121,7 +129,7 @@ Debugger.prototype.switchProvider = function (type) {
* get the current provider
*/
Debugger.prototype.web3 = function (type) {
- return this.debugger.web3()
+ return this.debugger.web3
}
module.exports = Debugger
diff --git a/src/app/debugger/remix-debugger/index.html b/src/app/debugger/remix-debugger/index.html
index 4c6c33cf4c..bcf170aa24 100644
--- a/src/app/debugger/remix-debugger/index.html
+++ b/src/app/debugger/remix-debugger/index.html
@@ -7,9 +7,8 @@
diff --git a/src/app/debugger/remix-debugger/index.js b/src/app/debugger/remix-debugger/index.js
index f1e8dd6b6c..380808018f 100644
--- a/src/app/debugger/remix-debugger/index.js
+++ b/src/app/debugger/remix-debugger/index.js
@@ -1,6 +1,7 @@
'use strict'
var VMDebugger = require('./src/ui/VmDebugger')
-var Debugger = require('./src/ui/Ethdebugger')
+var Debugger = require('./src/ui/EthdebuggerUI')
+var DebuggerBackend = require('remix-debug').EthDebugger
if (typeof (module) !== 'undefined' && typeof (module.exports) !== 'undefined') {
module.exports = modules()
@@ -14,7 +15,8 @@ function modules () {
return {
ui: {
Debugger: Debugger,
- VMdebugger: VMDebugger
+ VMdebugger: VMDebugger,
+ DebuggerBackend
}
}
}
diff --git a/src/app/debugger/remix-debugger/src/ui/ButtonNavigator.js b/src/app/debugger/remix-debugger/src/ui/ButtonNavigator.js
index 079faf635e..ef0aca9aef 100644
--- a/src/app/debugger/remix-debugger/src/ui/ButtonNavigator.js
+++ b/src/app/debugger/remix-debugger/src/ui/ButtonNavigator.js
@@ -51,6 +51,7 @@ function ButtonNavigator (_parent, _traceManager) {
this.revertionPoint = null
_parent.event.register('indexChanged', this, (index) => {
+ if (!this.view) return
if (index < 0) return
if (_parent.currentStepIndex !== index) return
diff --git a/src/app/debugger/remix-debugger/src/ui/CalldataPanel.js b/src/app/debugger/remix-debugger/src/ui/CalldataPanel.js
index e2fef57b74..6207b078cb 100644
--- a/src/app/debugger/remix-debugger/src/ui/CalldataPanel.js
+++ b/src/app/debugger/remix-debugger/src/ui/CalldataPanel.js
@@ -2,8 +2,8 @@
var DropdownPanel = require('./DropdownPanel')
var yo = require('yo-yo')
-function CalldataPanel (_parent, _traceManager) {
- this.parent = _parent
+function CalldataPanel (_parentUI, _traceManager) {
+ this._parentUI = _parentUI
this.traceManager = _traceManager
this.basicPanel = new DropdownPanel('Call Data', {json: true})
this.init()
@@ -15,15 +15,15 @@ CalldataPanel.prototype.render = function () {
CalldataPanel.prototype.init = function () {
var self = this
- this.parent.event.register('indexChanged', this, function (index) {
+ this._parentUI.event.register('indexChanged', this, function (index) {
if (index < 0) return
- if (self.parent.currentStepIndex !== index) return
+ if (self._parentUI.currentStepIndex !== index) return
self.traceManager.getCallDataAt(index, function (error, calldata) {
if (error) {
self.basicPanel.update({})
console.log(error)
- } else if (self.parent.currentStepIndex === index) {
+ } else if (self._parentUI.currentStepIndex === index) {
self.basicPanel.update(calldata)
}
})
diff --git a/src/app/debugger/remix-debugger/src/ui/CodeListView.js b/src/app/debugger/remix-debugger/src/ui/CodeListView.js
index 797f2a3832..552782a394 100644
--- a/src/app/debugger/remix-debugger/src/ui/CodeListView.js
+++ b/src/app/debugger/remix-debugger/src/ui/CodeListView.js
@@ -12,7 +12,7 @@ var css = csjs`
.instructions {
${styles.rightPanel.debuggerTab.box_Debugger}
overflow-y: scroll;
- max-height: 100px;
+ max-height: 150px;
}
`
function CodeListView (_parent, _codeManager) {
diff --git a/src/app/debugger/remix-debugger/src/ui/Ethdebugger.js b/src/app/debugger/remix-debugger/src/ui/Ethdebugger.js
index 3323551d06..6a0ee8a152 100644
--- a/src/app/debugger/remix-debugger/src/ui/Ethdebugger.js
+++ b/src/app/debugger/remix-debugger/src/ui/Ethdebugger.js
@@ -1,11 +1,9 @@
'use strict'
var TxBrowser = require('./TxBrowser')
var StepManager = require('./StepManager')
-var remixCore = require('remix-core')
-var TraceManager = remixCore.trace.TraceManager
-var VmDebugger = require('./VmDebugger')
var remixLib = require('remix-lib')
-var global = remixLib.global
+var TraceManager = remixLib.trace.TraceManager
+var VmDebugger = require('./VmDebugger')
var init = remixLib.init
var executionContext = remixLib.execution.executionContext
var EventManager = remixLib.EventManager
@@ -13,10 +11,10 @@ var yo = require('yo-yo')
var csjs = require('csjs-inject')
var Web3Providers = remixLib.vm.Web3Providers
var DummyProvider = remixLib.vm.DummyProvider
-var CodeManager = remixCore.code.CodeManager
-var remixSolidity = require('remix-solidity')
-var SolidityProxy = remixSolidity.SolidityProxy
-var InternalCallTree = remixSolidity.InternalCallTree
+var CodeManager = remixLib.code.CodeManager
+var remixDebug = require('remix-debug')
+var SolidityProxy = remixDebug.SolidityDecoder.SolidityProxy
+var InternalCallTree = remixDebug.SolidityDecoder.InternalCallTree
var css = csjs`
.statusMessage {
@@ -59,6 +57,8 @@ function Ethdebugger (opts) {
self.unLoad()
})
this.txBrowser.event.register('newTraceRequested', this, function (blockNumber, txIndex, tx) {
+ console.dir('newTraceRequestd')
+ console.dir(arguments)
self.startDebugging(blockNumber, txIndex, tx)
})
this.txBrowser.event.register('unloadRequested', this, function (blockNumber, txIndex, tx) {
@@ -79,6 +79,18 @@ function Ethdebugger (opts) {
})
}
+Ethdebugger.prototype.setManagers = function () {
+ this.traceManager = new TraceManager({web3: this.web3})
+ this.codeManager = new CodeManager(this.traceManager)
+ this.solidityProxy = new SolidityProxy(this.traceManager, this.codeManager)
+ this.storageResolver = null
+ var callTree = new InternalCallTree(this.event, this.traceManager, this.solidityProxy, this.codeManager, { includeLocalVariables: true })
+ this.callTree = callTree // TODO: currently used by browser solidity, we should improve the API
+ this.vmDebugger = new VmDebugger(this, this.traceManager, this.codeManager, this.solidityProxy, callTree)
+
+ this.callTree = new InternalCallTree(this.event, this.traceManager, this.solidityProxy, this.codeManager, { includeLocalVariables: true })
+}
+
Ethdebugger.prototype.setBreakpointManager = function (breakpointManager) {
this.breakpointManager = breakpointManager
}
@@ -92,13 +104,20 @@ Ethdebugger.prototype.addProvider = function (type, obj) {
this.event.trigger('providerAdded', [type])
}
+Ethdebugger.prototype.updateWeb3Reference = function () {
+ if (!this.txBrowser) return
+ this.txBrowser.web3 = this.web3
+}
+
Ethdebugger.prototype.switchProvider = function (type) {
var self = this
this.web3Providers.get(type, function (error, obj) {
if (error) {
console.log('provider ' + type + ' not defined')
} else {
- global.web3 = obj
+ self.web3 = obj
+ self.setManagers()
+ self.updateWeb3Reference()
executionContext.detectNetwork((error, network) => {
if (error || !network) {
global.web3Debug = obj
@@ -106,6 +125,7 @@ Ethdebugger.prototype.switchProvider = function (type) {
var webDebugNode = init.web3DebugNode(network.name)
global.web3Debug = !webDebugNode ? obj : webDebugNode
}
+ self.updateWeb3Reference()
})
self.event.trigger('providerChanged', [type])
}
@@ -158,6 +178,8 @@ Ethdebugger.prototype.stepChanged = function (stepIndex) {
}
Ethdebugger.prototype.startDebugging = function (blockNumber, txIndex, tx) {
+ console.dir('startDebugging')
+ console.dir(arguments)
if (this.traceManager.isLoading) {
return
}
@@ -167,6 +189,8 @@ Ethdebugger.prototype.startDebugging = function (blockNumber, txIndex, tx) {
console.log('loading trace...')
this.tx = tx
var self = this
+ console.dir('resolving a trace with tx: ')
+ console.dir(tx)
this.traceManager.resolveTrace(tx, function (error, result) {
console.log('trace loaded ' + result)
if (result) {
diff --git a/src/app/debugger/remix-debugger/src/ui/EthdebuggerUI.js b/src/app/debugger/remix-debugger/src/ui/EthdebuggerUI.js
new file mode 100644
index 0000000000..778370a2a2
--- /dev/null
+++ b/src/app/debugger/remix-debugger/src/ui/EthdebuggerUI.js
@@ -0,0 +1,154 @@
+'use strict'
+var TxBrowser = require('./TxBrowser')
+var StepManager = require('./StepManager')
+var VmDebugger = require('./VmDebugger')
+
+var yo = require('yo-yo')
+var csjs = require('csjs-inject')
+
+var remixLib = require('remix-lib')
+var executionContext = remixLib.execution.executionContext
+var EventManager = remixLib.EventManager
+
+var css = csjs`
+ .statusMessage {
+ margin-left: 15px;
+ }
+ .innerShift {
+ padding: 2px;
+ margin-left: 10px;
+ }
+`
+
+function EthdebuggerUI (opts) {
+ this.opts = opts || {}
+ this.debugger = opts.debugger
+
+ if (!this.opts.compilationResult) this.opts.compilationResult = () => { return null }
+
+ var self = this
+ this.event = new EventManager()
+
+ this.currentStepIndex = -1
+ this.tx
+ this.statusMessage = ''
+
+ this.view
+
+ this.event.register('indexChanged', this, function (index) {
+ self.debugger.codeManager.resolveStep(index, self.tx)
+ })
+
+ executionContext.event.register('contextChanged', this, function () {
+ self.updateWeb3Reference()
+ })
+
+ this.txBrowser = new TxBrowser(this, {displayConnectionSetting: false, web3: executionContext.web3()})
+ this.txBrowser.event.register('newTxLoading', this, function () {
+ self.unLoad()
+ })
+ this.txBrowser.event.register('newTraceRequested', this, function (blockNumber, txIndex, tx) {
+ self.startDebugging(blockNumber, txIndex, tx)
+ })
+ this.txBrowser.event.register('unloadRequested', this, function (blockNumber, txIndex, tx) {
+ self.unLoad()
+ })
+}
+
+EthdebuggerUI.prototype.setBreakpointManager = function (breakpointManager) {
+ this.breakpointManager = breakpointManager
+}
+
+EthdebuggerUI.prototype.get_web3 = function () {
+ return this.web3
+}
+
+EthdebuggerUI.prototype.updateWeb3Reference = function (web3) {
+ if (!this.txBrowser) return
+ this.txBrowser.web3 = web3 || executionContext.web3()
+}
+
+EthdebuggerUI.prototype.setCompilationResult = function (compilationResult) {
+ if (compilationResult && compilationResult.sources && compilationResult.contracts) {
+ this.debugger.solidityProxy.reset(compilationResult)
+ } else {
+ this.debugger.solidityProxy.reset({})
+ }
+}
+
+EthdebuggerUI.prototype.debug = function (tx) {
+ this.setCompilationResult(this.opts.compilationResult())
+ if (tx instanceof Object) {
+ this.txBrowser.load(tx.hash, tx)
+ } else if (tx instanceof String) {
+ this.txBrowser.load(tx)
+ }
+}
+
+EthdebuggerUI.prototype.render = function () {
+ this.debuggerPanelsView = yo`
`
+ this.debuggerHeadPanelsView = yo`
`
+ this.stepManagerView = yo`
`
+
+ var view = yo`
+
+ ${this.txBrowser.render()}
+ ${this.debuggerHeadPanelsView}
+ ${this.stepManagerView}
+
+
${this.statusMessage}
+ ${this.debuggerPanelsView}
+
`
+ if (!this.view) {
+ this.view = view
+ }
+ return view
+}
+
+EthdebuggerUI.prototype.unLoad = function () {
+ this.debugger.unLoad()
+ yo.update(this.debuggerHeadPanelsView, yo`
`)
+ yo.update(this.debuggerPanelsView, yo`
`)
+ yo.update(this.stepManagerView, yo`
`)
+ if (this.vmDebugger) this.vmDebugger.remove()
+ if (this.stepManager) this.stepManager.remove()
+ this.vmDebugger = null
+ this.stepManager = null
+ this.event.trigger('traceUnloaded')
+}
+
+EthdebuggerUI.prototype.stepChanged = function (stepIndex) {
+ this.currentStepIndex = stepIndex
+ this.event.trigger('indexChanged', [stepIndex])
+}
+
+EthdebuggerUI.prototype.startDebugging = function (blockNumber, txIndex, tx) {
+ const self = this
+ if (this.debugger.traceManager.isLoading) {
+ return
+ }
+
+ this.tx = tx
+
+ this.stepManager = new StepManager(this, this.debugger.traceManager)
+ this.stepManager.event.register('stepChanged', this, function (stepIndex) {
+ self.stepChanged(stepIndex)
+ })
+
+ this.debugger.codeManager.event.register('changed', this, (code, address, instIndex) => {
+ self.debugger.callTree.sourceLocationTracker.getSourceLocationFromVMTraceIndex(address, this.currentStepIndex, this.debugger.solidityProxy.contracts, (error, sourceLocation) => {
+ if (!error) {
+ self.event.trigger('sourceLocationChanged', [sourceLocation])
+ }
+ })
+ })
+
+ this.vmDebugger = new VmDebugger(this, this.debugger.traceManager, this.debugger.codeManager, this.debugger.solidityProxy, this.debugger.callTree)
+ yo.update(this.debuggerHeadPanelsView, this.vmDebugger.renderHead())
+ yo.update(this.debuggerPanelsView, this.vmDebugger.render())
+ yo.update(this.stepManagerView, this.stepManager.render())
+
+ this.debugger.debug(tx)
+}
+
+module.exports = EthdebuggerUI
diff --git a/src/app/debugger/remix-debugger/src/ui/FullStoragesChanges.js b/src/app/debugger/remix-debugger/src/ui/FullStoragesChanges.js
index ef454851c2..7051efac05 100644
--- a/src/app/debugger/remix-debugger/src/ui/FullStoragesChanges.js
+++ b/src/app/debugger/remix-debugger/src/ui/FullStoragesChanges.js
@@ -1,12 +1,13 @@
'use strict'
var DropdownPanel = require('./DropdownPanel')
-var remixCore = require('remix-core')
-var StorageViewer = remixCore.storage.StorageViewer
+var remixDebug = require('remix-debug')
+var StorageViewer = remixDebug.storage.StorageViewer
var yo = require('yo-yo')
function FullStoragesChanges (_parent, _traceManager) {
this.storageResolver = null
this.parent = _parent
+ this.debugger = _parent.debugger
this.traceManager = _traceManager
this.addresses = []
this.view
@@ -25,7 +26,7 @@ FullStoragesChanges.prototype.render = function () {
FullStoragesChanges.prototype.init = function () {
var self = this
- this.parent.event.register('newTraceLoaded', this, function (length) {
+ this.debugger.event.register('newTraceLoaded', this, function (length) {
self.panels = []
self.traceManager.getAddresses(function (error, addresses) {
if (!error) {
@@ -41,7 +42,7 @@ FullStoragesChanges.prototype.init = function () {
})
})
- this.parent.event.register('indexChanged', this, function (index) {
+ this.debugger.event.register('indexChanged', this, function (index) {
if (index < 0) return
if (self.parent.currentStepIndex !== index) return
if (!self.storageResolver) return
diff --git a/src/app/debugger/remix-debugger/src/ui/SolidityLocals.js b/src/app/debugger/remix-debugger/src/ui/SolidityLocals.js
index aaa5334c20..2fc5861a42 100644
--- a/src/app/debugger/remix-debugger/src/ui/SolidityLocals.js
+++ b/src/app/debugger/remix-debugger/src/ui/SolidityLocals.js
@@ -1,10 +1,9 @@
'use strict'
var DropdownPanel = require('./DropdownPanel')
-var remixSolidity = require('remix-solidity')
-var localDecoder = remixSolidity.localDecoder
+var remixDebug = require('remix-debug')
+var localDecoder = remixDebug.SolidityDecoder.localDecoder
var solidityTypeFormatter = require('./SolidityTypeFormatter')
-var remixCore = require('remix-core')
-var StorageViewer = remixCore.storage.StorageViewer
+var StorageViewer = remixDebug.storage.StorageViewer
var yo = require('yo-yo')
class SolidityLocals {
diff --git a/src/app/debugger/remix-debugger/src/ui/SolidityState.js b/src/app/debugger/remix-debugger/src/ui/SolidityState.js
index f69fc045f4..2f9ec08d6c 100644
--- a/src/app/debugger/remix-debugger/src/ui/SolidityState.js
+++ b/src/app/debugger/remix-debugger/src/ui/SolidityState.js
@@ -1,10 +1,9 @@
'use strict'
var DropdownPanel = require('./DropdownPanel')
-var remixSolidity = require('remix-solidity')
-var stateDecoder = remixSolidity.stateDecoder
+var remixDebug = require('remix-debug')
+var stateDecoder = remixDebug.SolidityDecoder.stateDecoder
var solidityTypeFormatter = require('./SolidityTypeFormatter')
-var remixCore = require('remix-core')
-var StorageViewer = remixCore.storage.StorageViewer
+var StorageViewer = remixDebug.storage.StorageViewer
var yo = require('yo-yo')
function SolidityState (_parent, _traceManager, _codeManager, _solidityProxy) {
diff --git a/src/app/debugger/remix-debugger/src/ui/StepDetail.js b/src/app/debugger/remix-debugger/src/ui/StepDetail.js
index 7e19f0d941..a14b9e192d 100644
--- a/src/app/debugger/remix-debugger/src/ui/StepDetail.js
+++ b/src/app/debugger/remix-debugger/src/ui/StepDetail.js
@@ -2,8 +2,9 @@
var yo = require('yo-yo')
var DropdownPanel = require('./DropdownPanel')
-function StepDetail (_parent, _traceManager) {
- this.parent = _parent
+function StepDetail (_parentUI, _traceManager) {
+ this.debugger = _parentUI.debugger
+ this.parentUI = _parentUI
this.traceManager = _traceManager
this.basicPanel = new DropdownPanel('Step detail', {json: true, displayContentOnly: true})
@@ -19,17 +20,17 @@ StepDetail.prototype.render = function () {
StepDetail.prototype.init = function () {
var self = this
- this.parent.event.register('traceUnloaded', this, function () {
+ this.debugger.event.register('traceUnloaded', this, function () {
self.detail = initDetail()
self.basicPanel.update(self.detail)
})
- this.parent.event.register('newTraceLoaded', this, function () {
+ this.debugger.event.register('newTraceLoaded', this, function () {
self.detail = initDetail()
self.basicPanel.update(self.detail)
})
- this.parent.event.register('indexChanged', this, function (index) {
+ this.parentUI.event.register('indexChanged', this, function (index) {
if (index < 0) return
self.detail['vm trace step'] = index
diff --git a/src/app/debugger/remix-debugger/src/ui/StepManager.js b/src/app/debugger/remix-debugger/src/ui/StepManager.js
index 2dc218986d..d464b292cc 100644
--- a/src/app/debugger/remix-debugger/src/ui/StepManager.js
+++ b/src/app/debugger/remix-debugger/src/ui/StepManager.js
@@ -8,13 +8,14 @@ var util = remixLib.util
function StepManager (_parent, _traceManager) {
this.event = new EventManager()
- this.parent = _parent
+ this.parent = _parent.debugger
this.traceManager = _traceManager
this.sourceMapByAddress = {}
this.solidityMode = false
var self = this
this.parent.event.register('newTraceLoaded', this, function () {
+ if (!this.slider) return
self.traceManager.getLength(function (error, length) {
if (error) {
console.log(error)
@@ -33,6 +34,7 @@ function StepManager (_parent, _traceManager) {
})
this.parent.callTree.event.register('callTreeReady', () => {
+ if (!this.slider) return
if (this.parent.callTree.functionCallStack.length) {
this.jumpTo(this.parent.callTree.functionCallStack[0])
}
@@ -58,13 +60,21 @@ function StepManager (_parent, _traceManager) {
self.jumpTo(exceptionIndex)
})
this.buttonNavigator.event.register('jumpNextBreakpoint', (exceptionIndex) => {
- self.parent.breakpointManager.jumpNextBreakpoint(this.parent.currentStepIndex, true)
+ self.parent.breakpointManager.jumpNextBreakpoint(_parent.currentStepIndex, true)
})
this.buttonNavigator.event.register('jumpPreviousBreakpoint', (exceptionIndex) => {
- self.parent.breakpointManager.jumpPreviousBreakpoint(this.parent.currentStepIndex, true)
+ self.parent.breakpointManager.jumpPreviousBreakpoint(_parent.currentStepIndex, true)
})
}
+StepManager.prototype.remove = function () {
+ // used to stop listenning on event. bad and should be "refactored"
+ this.slider.view = null
+ this.slider = null
+ this.buttonNavigator.view = null
+ this.buttonNavigator = null
+}
+
StepManager.prototype.resolveToReducedTrace = function (value, incr) {
if (this.parent.callTree.reducedTrace.length) {
var nextSource = util.findClosestIndex(value, this.parent.callTree.reducedTrace)
@@ -80,12 +90,10 @@ StepManager.prototype.resolveToReducedTrace = function (value, incr) {
}
StepManager.prototype.render = function () {
- return (
- yo`
+ return yo`
${this.slider.render()}
${this.buttonNavigator.render()}
`
- )
}
StepManager.prototype.reset = function () {
diff --git a/src/app/debugger/remix-debugger/src/ui/StoragePanel.js b/src/app/debugger/remix-debugger/src/ui/StoragePanel.js
index cd4573e4f7..3fdb8218c5 100644
--- a/src/app/debugger/remix-debugger/src/ui/StoragePanel.js
+++ b/src/app/debugger/remix-debugger/src/ui/StoragePanel.js
@@ -1,7 +1,7 @@
'use strict'
var DropdownPanel = require('./DropdownPanel')
-var remixCore = require('remix-core')
-var StorageViewer = remixCore.storage.StorageViewer
+var remixDebug = require('remix-debug')
+var StorageViewer = remixDebug.storage.StorageViewer
var yo = require('yo-yo')
function StoragePanel (_parent, _traceManager) {
diff --git a/src/app/debugger/remix-debugger/src/ui/TxBrowser.js b/src/app/debugger/remix-debugger/src/ui/TxBrowser.js
index f2d6a00aa1..b326cfe41f 100644
--- a/src/app/debugger/remix-debugger/src/ui/TxBrowser.js
+++ b/src/app/debugger/remix-debugger/src/ui/TxBrowser.js
@@ -1,5 +1,4 @@
var remixLib = require('remix-lib')
-var global = remixLib.global
var EventManager = remixLib.EventManager
var traceHelper = remixLib.helpers.trace
var yo = require('yo-yo')
@@ -24,8 +23,8 @@ var css = csjs`
}
.txinput {
${styles.rightPanel.debuggerTab.input_Debugger}
- min-width: 30px;
margin: 3px;
+ width: inherit;
}
.txbuttons {
width: 100%;
@@ -34,6 +33,10 @@ var css = csjs`
}
.txbutton {
${styles.rightPanel.debuggerTab.button_Debugger}
+ width: inherit;
+ }
+ .txbuttonstart {
+ ${styles.rightPanel.debuggerTab.button_Debugger}
}
.txbutton:hover {
color: ${styles.rightPanel.debuggerTab.button_Debugger_icon_HoverColor};
@@ -43,16 +46,16 @@ var css = csjs`
margin-bottom: 10px;
}
`
-function TxBrowser (_parent) {
+function TxBrowser (_parent, opts) {
this.event = new EventManager()
this.blockNumber
this.txNumber
this.view
- this.displayConnectionSetting = true
+ this.displayConnectionSetting = opts.displayConnectionSetting
+ this.web3 = opts.web3
var self = this
_parent.event.register('providerChanged', this, function (provider) {
- self.displayConnectionSetting = provider === 'INTERNAL'
self.setDefaultValues()
if (self.view) {
yo.update(self.view, self.render())
@@ -73,19 +76,23 @@ TxBrowser.prototype.setDefaultValues = function () {
}
}
-TxBrowser.prototype.submit = function () {
+TxBrowser.prototype.submit = function (tx) {
+ var self = this
+ self.event.trigger('newTxLoading', [this.blockNumber, this.txNumber])
+ if (tx) {
+ return self.update(null, tx)
+ }
if (!this.txNumber) {
+ self.update('no tx index or tx hash to look for')
return
}
- this.event.trigger('newTxLoading', [this.blockNumber, this.txNumber])
try {
- var self = this
if (this.txNumber.indexOf('0x') !== -1) {
- global.web3.eth.getTransaction(this.txNumber, function (error, result) {
+ self.web3.eth.getTransaction(this.txNumber, function (error, result) {
self.update(error, result)
})
} else {
- global.web3.eth.getTransactionFromBlock(this.blockNumber, this.txNumber, function (error, result) {
+ self.web3.eth.getTransactionFromBlock(this.blockNumber, this.txNumber, function (error, result) {
self.update(error, result)
})
}
@@ -150,9 +157,9 @@ TxBrowser.prototype.updateTxN = function (ev) {
this.txNumber = ev.target.value
}
-TxBrowser.prototype.load = function (txHash) {
+TxBrowser.prototype.load = function (txHash, tx) {
this.txNumber = txHash
- this.submit()
+ this.submit(tx)
}
TxBrowser.prototype.unload = function (txHash) {
@@ -184,8 +191,8 @@ TxBrowser.prototype.render = function () {
-
-
+ Start debugging
+ Stop
diff --git a/src/app/debugger/remix-debugger/src/ui/VmDebugger.js b/src/app/debugger/remix-debugger/src/ui/VmDebugger.js
index 9e8be588b7..06953b2ccf 100644
--- a/src/app/debugger/remix-debugger/src/ui/VmDebugger.js
+++ b/src/app/debugger/remix-debugger/src/ui/VmDebugger.js
@@ -11,79 +11,82 @@ var StepDetail = require('./StepDetail')
var DropdownPanel = require('./DropdownPanel')
var SolidityState = require('./SolidityState')
var SolidityLocals = require('./SolidityLocals')
-var remixCore = require('remix-core')
-var StorageResolver = remixCore.storage.StorageResolver
+var remixDebug = require('remix-debug')
+var StorageResolver = remixDebug.storage.StorageResolver
var yo = require('yo-yo')
var css = csjs`
.asmCode {
float: left;
- width: 250px;
+ width: 50%;
}
.stepDetail {
- float: right;
+ }
+ .vmheadView {
+ margin-top:10px;
}
`
-function VmDebugger (_parent, _traceManager, _codeManager, _solidityProxy, _callTree) {
+function VmDebugger (_parentUI, _traceManager, _codeManager, _solidityProxy, _callTree) {
+ let _parent = _parentUI.debugger
+ var self = this
+ this.view
this.asmCode = new CodeListView(_parent, _codeManager)
- this.stackPanel = new StackPanel(_parent, _traceManager)
- this.storagePanel = new StoragePanel(_parent, _traceManager)
- this.memoryPanel = new MemoryPanel(_parent, _traceManager)
- this.calldataPanel = new CalldataPanel(_parent, _traceManager)
- this.callstackPanel = new CallstackPanel(_parent, _traceManager)
- this.stepDetail = new StepDetail(_parent, _traceManager)
- this.solidityState = new SolidityState(_parent, _traceManager, _codeManager, _solidityProxy)
- this.solidityLocals = new SolidityLocals(_parent, _traceManager, _callTree)
+ this.stackPanel = new StackPanel(_parentUI, _traceManager)
+ this.storagePanel = new StoragePanel(_parentUI, _traceManager)
+ this.memoryPanel = new MemoryPanel(_parentUI, _traceManager)
+ this.calldataPanel = new CalldataPanel(_parentUI, _traceManager)
+ this.callstackPanel = new CallstackPanel(_parentUI, _traceManager)
+ this.stepDetail = new StepDetail(_parentUI, _traceManager)
+ this.solidityState = new SolidityState(_parentUI, _traceManager, _codeManager, _solidityProxy)
+ this.solidityLocals = new SolidityLocals(_parentUI, _traceManager, _callTree)
/* Return values - */
this.returnValuesPanel = new DropdownPanel('Return Value', {json: true})
this.returnValuesPanel.data = {}
- _parent.event.register('indexChanged', this.returnValuesPanel, function (index) {
- var self = this
+ _parentUI.event.register('indexChanged', this.returnValuesPanel, function (index) {
+ if (!self.view) return
+ var innerself = this
_traceManager.getReturnValue(index, function (error, returnValue) {
if (error) {
- self.update([error])
- } else if (_parent.currentStepIndex === index) {
- self.update([returnValue])
+ innerself.update([error])
+ } else if (_parentUI.currentStepIndex === index) {
+ innerself.update([returnValue])
}
})
})
/* Return values - */
- this.fullStoragesChangesPanel = new FullStoragesChangesPanel(_parent, _traceManager)
+ this.fullStoragesChangesPanel = new FullStoragesChangesPanel(_parentUI, _traceManager)
- this.view
- var self = this
_parent.event.register('newTraceLoaded', this, function () {
- var storageResolver = new StorageResolver()
+ if (!self.view) return
+ var storageResolver = new StorageResolver({web3: _parent.web3})
self.storagePanel.storageResolver = storageResolver
self.solidityState.storageResolver = storageResolver
self.solidityLocals.storageResolver = storageResolver
self.fullStoragesChangesPanel.storageResolver = storageResolver
- self.headView.style.display = 'block'
- self.view.style.display = 'block'
+ self.asmCode.basicPanel.show()
+ self.stackPanel.basicPanel.show()
+ self.storagePanel.basicPanel.show()
+ self.memoryPanel.basicPanel.show()
+ self.calldataPanel.basicPanel.show()
+ self.callstackPanel.basicPanel.show()
})
_parent.event.register('traceUnloaded', this, function () {
- self.headView.style.display = 'none'
- self.view.style.display = 'none'
+ if (!self.view) return
})
_parent.callTree.event.register('callTreeReady', () => {
- self.asmCode.basicPanel.show()
+ if (!self.view) return
if (_parent.callTree.reducedTrace.length) {
self.solidityLocals.basicPanel.show()
self.solidityState.basicPanel.show()
}
- self.stackPanel.basicPanel.show()
- self.storagePanel.basicPanel.show()
- self.memoryPanel.basicPanel.show()
- self.calldataPanel.basicPanel.show()
- self.callstackPanel.basicPanel.show()
})
}
VmDebugger.prototype.renderHead = function () {
- var headView = yo`
+ var headView = yo`
${this.asmCode.render()}
${this.stepDetail.render()}
@@ -95,8 +98,13 @@ VmDebugger.prototype.renderHead = function () {
return headView
}
+VmDebugger.prototype.remove = function () {
+ // used to stop listenning on event. bad and should be "refactored"
+ this.view = null
+}
+
VmDebugger.prototype.render = function () {
- var view = yo`
+ var view = yo`
${this.solidityLocals.render()}
${this.solidityState.render()}
diff --git a/src/app/debugger/remix-debugger/test-browser-debugger/resources/insertTestWeb3.js b/src/app/debugger/remix-debugger/test-browser-debugger/resources/insertTestWeb3.js
index 0d0b2614b7..e82b1c9388 100644
--- a/src/app/debugger/remix-debugger/test-browser-debugger/resources/insertTestWeb3.js
+++ b/src/app/debugger/remix-debugger/test-browser-debugger/resources/insertTestWeb3.js
@@ -13,7 +13,7 @@ function loadJSON (url, callback) {
function loadTestWeb3 (data) {
var container = document.getElementById('app')
- var vmdebugger = container.debugger
+ var vmdebugger = container.debugger.debugger
var uiTestweb3 = {}
uiTestweb3.eth = {}
uiTestweb3.debug = {}
@@ -58,6 +58,7 @@ function loadTestWeb3 (data) {
uiTestweb3.currentProvider = {host: 'web3 modified for testing purposes :)'}
vmdebugger.addProvider('TEST', uiTestweb3)
vmdebugger.switchProvider('TEST')
+ container.debugger.updateWeb3Reference(uiTestweb3)
}
function waitForRemix (data) {
diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index ae68a79e73..6bb5b56398 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -1,5 +1,5 @@
'use strict'
-var StaticAnalysisRunner = require('remix-solidity').CodeAnalysis
+var StaticAnalysisRunner = require('remix-analyzer').CodeAnalysis
var yo = require('yo-yo')
var $ = require('jquery')
var remixLib = require('remix-lib')
diff --git a/team-best-practices.md b/team-best-practices.md
index 3a5047cd98..beca23356e 100644
--- a/team-best-practices.md
+++ b/team-best-practices.md
@@ -16,7 +16,6 @@ Related links:
- Remix live: remix.ethereum.org
- Remix alpha live: remix-alpha.ethereum.org
- Remix-ide NPM module: https://www.npmjs.com/package/remix-ide
- - Remix-core NPM module: https://www.npmjs.com/package/remix-core
- Remix-lib NPM module: https://www.npmjs.com/package/remix-lib
- Remix-solidity NPM module: https://www.npmjs.com/package/remix-solidity
- Remix-debug NPM module: https://www.npmjs.com/package/remix-debug
diff --git a/test-browser-debugger/test/vmdebugger.js b/test-browser-debugger/test/vmdebugger.js
index 8a361928de..5b3dc37de6 100644
--- a/test-browser-debugger/test/vmdebugger.js
+++ b/test-browser-debugger/test/vmdebugger.js
@@ -54,7 +54,7 @@ function panels (browser) {
.click('#load')
.multipleClick('#intoforward', 63)
.assertStack(['0:0x00', '1:0x60', '2:0x65', '3:0x38', '4:0x55', '5:0x60fe47b1'])
- .assertStorageChanges(['0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563:Objectkey:0x00value:0x38'])
+ .assertStorageChanges(['0x290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563:Object'])
.assertCallData(['0:0x60fe47b10000000000000000000000000000000000000000000000000000000000000038'])
.assertCallStack(['0:0x0d3a18d64dfe4f927832ab58d6451cecc4e517c5'])
.assertStackValue(1, '1:0x60')