From 167fae8045ab3abf3d03b0885f8afbede18d0131 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 07:53:10 +0200 Subject: [PATCH 1/7] set flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 7df04afe44..6afeb12361 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.4.1 jobs: diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index 80b0678c1f..fd9f0031b3 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -20,7 +20,7 @@ module.exports = { browser .addFile('Untitled.sol', sources[0]['Untitled.sol']) }, - 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { + 'Set Ballot 0.4.14 #flaky': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) .clickLaunchIcon('solidity') From dc49d93c3c7bb85a020fad62a7638860ed2c06e3 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 07:56:39 +0200 Subject: [PATCH 2/7] grouped --- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index fd9f0031b3..6f64e085fd 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -20,7 +20,7 @@ module.exports = { browser .addFile('Untitled.sol', sources[0]['Untitled.sol']) }, - 'Set Ballot 0.4.14 #flaky': function (browser: NightwatchBrowser) { + 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) .clickLaunchIcon('solidity') @@ -32,7 +32,7 @@ module.exports = { .testContracts('Untitled.sol', sources[0]['Untitled.sol'], ['Ballot']) }, - 'Deploy Ballot #group1': function (browser: NightwatchBrowser) { + 'Deploy Ballot #group1 #flaky': function (browser: NightwatchBrowser) { browser.pause(500) .clickLaunchIcon('udapp') .selectAccount('0xCA35b7d915458EF540aDe6068dFe2F44E8fa733c') From eeff90ca6f1bbb0d688d3a52b3e645f6a42ac23c Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 08:05:02 +0200 Subject: [PATCH 3/7] test fix --- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index 6f64e085fd..e45dd275fe 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -16,13 +16,20 @@ module.exports = { '@sources': function () { return sources }, + 'Turn off autcompilation': function (browser: NightwatchBrowser) { + browser + .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) + .clickLaunchIcon('solidity') + .waitForElementVisible('[for="autoCompile"]') + .click('[for="autoCompile"]') + }, + 'Add Ballot': function (browser: NightwatchBrowser) { browser .addFile('Untitled.sol', sources[0]['Untitled.sol']) }, 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { browser - .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) .clickLaunchIcon('solidity') .setSolidityCompilerVersion('soljson-v0.4.14+commit.c2215d46.js') }, From b10d4c5d867743942469dd70f6b9e29d4b47cbd1 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 08:09:25 +0200 Subject: [PATCH 4/7] do not click --- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index e45dd275fe..d0c2168122 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -19,7 +19,6 @@ module.exports = { 'Turn off autcompilation': function (browser: NightwatchBrowser) { browser .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) - .clickLaunchIcon('solidity') .waitForElementVisible('[for="autoCompile"]') .click('[for="autoCompile"]') }, From 2d740c1cc22dba9f7053f0d0d4d5080c492a6aef Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 09:23:09 +0200 Subject: [PATCH 5/7] set compiler first --- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index d0c2168122..c13ec7c918 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -16,22 +16,17 @@ module.exports = { '@sources': function () { return sources }, - 'Turn off autcompilation': function (browser: NightwatchBrowser) { + + 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { browser - .waitForElementVisible('*[data-id="remixIdeIconPanel"]', 10000) - .waitForElementVisible('[for="autoCompile"]') - .click('[for="autoCompile"]') + .clickLaunchIcon('solidity') + .setSolidityCompilerVersion('soljson-v0.4.14+commit.c2215d46.js') }, 'Add Ballot': function (browser: NightwatchBrowser) { browser .addFile('Untitled.sol', sources[0]['Untitled.sol']) }, - 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { - browser - .clickLaunchIcon('solidity') - .setSolidityCompilerVersion('soljson-v0.4.14+commit.c2215d46.js') - }, 'Compile Ballot with compiler version 0.4.14': function (browser: NightwatchBrowser) { browser From c76cdfde7c5649c07da89fcd22f1480e3e6dfaa7 Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 09:27:14 +0200 Subject: [PATCH 6/7] no click --- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index c13ec7c918..7109e045bc 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -19,7 +19,6 @@ module.exports = { 'Set Ballot 0.4.14': function (browser: NightwatchBrowser) { browser - .clickLaunchIcon('solidity') .setSolidityCompilerVersion('soljson-v0.4.14+commit.c2215d46.js') }, From d2617116900e5278ac0d4903bdf1a9ebde263d5c Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Wed, 29 Mar 2023 09:37:56 +0200 Subject: [PATCH 7/7] turn off flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6afeb12361..7df04afe44 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.1 jobs: diff --git a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts index 7109e045bc..85c7aa75e9 100644 --- a/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts +++ b/apps/remix-ide-e2e/src/tests/ballot_0_4_14.test.ts @@ -32,7 +32,7 @@ module.exports = { .testContracts('Untitled.sol', sources[0]['Untitled.sol'], ['Ballot']) }, - 'Deploy Ballot #group1 #flaky': function (browser: NightwatchBrowser) { + 'Deploy Ballot #group1': function (browser: NightwatchBrowser) { browser.pause(500) .clickLaunchIcon('udapp') .selectAccount('0xCA35b7d915458EF540aDe6068dFe2F44E8fa733c')