diff --git a/src/app/staticanalysis/modules/selfdestruct.js b/src/app/staticanalysis/modules/selfdestruct.js index e8336629a5..27e03a0ec7 100644 --- a/src/app/staticanalysis/modules/selfdestruct.js +++ b/src/app/staticanalysis/modules/selfdestruct.js @@ -17,10 +17,9 @@ selfdestruct.prototype.visit = function (node) { selfdestruct.prototype.report = function () { return this.relevantNodes.map(function (item, i) { return { - warning: yo`Use of selfdestruct: can block calling contracts unexpectedly
- Please, be especially carefull if this contract is referenced by other contracts (i.e. library contracts, interactions). Selfdestruction of called contracts can render callers inoperable.
`, + warning: yo`Use of selfdestruct: can block calling contracts unexpectedly. Be especially careful if this contract is planed to be used by other contracts (i.e. library contracts, interactions). Selfdestruction of the callee contract can leave callers in an inoperable state.`, location: item.src, - more: 'https://www.coindesk.com/ethereum-client-bug-freezes-user-funds-fallout-remains-uncertain/' + more: 'https://paritytech.io/blog/security-alert.html' } }) } diff --git a/test/staticanalysis/test-contracts/selfdestruct.sol b/test/staticanalysis/test-contracts/selfdestruct.sol index 4be7a53f2c..d2e31dfdb0 100644 --- a/test/staticanalysis/test-contracts/selfdestruct.sol +++ b/test/staticanalysis/test-contracts/selfdestruct.sol @@ -1,9 +1,8 @@ contract sd { - uint120 x; + function() public payable { } function c () public constant { - //x++; selfdestruct(address(0xdeadbeef)); }