From b7518fffef1c24be147a9c78cfbb70f5ece028ce Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Thu, 22 Aug 2024 15:07:32 +0200 Subject: [PATCH 1/2] set to flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d5a065c41d..a95ed97b6b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: false + default: true orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts b/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts index 8af5c611d9..b3fb9ecd65 100644 --- a/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts +++ b/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts @@ -153,7 +153,7 @@ module.exports = { .waitForElementContainsText('[data-id="treeViewLi0"]', 'uint256: 10') }, - 'Should save state after running web3 script #group4': function (browser: NightwatchBrowser) { + 'Should save state after running web3 script #flaky #group4': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('settings') .waitForElementPresent('[data-id="settingsTabGenerateContractMetadataLabel"]') @@ -163,16 +163,17 @@ module.exports = { .click('.remixui_compilerConfigSection') .setValue('#evmVersionSelector', 'london') .click('*[data-id="compilerContainerCompileBtn"]') - .pause(5000) .clickLaunchIcon('udapp') .switchEnvironment('vm-london') .clickLaunchIcon('filePanel') + .waitForElementVisible('*[data-id="treeViewLitreeViewItemscripts"]') .click('*[data-id="treeViewLitreeViewItemscripts"]') + .waitForElementVisible('*[data-id="treeViewLitreeViewItemscripts/deploy_with_web3.ts"]') .openFile('scripts/deploy_with_web3.ts') .click('[data-id="play-editor"]') .waitForElementPresent('[data-id="treeViewDivDraggableItem.states/vm-london/state.json"]') .click('[data-id="treeViewDivDraggableItem.states/vm-london/state.json"]') - .pause(100000) + .pause(1000) .getEditorValue((content) => { browser .assert.ok(content.includes('"latestBlockNumber": "0x1"'), 'State is saved') From 601b8dda135fa3c4a6012f83b639956f2dcd16ce Mon Sep 17 00:00:00 2001 From: bunsenstraat Date: Thu, 22 Aug 2024 15:19:59 +0200 Subject: [PATCH 2/2] unflaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 20d48f5099..f0e6ede965 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.4 win: circleci/windows@5.0 diff --git a/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts b/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts index b3fb9ecd65..fc61df37b3 100644 --- a/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts +++ b/apps/remix-ide-e2e/src/tests/runAndDeploy.test.ts @@ -153,7 +153,7 @@ module.exports = { .waitForElementContainsText('[data-id="treeViewLi0"]', 'uint256: 10') }, - 'Should save state after running web3 script #flaky #group4': function (browser: NightwatchBrowser) { + 'Should save state after running web3 script #group4': function (browser: NightwatchBrowser) { browser .clickLaunchIcon('settings') .waitForElementPresent('[data-id="settingsTabGenerateContractMetadataLabel"]')