Fix crash when trying to use automatically deleted ImageOverlay dialog

include/timeline/widgets/ImageItem.h

@@ -79,5 +79,4 @@ private:
         mtx::events::RoomEvent<mtx::events::msg::Image> event_;
 
         QSharedPointer<MatrixClient> client_;
-        QSharedPointer<dialogs::ImageOverlay> image_dialog_;
 };

src/timeline/widgets/ImageItem.cc

@@ -150,9 +150,8 @@ ImageItem::mousePressEvent(QMouseEvent *event)
         if (textRegion_.contains(event->pos())) {
                 openUrl();
         } else {
-                image_dialog_ =
+                auto imgDialog = new dialogs::ImageOverlay(image_);
-                  QSharedPointer<dialogs::ImageOverlay>(new dialogs::ImageOverlay(image_, this));
+                imgDialog->show();
-                image_dialog_->show();
         }
 }