Don't compile qml by default

While it does improve performance a bit, it is simply bad for most
distributions, since they don't know and probably don't want to
recompile Nheko. So default it to off. Anyone who wants it can still
toggle it on and it is almost no maintenance cost.
master
Nicolas Werner 4 years ago
parent f6fa494666
commit d177405913
  1. 1
      CMakeLists.txt
  2. 2
      cmake/Translations.cmake
  3. 3
      io.github.NhekoReborn.Nheko.json

@ -4,6 +4,7 @@ option(APPVEYOR_BUILD "Build on appveyor" OFF)
option(CI_BUILD "Set when building in CI. Enables -Werror where possible" OFF) option(CI_BUILD "Set when building in CI. Enables -Werror where possible" OFF)
option(ASAN "Compile with address sanitizers" OFF) option(ASAN "Compile with address sanitizers" OFF)
option(QML_DEBUGGING "Enable qml debugging" OFF) option(QML_DEBUGGING "Enable qml debugging" OFF)
option(COMPILE_QML "Compile Qml. It will make Nheko faster, but you will need to recompile it, when you update Qt." OFF)
set( set(
CMAKE_TOOLCHAIN_FILE "${CMAKE_CURRENT_LIST_DIR}/toolchain.cmake" CMAKE_TOOLCHAIN_FILE "${CMAKE_CURRENT_LIST_DIR}/toolchain.cmake"

@ -21,7 +21,7 @@ if(NOT EXISTS ${_qrc})
endif() endif()
qt5_add_resources(LANG_QRC ${_qrc}) qt5_add_resources(LANG_QRC ${_qrc})
if(Qt5QuickCompiler_FOUND) if(Qt5QuickCompiler_FOUND AND COMPILE_QML)
qtquick_compiler_add_resources(QRC resources/res.qrc) qtquick_compiler_add_resources(QRC resources/res.qrc)
else() else()
qt5_add_resources(QRC resources/res.qrc) qt5_add_resources(QRC resources/res.qrc)

@ -171,7 +171,8 @@
{ {
"config-opts": [ "config-opts": [
"-DCMAKE_BUILD_TYPE=Release", "-DCMAKE_BUILD_TYPE=Release",
"-DLMDBXX_INCLUDE_DIR=.deps/lmdbxx" "-DLMDBXX_INCLUDE_DIR=.deps/lmdbxx",
"-DCOMPILE_QML=ON"
], ],
"buildsystem": "cmake-ninja", "buildsystem": "cmake-ninja",
"name": "nheko", "name": "nheko",

Loading…
Cancel
Save