mirror of https://github.com/go-gitea/gitea
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1), confidential and public. Previously Gitea assumed all clients to be confidential. > OAuth defines two client types, based on their ability to authenticate securely with the authorization server (i.e., ability to > maintain the confidentiality of their client credentials): > > confidential > Clients capable of maintaining the confidentiality of their credentials (e.g., client implemented on a secure server with > restricted access to the client credentials), or capable of secure client authentication using other means. > > **public > Clients incapable of maintaining the confidentiality of their credentials (e.g., clients executing on the device used by the resource owner, such as an installed native application or a web browser-based application), and incapable of secure client authentication via any other means.** > > The client type designation is based on the authorization server's definition of secure authentication and its acceptable exposure levels of client credentials. The authorization server SHOULD NOT make assumptions about the client type. https://datatracker.ietf.org/doc/html/rfc8252#section-8.4 > Authorization servers MUST record the client type in the client registration details in order to identify and process requests accordingly. Require PKCE for public clients: https://datatracker.ietf.org/doc/html/rfc8252#section-8.1 > Authorization servers SHOULD reject authorization requests from native apps that don't use PKCE by returning an error message Fixes #21299 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>pull/21172/head^2
M Hickford
2 years ago
committed by
GitHub
parent
e1ce45eabf
commit
191a74d622
@ -0,0 +1,2 @@ |
||||
- |
||||
id: 1 |
||||
@ -0,0 +1,18 @@ |
||||
// Copyright 2022 The Gitea Authors. All rights reserved.
|
||||
// Use of this source code is governed by a MIT-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package migrations |
||||
|
||||
import ( |
||||
"xorm.io/xorm" |
||||
) |
||||
|
||||
// addConfidentialColumnToOAuth2ApplicationTable: add ConfidentialClient column, setting existing rows to true
|
||||
func addConfidentialClientColumnToOAuth2ApplicationTable(x *xorm.Engine) error { |
||||
type OAuth2Application struct { |
||||
ConfidentialClient bool `xorm:"NOT NULL DEFAULT TRUE"` |
||||
} |
||||
|
||||
return x.Sync(new(OAuth2Application)) |
||||
} |
||||
@ -0,0 +1,46 @@ |
||||
// Copyright 2022 The Gitea Authors. All rights reserved.
|
||||
// Use of this source code is governed by a MIT-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package migrations |
||||
|
||||
import ( |
||||
"testing" |
||||
|
||||
"github.com/stretchr/testify/assert" |
||||
) |
||||
|
||||
func Test_addConfidentialClientColumnToOAuth2ApplicationTable(t *testing.T) { |
||||
// premigration
|
||||
type OAuth2Application struct { |
||||
ID int64 |
||||
} |
||||
|
||||
// Prepare and load the testing database
|
||||
x, deferable := prepareTestEnv(t, 0, new(OAuth2Application)) |
||||
defer deferable() |
||||
if x == nil || t.Failed() { |
||||
return |
||||
} |
||||
|
||||
if err := addConfidentialClientColumnToOAuth2ApplicationTable(x); err != nil { |
||||
assert.NoError(t, err) |
||||
return |
||||
} |
||||
|
||||
// postmigration
|
||||
type ExpectedOAuth2Application struct { |
||||
ID int64 |
||||
ConfidentialClient bool |
||||
} |
||||
|
||||
got := []ExpectedOAuth2Application{} |
||||
if err := x.Table("o_auth2_application").Select("id, confidential_client").Find(&got); !assert.NoError(t, err) { |
||||
return |
||||
} |
||||
|
||||
assert.NotEmpty(t, got) |
||||
for _, e := range got { |
||||
assert.True(t, e.ConfidentialClient) |
||||
} |
||||
} |
||||
Loading…
Reference in new issue