clean tail

models/oauth2.go

@@ -1,9 +1,6 @@
 package models
 
-import (
+import "errors"
-	"errors"
-	"fmt"
-)
 
 // OT: Oauth2 Type
 const (
@@ -41,8 +38,7 @@ func GetOauth2(identity string) (oa *Oauth2, err error) {
 		return
 	}
 	if !exists {
-		err = fmt.Errorf("not exists oauth2: %s", identity)
+		return nil, ErrOauth2RecordNotExists
-		return
 	}
 	if oa.Uid == 0 {
 		return oa, ErrOauth2NotAssociatedWithUser

routers/user/social.go

@@ -109,6 +109,9 @@ func SocialSignIn(ctx *middleware.Context, tokens oauth2.Tokens) {
 		}
 	case models.ErrOauth2NotAssociatedWithUser:
 		// pass
+	default:
+		log.Error(err) // FIXME: handle error page
+		return
 	}
 	ctx.Session.Set("socialId", oa.Id)
 	log.Info("socialId: %v", oa.Id)