mirror of https://github.com/go-gitea/gitea
Add the ability to pin Issues (#24406)
This adds the ability to pin important Issues and Pull Requests. You can also move pinned Issues around to change their Position. Resolves #2175. ## Screenshots    The Design was mostly copied from the Projects Board. ## Implementation This uses a new `pin_order` Column in the `issue` table. If the value is set to 0, the Issue is not pinned. If it's set to a bigger value, the value is the Position. 1 means it's the first pinned Issue, 2 means it's the second one etc. This is dived into Issues and Pull requests for each Repo. ## TODO - [x] You can currently pin as many Issues as you want. Maybe we should add a Limit, which is configurable. GitHub uses 3, but I prefer 6, as this is better for bigger Projects, but I'm open for suggestions. - [x] Pin and Unpin events need to be added to the Issue history. - [x] Tests - [x] Migration **The feature itself is currently fully working, so tester who may find weird edge cases are very welcome!** --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>pull/23939/head^2
JakobDev
2 years ago
committed by
GitHub
parent
79087bdb26
commit
aaa1094663
@ -0,0 +1,16 @@ |
|||||||
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package v1_20 //nolint
|
||||||
|
|
||||||
|
import ( |
||||||
|
"xorm.io/xorm" |
||||||
|
) |
||||||
|
|
||||||
|
func AddPinOrderToIssue(x *xorm.Engine) error { |
||||||
|
type Issue struct { |
||||||
|
PinOrder int `xorm:"DEFAULT 0"` |
||||||
|
} |
||||||
|
|
||||||
|
return x.Sync(new(Issue)) |
||||||
|
} |
||||||
@ -0,0 +1,301 @@ |
|||||||
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package repo |
||||||
|
|
||||||
|
import ( |
||||||
|
"net/http" |
||||||
|
|
||||||
|
issues_model "code.gitea.io/gitea/models/issues" |
||||||
|
"code.gitea.io/gitea/modules/context" |
||||||
|
api "code.gitea.io/gitea/modules/structs" |
||||||
|
"code.gitea.io/gitea/services/convert" |
||||||
|
) |
||||||
|
|
||||||
|
// PinIssue pins a issue
|
||||||
|
func PinIssue(ctx *context.APIContext) { |
||||||
|
// swagger:operation POST /repos/{owner}/{repo}/issues/{index}/pin issue pinIssue
|
||||||
|
// ---
|
||||||
|
// summary: Pin an Issue
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: index
|
||||||
|
// in: path
|
||||||
|
// description: index of issue to pin
|
||||||
|
// type: integer
|
||||||
|
// format: int64
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "204":
|
||||||
|
// "$ref": "#/responses/empty"
|
||||||
|
// "403":
|
||||||
|
// "$ref": "#/responses/forbidden"
|
||||||
|
// "404":
|
||||||
|
// "$ref": "#/responses/notFound"
|
||||||
|
issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) |
||||||
|
if err != nil { |
||||||
|
if issues_model.IsErrIssueNotExist(err) { |
||||||
|
ctx.NotFound() |
||||||
|
} else { |
||||||
|
ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) |
||||||
|
} |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
// If we don't do this, it will crash when trying to add the pin event to the comment history
|
||||||
|
err = issue.LoadRepo(ctx) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadRepo", err) |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.Pin(ctx, ctx.Doer) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "PinIssue", err) |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
} |
||||||
|
|
||||||
|
// UnpinIssue unpins a Issue
|
||||||
|
func UnpinIssue(ctx *context.APIContext) { |
||||||
|
// swagger:operation DELETE /repos/{owner}/{repo}/issues/{index}/pin issue unpinIssue
|
||||||
|
// ---
|
||||||
|
// summary: Unpin an Issue
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: index
|
||||||
|
// in: path
|
||||||
|
// description: index of issue to unpin
|
||||||
|
// type: integer
|
||||||
|
// format: int64
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "204":
|
||||||
|
// "$ref": "#/responses/empty"
|
||||||
|
// "403":
|
||||||
|
// "$ref": "#/responses/forbidden"
|
||||||
|
// "404":
|
||||||
|
// "$ref": "#/responses/notFound"
|
||||||
|
issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) |
||||||
|
if err != nil { |
||||||
|
if issues_model.IsErrIssueNotExist(err) { |
||||||
|
ctx.NotFound() |
||||||
|
} else { |
||||||
|
ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) |
||||||
|
} |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
// If we don't do this, it will crash when trying to add the unpin event to the comment history
|
||||||
|
err = issue.LoadRepo(ctx) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadRepo", err) |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.Unpin(ctx, ctx.Doer) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "UnpinIssue", err) |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
} |
||||||
|
|
||||||
|
// MoveIssuePin moves a pinned Issue to a new Position
|
||||||
|
func MoveIssuePin(ctx *context.APIContext) { |
||||||
|
// swagger:operation PATCH /repos/{owner}/{repo}/issues/{index}/pin/{position} issue moveIssuePin
|
||||||
|
// ---
|
||||||
|
// summary: Moves the Pin to the given Position
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: index
|
||||||
|
// in: path
|
||||||
|
// description: index of issue
|
||||||
|
// type: integer
|
||||||
|
// format: int64
|
||||||
|
// required: true
|
||||||
|
// - name: position
|
||||||
|
// in: path
|
||||||
|
// description: the new position
|
||||||
|
// type: integer
|
||||||
|
// format: int64
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "204":
|
||||||
|
// "$ref": "#/responses/empty"
|
||||||
|
// "403":
|
||||||
|
// "$ref": "#/responses/forbidden"
|
||||||
|
// "404":
|
||||||
|
// "$ref": "#/responses/notFound"
|
||||||
|
issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index")) |
||||||
|
if err != nil { |
||||||
|
if issues_model.IsErrIssueNotExist(err) { |
||||||
|
ctx.NotFound() |
||||||
|
} else { |
||||||
|
ctx.Error(http.StatusInternalServerError, "GetIssueByIndex", err) |
||||||
|
} |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.MovePin(ctx, int(ctx.ParamsInt64(":position"))) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "MovePin", err) |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
} |
||||||
|
|
||||||
|
// ListPinnedIssues returns a list of all pinned Issues
|
||||||
|
func ListPinnedIssues(ctx *context.APIContext) { |
||||||
|
// swagger:operation GET /repos/{owner}/{repo}/issues/pinned repository repoListPinnedIssues
|
||||||
|
// ---
|
||||||
|
// summary: List a repo's pinned issues
|
||||||
|
// produces:
|
||||||
|
// - application/json
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "200":
|
||||||
|
// "$ref": "#/responses/IssueList"
|
||||||
|
issues, err := issues_model.GetPinnedIssues(ctx, ctx.Repo.Repository.ID, false) |
||||||
|
|
||||||
|
if err == nil { |
||||||
|
ctx.JSON(http.StatusOK, convert.ToAPIIssueList(ctx, issues)) |
||||||
|
} else { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadPinnedIssues", err) |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
// ListPinnedPullRequests returns a list of all pinned PRs
|
||||||
|
func ListPinnedPullRequests(ctx *context.APIContext) { |
||||||
|
// swagger:operation GET /repos/{owner}/{repo}/pulls/pinned repository repoListPinnedPullRequests
|
||||||
|
// ---
|
||||||
|
// summary: List a repo's pinned pull requests
|
||||||
|
// produces:
|
||||||
|
// - application/json
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "200":
|
||||||
|
// "$ref": "#/responses/PullRequestList"
|
||||||
|
issues, err := issues_model.GetPinnedIssues(ctx, ctx.Repo.Repository.ID, true) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadPinnedPullRequests", err) |
||||||
|
} |
||||||
|
|
||||||
|
apiPrs := make([]*api.PullRequest, len(issues)) |
||||||
|
for i, currentIssue := range issues { |
||||||
|
pr, err := currentIssue.GetPullRequest() |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "GetPullRequest", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
if err = pr.LoadIssue(ctx); err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadIssue", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
if err = pr.LoadAttributes(ctx); err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadAttributes", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
if err = pr.LoadBaseRepo(ctx); err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadBaseRepo", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
if err = pr.LoadHeadRepo(ctx); err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "LoadHeadRepo", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
apiPrs[i] = convert.ToAPIPullRequest(ctx, pr, ctx.Doer) |
||||||
|
} |
||||||
|
|
||||||
|
ctx.JSON(http.StatusOK, &apiPrs) |
||||||
|
} |
||||||
|
|
||||||
|
// AreNewIssuePinsAllowed returns if new issues pins are allowed
|
||||||
|
func AreNewIssuePinsAllowed(ctx *context.APIContext) { |
||||||
|
// swagger:operation GET /repos/{owner}/{repo}/new_pin_allowed repository repoNewPinAllowed
|
||||||
|
// ---
|
||||||
|
// summary: Returns if new Issue Pins are allowed
|
||||||
|
// produces:
|
||||||
|
// - application/json
|
||||||
|
// parameters:
|
||||||
|
// - name: owner
|
||||||
|
// in: path
|
||||||
|
// description: owner of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// - name: repo
|
||||||
|
// in: path
|
||||||
|
// description: name of the repo
|
||||||
|
// type: string
|
||||||
|
// required: true
|
||||||
|
// responses:
|
||||||
|
// "200":
|
||||||
|
// "$ref": "#/responses/RepoNewIssuePinsAllowed"
|
||||||
|
pinsAllowed := api.NewIssuePinsAllowed{} |
||||||
|
var err error |
||||||
|
|
||||||
|
pinsAllowed.Issues, err = issues_model.IsNewPinAllowed(ctx, ctx.Repo.Repository.ID, false) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "IsNewIssuePinAllowed", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
pinsAllowed.PullRequests, err = issues_model.IsNewPinAllowed(ctx, ctx.Repo.Repository.ID, true) |
||||||
|
if err != nil { |
||||||
|
ctx.Error(http.StatusInternalServerError, "IsNewPullRequestPinAllowed", err) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
ctx.JSON(http.StatusOK, pinsAllowed) |
||||||
|
} |
||||||
@ -0,0 +1,88 @@ |
|||||||
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package repo |
||||||
|
|
||||||
|
import ( |
||||||
|
"net/http" |
||||||
|
|
||||||
|
issues_model "code.gitea.io/gitea/models/issues" |
||||||
|
"code.gitea.io/gitea/modules/context" |
||||||
|
"code.gitea.io/gitea/modules/json" |
||||||
|
) |
||||||
|
|
||||||
|
// IssuePinOrUnpin pin or unpin a Issue
|
||||||
|
func IssuePinOrUnpin(ctx *context.Context) { |
||||||
|
issue := GetActionIssue(ctx) |
||||||
|
|
||||||
|
// If we don't do this, it will crash when trying to add the pin event to the comment history
|
||||||
|
err := issue.LoadRepo(ctx) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.PinOrUnpin(ctx, ctx.Doer) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Redirect(issue.Link()) |
||||||
|
} |
||||||
|
|
||||||
|
// IssueUnpin unpins a Issue
|
||||||
|
func IssueUnpin(ctx *context.Context) { |
||||||
|
issue, err := issues_model.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":id")) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
// If we don't do this, it will crash when trying to add the pin event to the comment history
|
||||||
|
err = issue.LoadRepo(ctx) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.Unpin(ctx, ctx.Doer) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
} |
||||||
|
|
||||||
|
// IssuePinMove moves a pinned Issue
|
||||||
|
func IssuePinMove(ctx *context.Context) { |
||||||
|
if ctx.Doer == nil { |
||||||
|
ctx.JSON(http.StatusForbidden, "Only signed in users are allowed to perform this action.") |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
type movePinIssueForm struct { |
||||||
|
ID int64 `json:"id"` |
||||||
|
Position int `json:"position"` |
||||||
|
} |
||||||
|
|
||||||
|
form := &movePinIssueForm{} |
||||||
|
if err := json.NewDecoder(ctx.Req.Body).Decode(&form); err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
issue, err := issues_model.GetIssueByID(ctx, form.ID) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
err = issue.MovePin(ctx, form.Position) |
||||||
|
if err != nil { |
||||||
|
ctx.Status(http.StatusInternalServerError) |
||||||
|
return |
||||||
|
} |
||||||
|
|
||||||
|
ctx.Status(http.StatusNoContent) |
||||||
|
} |
||||||
@ -0,0 +1,205 @@ |
|||||||
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package integration |
||||||
|
|
||||||
|
import ( |
||||||
|
"fmt" |
||||||
|
"net/http" |
||||||
|
"testing" |
||||||
|
|
||||||
|
auth_model "code.gitea.io/gitea/models/auth" |
||||||
|
issues_model "code.gitea.io/gitea/models/issues" |
||||||
|
repo_model "code.gitea.io/gitea/models/repo" |
||||||
|
"code.gitea.io/gitea/models/unittest" |
||||||
|
user_model "code.gitea.io/gitea/models/user" |
||||||
|
api "code.gitea.io/gitea/modules/structs" |
||||||
|
"code.gitea.io/gitea/tests" |
||||||
|
|
||||||
|
"github.com/stretchr/testify/assert" |
||||||
|
) |
||||||
|
|
||||||
|
func TestAPIPinIssue(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
assert.NoError(t, unittest.LoadFixtures()) |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{RepoID: repo.ID}) |
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) |
||||||
|
|
||||||
|
session := loginUser(t, owner.Name) |
||||||
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo) |
||||||
|
|
||||||
|
// Pin the Issue
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req := NewRequest(t, "POST", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the Issue is pinned
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueAPI api.Issue |
||||||
|
DecodeJSON(t, resp, &issueAPI) |
||||||
|
assert.Equal(t, 1, issueAPI.PinOrder) |
||||||
|
} |
||||||
|
|
||||||
|
func TestAPIUnpinIssue(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
assert.NoError(t, unittest.LoadFixtures()) |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{RepoID: repo.ID}) |
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) |
||||||
|
|
||||||
|
session := loginUser(t, owner.Name) |
||||||
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo) |
||||||
|
|
||||||
|
// Pin the Issue
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req := NewRequest(t, "POST", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the Issue is pinned
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueAPI api.Issue |
||||||
|
DecodeJSON(t, resp, &issueAPI) |
||||||
|
assert.Equal(t, 1, issueAPI.PinOrder) |
||||||
|
|
||||||
|
// Unpin the Issue
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req = NewRequest(t, "DELETE", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the Issue is no longer pinned
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp = MakeRequest(t, req, http.StatusOK) |
||||||
|
DecodeJSON(t, resp, &issueAPI) |
||||||
|
assert.Equal(t, 0, issueAPI.PinOrder) |
||||||
|
} |
||||||
|
|
||||||
|
func TestAPIMoveIssuePin(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
assert.NoError(t, unittest.LoadFixtures()) |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{RepoID: repo.ID}) |
||||||
|
issue2 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2, RepoID: repo.ID}) |
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) |
||||||
|
|
||||||
|
session := loginUser(t, owner.Name) |
||||||
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo) |
||||||
|
|
||||||
|
// Pin the first Issue
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req := NewRequest(t, "POST", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the first Issue is pinned at position 1
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueAPI api.Issue |
||||||
|
DecodeJSON(t, resp, &issueAPI) |
||||||
|
assert.Equal(t, 1, issueAPI.PinOrder) |
||||||
|
|
||||||
|
// Pin the second Issue
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue2.Index, token) |
||||||
|
req = NewRequest(t, "POST", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Move the first Issue to position 2
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin/2?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req = NewRequest(t, "PATCH", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the first Issue is pinned at position 2
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp = MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueAPI3 api.Issue |
||||||
|
DecodeJSON(t, resp, &issueAPI3) |
||||||
|
assert.Equal(t, 2, issueAPI3.PinOrder) |
||||||
|
|
||||||
|
// Check if the second Issue is pinned at position 1
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d", repo.OwnerName, repo.Name, issue2.Index) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp = MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueAPI4 api.Issue |
||||||
|
DecodeJSON(t, resp, &issueAPI4) |
||||||
|
assert.Equal(t, 1, issueAPI4.PinOrder) |
||||||
|
} |
||||||
|
|
||||||
|
func TestAPIListPinnedIssues(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
assert.NoError(t, unittest.LoadFixtures()) |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{RepoID: repo.ID}) |
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) |
||||||
|
|
||||||
|
session := loginUser(t, owner.Name) |
||||||
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo) |
||||||
|
|
||||||
|
// Pin the Issue
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/pin?token=%s", |
||||||
|
repo.OwnerName, repo.Name, issue.Index, token) |
||||||
|
req := NewRequest(t, "POST", urlStr) |
||||||
|
MakeRequest(t, req, http.StatusNoContent) |
||||||
|
|
||||||
|
// Check if the Issue is in the List
|
||||||
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/pinned", repo.OwnerName, repo.Name) |
||||||
|
req = NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
var issueList []api.Issue |
||||||
|
DecodeJSON(t, resp, &issueList) |
||||||
|
|
||||||
|
assert.Equal(t, 1, len(issueList)) |
||||||
|
assert.Equal(t, issue.ID, issueList[0].ID) |
||||||
|
} |
||||||
|
|
||||||
|
func TestAPIListPinnedPullrequests(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
assert.NoError(t, unittest.LoadFixtures()) |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/pulls/pinned", repo.OwnerName, repo.Name) |
||||||
|
req := NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
var prList []api.PullRequest |
||||||
|
DecodeJSON(t, resp, &prList) |
||||||
|
|
||||||
|
assert.Equal(t, 0, len(prList)) |
||||||
|
} |
||||||
|
|
||||||
|
func TestAPINewPinAllowed(t *testing.T) { |
||||||
|
defer tests.PrepareTestEnv(t)() |
||||||
|
|
||||||
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1}) |
||||||
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID}) |
||||||
|
|
||||||
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/new_pin_allowed", owner.Name, repo.Name) |
||||||
|
req := NewRequest(t, "GET", urlStr) |
||||||
|
resp := MakeRequest(t, req, http.StatusOK) |
||||||
|
|
||||||
|
var newPinsAllowed api.NewIssuePinsAllowed |
||||||
|
DecodeJSON(t, resp, &newPinsAllowed) |
||||||
|
|
||||||
|
assert.True(t, newPinsAllowed.Issues) |
||||||
|
assert.True(t, newPinsAllowed.PullRequests) |
||||||
|
} |
||||||
Loading…
Reference in new issue