Resolve duplicate local string key related to PR comments (#32073)

A regression in #31924 caused there to be two `issues.review.comment`
keys in the English language locale file, leading to a problem when
reading PR review histories that contain comments.

This snapshot addresses this by making the newer key unique.
pull/32040/head^2
Kemal Zebari 2 months ago committed by GitHub
parent 1fede04b83
commit adea500aa0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      models/issues/review.go
  2. 2
      options/locale/locale_en-US.ini

@ -247,7 +247,7 @@ func (r *Review) TooltipContent() string {
} }
return "repo.issues.review.official" return "repo.issues.review.official"
case ReviewTypeComment: case ReviewTypeComment:
return "repo.issues.review.comment" return "repo.issues.review.commented"
case ReviewTypeReject: case ReviewTypeReject:
return "repo.issues.review.rejected" return "repo.issues.review.rejected"
case ReviewTypeRequest: case ReviewTypeRequest:

@ -1757,7 +1757,7 @@ issues.review.hide_resolved = Hide resolved
issues.review.resolve_conversation = Resolve conversation issues.review.resolve_conversation = Resolve conversation
issues.review.un_resolve_conversation = Unresolve conversation issues.review.un_resolve_conversation = Unresolve conversation
issues.review.resolved_by = marked this conversation as resolved issues.review.resolved_by = marked this conversation as resolved
issues.review.comment = Comment issues.review.commented = Comment
issues.review.official = Approved issues.review.official = Approved
issues.review.requested = Review pending issues.review.requested = Review pending
issues.review.rejected = Changes requested issues.review.rejected = Changes requested

Loading…
Cancel
Save