mirror of https://github.com/go-gitea/gitea
Add some tests to clarify the "must-change-password" behavior (#30693)
Follow #30472: When a user is created by command line `./gitea admin user create`: Old behavior before #30472: the first user (admin or non-admin) doesn't need to change password. Revert to the old behavior before #30472pull/30712/head^2
parent
dd301cae1c
commit
d3cdef88ad
@ -0,0 +1,44 @@ |
|||||||
|
// Copyright 2023 The Gitea Authors. All rights reserved.
|
||||||
|
// SPDX-License-Identifier: MIT
|
||||||
|
|
||||||
|
package cmd |
||||||
|
|
||||||
|
import ( |
||||||
|
"fmt" |
||||||
|
"strings" |
||||||
|
"testing" |
||||||
|
|
||||||
|
"code.gitea.io/gitea/models/db" |
||||||
|
"code.gitea.io/gitea/models/unittest" |
||||||
|
user_model "code.gitea.io/gitea/models/user" |
||||||
|
|
||||||
|
"github.com/stretchr/testify/assert" |
||||||
|
) |
||||||
|
|
||||||
|
func TestAdminUserCreate(t *testing.T) { |
||||||
|
app := NewMainApp(AppVersion{}) |
||||||
|
|
||||||
|
reset := func() { |
||||||
|
assert.NoError(t, db.TruncateBeans(db.DefaultContext, &user_model.User{})) |
||||||
|
assert.NoError(t, db.TruncateBeans(db.DefaultContext, &user_model.EmailAddress{})) |
||||||
|
} |
||||||
|
|
||||||
|
type createCheck struct{ IsAdmin, MustChangePassword bool } |
||||||
|
createUser := func(name, args string) createCheck { |
||||||
|
assert.NoError(t, app.Run(strings.Fields(fmt.Sprintf("./gitea admin user create --username %s --email %s@gitea.local %s --password foobar", name, name, args)))) |
||||||
|
u := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: name}) |
||||||
|
return createCheck{u.IsAdmin, u.MustChangePassword} |
||||||
|
} |
||||||
|
reset() |
||||||
|
assert.Equal(t, createCheck{IsAdmin: false, MustChangePassword: false}, createUser("u", ""), "first non-admin user doesn't need to change password") |
||||||
|
|
||||||
|
reset() |
||||||
|
assert.Equal(t, createCheck{IsAdmin: true, MustChangePassword: false}, createUser("u", "--admin"), "first admin user doesn't need to change password") |
||||||
|
|
||||||
|
reset() |
||||||
|
assert.Equal(t, createCheck{IsAdmin: true, MustChangePassword: true}, createUser("u", "--admin --must-change-password")) |
||||||
|
assert.Equal(t, createCheck{IsAdmin: true, MustChangePassword: true}, createUser("u2", "--admin")) |
||||||
|
assert.Equal(t, createCheck{IsAdmin: true, MustChangePassword: false}, createUser("u3", "--admin --must-change-password=false")) |
||||||
|
assert.Equal(t, createCheck{IsAdmin: false, MustChangePassword: true}, createUser("u4", "")) |
||||||
|
assert.Equal(t, createCheck{IsAdmin: false, MustChangePassword: false}, createUser("u5", "--must-change-password=false")) |
||||||
|
} |
Loading…
Reference in new issue