Add pubdate for repository rss and add some tests (#33411)

Fix #33291
pull/33401/head^2
Lunny Xiao 4 days ago committed by GitHub
parent 6ca91f555a
commit dcd3014567
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 1
      routers/web/feed/branch.go
  2. 1
      routers/web/feed/file.go
  3. 35
      tests/integration/feed_repo_test.go
  4. 25
      tests/integration/feed_user_test.go

@ -43,6 +43,7 @@ func ShowBranchFeed(ctx *context.Context, repo *repo.Repository, formatType stri
}, },
Description: commit.Message(), Description: commit.Message(),
Content: commit.Message(), Content: commit.Message(),
Created: commit.Committer.When,
}) })
} }

@ -55,6 +55,7 @@ func ShowFileFeed(ctx *context.Context, repo *repo.Repository, formatType string
}, },
Description: commit.Message(), Description: commit.Message(),
Content: commit.Message(), Content: commit.Message(),
Created: commit.Committer.When,
}) })
} }

@ -0,0 +1,35 @@
// Copyright 2025 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT
package integration
import (
"encoding/xml"
"net/http"
"testing"
"code.gitea.io/gitea/tests"
"github.com/stretchr/testify/assert"
)
func TestFeedRepo(t *testing.T) {
t.Run("RSS", func(t *testing.T) {
defer tests.PrepareTestEnv(t)()
req := NewRequest(t, "GET", "/user2/repo1.rss")
resp := MakeRequest(t, req, http.StatusOK)
data := resp.Body.String()
assert.Contains(t, data, `<rss version="2.0"`)
var rss RSS
err := xml.Unmarshal(resp.Body.Bytes(), &rss)
assert.NoError(t, err)
assert.Contains(t, rss.Channel.Link, "/user2/repo1")
assert.NotEmpty(t, rss.Channel.PubDate)
assert.Len(t, rss.Channel.Items, 1)
assert.EqualValues(t, "issue5", rss.Channel.Items[0].Description)
assert.NotEmpty(t, rss.Channel.Items[0].PubDate)
})
}

@ -4,6 +4,7 @@
package integration package integration
import ( import (
"encoding/xml"
"net/http" "net/http"
"testing" "testing"
@ -12,7 +13,23 @@ import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
func TestFeed(t *testing.T) { // RSS is a struct to unmarshal RSS feeds test only
type RSS struct {
Channel struct {
Title string `xml:"title"`
Link string `xml:"link"`
Description string `xml:"description"`
PubDate string `xml:"pubDate"`
Items []struct {
Title string `xml:"title"`
Link string `xml:"link"`
Description string `xml:"description"`
PubDate string `xml:"pubDate"`
} `xml:"item"`
} `xml:"channel"`
}
func TestFeedUser(t *testing.T) {
t.Run("User", func(t *testing.T) { t.Run("User", func(t *testing.T) {
t.Run("Atom", func(t *testing.T) { t.Run("Atom", func(t *testing.T) {
defer tests.PrepareTestEnv(t)() defer tests.PrepareTestEnv(t)()
@ -32,6 +49,12 @@ func TestFeed(t *testing.T) {
data := resp.Body.String() data := resp.Body.String()
assert.Contains(t, data, `<rss version="2.0"`) assert.Contains(t, data, `<rss version="2.0"`)
var rss RSS
err := xml.Unmarshal(resp.Body.Bytes(), &rss)
assert.NoError(t, err)
assert.Contains(t, rss.Channel.Link, "/user2")
assert.NotEmpty(t, rss.Channel.PubDate)
}) })
}) })
} }
Loading…
Cancel
Save