Escape the commit message on issues update (#6901) (#6902)

pull/6925/head^2
zeripath 6 years ago committed by GitHub
parent c8fc7fce4a
commit ebb8fa610c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      models/action.go

@ -7,6 +7,7 @@ package models
import ( import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"html"
"path" "path"
"regexp" "regexp"
"strconv" "strconv"
@ -532,7 +533,7 @@ func UpdateIssuesCommit(doer *User, repo *Repository, commits []*PushCommit, bra
} }
refMarked[issue.ID] = true refMarked[issue.ID] = true
message := fmt.Sprintf(`<a href="%s/commit/%s">%s</a>`, repo.Link(), c.Sha1, c.Message) message := fmt.Sprintf(`<a href="%s/commit/%s">%s</a>`, repo.Link(), c.Sha1, html.EscapeString(c.Message))
if err = CreateRefComment(doer, repo, issue, message, c.Sha1); err != nil { if err = CreateRefComment(doer, repo, issue, message, c.Sha1); err != nil {
return err return err
} }

Loading…
Cancel
Save