Make a distinction between `active` and `selected` in the issue author dropdown (#30207)

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
pull/30198/head^2
Yarden Shoham 8 months ago committed by GitHub
parent 44dd6d6927
commit f8fbaaf26f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      web_src/js/features/repo-issue-list.js

@ -149,7 +149,9 @@ function initRepoIssueListAuthorDropdown() {
$searchDropdown.dropdown('refresh'); $searchDropdown.dropdown('refresh');
// defer our selection to the next tick, because dropdown will set the selection item after this `menu` function // defer our selection to the next tick, because dropdown will set the selection item after this `menu` function
setTimeout(() => { setTimeout(() => {
menu.querySelector('.item.active, .item.selected')?.classList.remove('active', 'selected'); for (const el of menu.querySelectorAll('.item.active, .item.selected')) {
el.classList.remove('active', 'selected');
}
menu.querySelector(`.item[data-value="${selectedUserId}"]`)?.classList.add('selected'); menu.querySelector(`.item[data-value="${selectedUserId}"]`)?.classList.add('selected');
}, 0); }, 0);
}; };

Loading…
Cancel
Save