126 Commits (7960ba7e2bbe2eb6f98f6d99f2ce105468cdf56e)

Author	SHA1	Message	Date
JakobDev	f91dbbba98	Next round of `db.DefaultContext` refactor (#27089) ... Part of #27065	1 year ago
JakobDev	c548dde205	More refactoring of `db.DefaultContext` (#27083) ... Next step of #27065	1 year ago
JakobDev	76659b1114	Reduce usage of `db.DefaultContext` (#27073) ... Part of #27065 This reduces the usage of `db.DefaultContext`. I think I've got enough files for the first PR. When this is merged, I will continue working on this. Considering how many files this PR affect, I hope it won't take to long to merge, so I don't end up in the merge conflict hell. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Lunny Xiao	4f32abaf94	move repository deletion to service layer (#26948) ... Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Nanguan Lin	1ee4882b88	Fix the missing repo count (#26942) ... The commit (958d148043) forgot two pages 😝  BTW, the `leave` button is in a weird position	1 year ago
JakobDev	958d148043	Show always repo count in header (#26842) ... A few pages don't load the repo count of an user/org, so it is not shown in the header. This happens mostly on org pages, but the package settings applies to the user page as well. Before:  After:  Seen on #26826 Regression of #25928	1 year ago
yp05327	0850be6750	Fix the display of org level badges (#26504) ... Follow #24654 #22705 #24232 In some pages we still have missing badges, for example:   	1 year ago
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859) ... Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	1 year ago
wxiaoguang	e8b990999f	Make "link-action" backend code respond correct JSON content (#26680) ... Otherwise the `link-action` JS code couldn't parse the response. Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
yp05327	7f8028e5a1	Fix display problems of members and teams unit (#26363) ... Fix: - display member count and team count in the menu bar  - Also display member unit in the menu bar if there are no hidden members in public org  - hidden member board when there's no seeable members. In this org, we only have hidden members:  We will hidden the member board when doer is not the member of this org  Before:  If you click the number in the members board, you will access the members page, which is not expected.  --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
puni9869	cafce3b4b5	Allow to archive labels (#26478) ... ## Archived labels This adds the structure to allow for archived labels. Archived labels are, just like closed milestones or projects, a medium to hide information without deleting it. It is especially useful if there are outdated labels that should no longer be used without deleting the label entirely. ## Changes 1. UI and API have been equipped with the support to mark a label as archived 2. The time when a label has been archived will be stored in the DB ## Outsourced for the future There's no special handling for archived labels at the moment. This will be done in the future. ## Screenshots   Part of https://github.com/go-gitea/gitea/issues/25237 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
Denys Konovalov	ab78c39e41	Refactor project templates (#26448) ... This PR refactors a bunch of projects-related code, mostly the templates. The following things were done: - rename boards to columns in frontend code - use the new `ctx.Locale.Tr` method - cleanup template, remove useless newlines, classes, comments - merge org-/user and repo level project template together - move "new column" button into project toolbar - move issue card (shared by projects and pinned issues) to shared template, remove useless duplicated styles - add search function to projects (to make the layout more similar to milestones list where it is inherited from 😆) - maybe more changes I forgot I've done 😆 Closes #24893 After:    --------- Co-authored-by: silverwind <me@silverwind.io>	1 year ago
yp05327	9fc68b680f	Fix 404 error when remove self from an organization (#26362) ... Same to #24322 Not only `leave` action but also `remove` action should check whether user still belongs to the org.	1 year ago
JakobDev	f3fbb7c67d	Count only visible repos on profile (#25928) ... Fixes #25914	1 year ago
wxiaoguang	dcd3a63128	Move web JSON functions to web context and simplify code (#26132) ... The JSONRedirect/JSONOK/JSONError functions were put into "Base" context incorrectly, it would cause abuse. Actually, they are for "web context" only, so, move them to the correct place. And by the way, use them to simplify old code: +75 -196	1 year ago
JakobDev	6598d0291c	Allow Organisations to have a E-Mail (#25082) ... Resolves #25057 This adds a E-Mail field to Organisations. The E-Mail is just shown on the Profile when it is visited by a logged in User. The E-mail is not used for something else. **Screenshots:**   --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: Denys Konovalov <privat@denyskon.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
hiifong	4628aa5251	fix incorrect repo url when changed the case of ownername (#25733) ... When only the case of the username changes and the new username is consistent with the lowercase username of the old user name, update the owner name of the repo, and keep the original logic consistent with other conditions. example: your username is `gitea`, lowercase username is `gitea`,repo url is `.../gitea/{repo}`, you changed username to `Gitea` or `GiTea` or other, but the lowercase username is still `gitea`, the repo url is still `.../gitea/{repo}`. this pr fixed it,keep username and repo url consistent. Before:   After:  	1 year ago
yp05327	8b89563bf1	Fix empty project displayed in issue sidebar (#25802) ... Before:  After:  This issue comes from the change in #25468. `LoadProject` will always return at least one record, so we use `ProjectID` to check whether an issue is linked to a project in the old code. As other `issue.LoadXXX` functions, we need to check the return value from `xorm.Session.Get`. In recent unit tests, we only test `issueList.LoadAttributes()` but don't test `issue.LoadAttributes()`. So I added a new test for `issue.LoadAttributes()` in this PR. --------- Co-authored-by: Denys Konovalov <privat@denyskon.de>	1 year ago
yp05327	44572e9243	Fix incorrect oldest sort in project list (#25806) ... sort type `oldest` should be `Asc`. Added a test for this.	1 year ago
puni9869	2af30f715e	Fix inconsistent user profile layout across tabs (#25625) ... Fix ::User Profile Page Project Tab Have Inconsistent Layout and Style Added the big_avator for consistency in the all header_items tabs. Fixes: #24871 > ### Description > in the user profile page the `Packages` and `Projects` tab have small icons for user but other tabs have bigger profile picture with user info: > > ### Screenshots > ### **For Packages And Projects:** >  > > ### **For Other Tabs:** >  > ## Before  ## After changes Project View <img width="1394" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/95d181d7-8e61-496d-9899-7b825c91ad56"> Packages View <img width="1378" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/7f5fd60f-6b18-4fa8-8c56-7b0d45d1a610"> ## Org view for projects page <img width="1385" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/6400dc89-a5ae-4f0a-831b-5b6efa020d89"> ## Org view for packages page <img width="1387" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/4e1e9ffe-1e4b-4334-8657-de11b5fd31d0"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	1 year ago
silverwind	88f835192d	Replace `interface{}` with `any` (#25686) ... Result of running `perl -p -i -e 's#interface\{\}#any#g' **/*` and `make fmt`. Basically the same [as golang did](2580d0e08d).	1 year ago
Zettat123	ff140d4050	Fix the nil pointer when assigning issues to projects (#25665) ... Fixes #25649 Caused by #25468	1 year ago
Lunny Xiao	083818cb85	Improve loadprojects for issue list (#25468)	1 year ago
wxiaoguang	4e2f1ee58d	Refactor web package and context package (#25298) ... 1. The "web" package shouldn't depends on "modules/context" package, instead, let each "web context" register themselves to the "web" package. 2. The old Init/Free doesn't make sense, so simplify it * The ctx in "Init(ctx)" is never used, and shouldn't be used that way * The "Free" is never called and shouldn't be called because the SSPI instance is shared --------- Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
delvh	bf27fc3596	Merge `new project` templates into one (#24985) ... Additionally simplify the `new project` template slightly. Review hint: Disable whitespace changes. <details><summary>Before</summary> ## New repo project  ## Edit repo project  ## New user/org project  ## Edit user/org project  </details> <details><summary>After</summary> ## New repo project  ## Edit repo project  ## New user/org project  ## Edit user/org project  </details> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
Lunny Xiao	c59a057297	Refactor rename user and rename organization (#24052) ... This PR is a refactor at the beginning. And now it did 4 things. - [x] Move renaming organizaiton and user logics into services layer and merged as one function - [x] Support rename a user capitalization only. For example, rename the user from `Lunny` to `lunny`. We just need to change one table `user` and others should not be touched. - [x] Before this PR, some renaming were missed like `agit` - [x] Fix bug the API reutrned from `http.StatusNoContent` to `http.StatusOK`	2 years ago
yp05327	b3af7484bc	Fix missing badges in org settings page (#24654) ... Improve #24232 Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
yp05327	f5b70a029c	Fix close org projects (#24588) ... A part of #22865 We can not close org projects now. This PR will fix it.	2 years ago
Lunny Xiao	3ee7f27341	Revert "Prevent a user with a different email from accepting the team invite" (#24531) ... Reverts go-gitea/gitea#24491	2 years ago
Jack Hay	402df1d6b4	Prevent a user with a different email from accepting the team invite (#24491) ... ## Changes - Fixes the case where a logged in user can accept an email invitation even if their email address does not match the address in the invitation	2 years ago
yp05327	cc64a92560	Add follow organization and fix the logic of following page (#24345) ...   Maybe we can fix user card tmpl in #24319? Or maybe a list is better here  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
Hester Gong	63a401ac40	Move secrets and runners settings to actions settings (#24200) ... This PR moves the secrets and runners settings to actions settings on all settings(repo,org,user,admin) levels. After this PR, if [ENABLED](5e7543fcf4/custom/conf/app.example.ini (L2604)) inside `app.ini` under `[actions]` is set to `false`, the "Actions" tab (including runners management and secrets management) will not be shown. After, the settings under actions settings for each level: 1. Admin Level "Runners Management" <img width="1437" alt="Screen Shot 2023-04-26 at 14 34 20" src="https://user-images.githubusercontent.com/17645053/234489731-15822d21-38e1-4560-8bbe-69f122376abc.png"> 2. User Level "Secrets Management" <img width="1427" alt="Screen Shot 2023-04-26 at 14 34 30" src="https://user-images.githubusercontent.com/17645053/234489795-68c9c0cb-24f8-4f09-95c6-458ab914c313.png"> 3. Repo and Organization Levels "Runners Management" and "Secrets Management" Org: <img width="1437" alt="Screen Shot 2023-04-26 at 14 35 07" src="https://user-images.githubusercontent.com/17645053/234489996-f3af5ebb-d354-46ca-9087-a0b586845281.png"> <img width="1433" alt="Screen Shot 2023-04-26 at 14 35 14" src="https://user-images.githubusercontent.com/17645053/234490004-3abf8fed-81fd-4ce2-837a-935dade1793d.png"> Repo: <img width="1419" alt="Screen Shot 2023-04-26 at 14 34 50" src="https://user-images.githubusercontent.com/17645053/234489904-80c11038-4b58-462c-9d0b-8b7cf70bc2b3.png"> <img width="1430" alt="Screen Shot 2023-04-26 at 14 34 57" src="https://user-images.githubusercontent.com/17645053/234489918-4e8d1fe2-9bcd-4d8a-96c1-238a8088d92e.png"> It also finished these tasks : - [x] rename routers function "runners" to "actions", and refactor related file names - [x] check and modify part of the runners related functions to match their name - [x] Fix backend check caused by fmt check --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2 years ago
yp05327	df9a62b5f9	Fix 404 error when leaving the last private org team (#24322) ... If the user only belongs to one org team and the org is private, leaving the org team will redirect to `ctx.Org.OrgLink + "/teams/"` which is inaccessible. So we need to check whether the user still belongs to the org.	2 years ago
KN4CK3R	b3e849d1d6	Only delete secrets belonging to its owner (#24284)	2 years ago
Jakob	136d7492ff	Add missing badges in user profile for /projects and /packages (#24232) ... - Implement fix for user and organization page - Add necessary ctx.Data When switching tabs on `user profile page` the badges are shown for `/gitea_user?tab=stars`, `/gitea_user?tab=activity` and missing under `gitea_user/-/projects` and `gitea_user/-/packages` This was added for users and organizations. Before:  After:  Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
wxiaoguang	70fc47a22a	Fix unclear "Owner" concept (#24233) ... Some user/org pages use `Owner` variable. It's an incorrect concept since year 2016: what is a user's owner? Actually, new code is right: use `ContextUser`. This PR cleans all legacy "Owner" variables. ## Screenshots for related pages and test results All pages are as before: ### `web/org/home.go`  ### `web/user/profile.go`  ### `web/user/setting/profile.go` 	2 years ago
yp05327	f30cc9faa9	Add unset default project column (#23531) ... Close: https://github.com/go-gitea/gitea/issues/23401	2 years ago
yp05327	b7221bec34	Fix admin team access mode value in team_unit table (#24012) ... Same as https://github.com/go-gitea/gitea/pull/23675 Feedback: https://github.com/go-gitea/gitea/pull/23879#issuecomment-1500923636	2 years ago
Hester Gong	6a4be2cb6a	Add cardtype to org/user level project on creation, edit and view (#24043) ... Part of #23318 The way to fix the missing cardtype for user/org level projects in this PR is to port the cardtype related part from #22112 to org/user level projects' template and router functions. Before: <img width="1135" alt="截屏2023-04-11 13 55 49" src="https://user-images.githubusercontent.com/17645053/231069068-ba897129-ae90-4aa0-9b0f-468bf5c65375.png"> <img width="1131" alt="截屏2023-04-11 13 55 59" src="https://user-images.githubusercontent.com/17645053/231069084-279f6681-5a10-42da-b5a8-2b0ba47c7078.png"> After: Create <img width="835" alt="截屏2023-04-11 13 27 16" src="https://user-images.githubusercontent.com/17645053/231064445-0d6e12bd-5725-48db-a102-80e7472757c2.png"> Edit <img width="852" alt="截屏2023-04-11 13 27 05" src="https://user-images.githubusercontent.com/17645053/231064503-c70525cd-1038-43ec-8d93-8b8d95d183d4.png"> View <img width="1329" alt="截屏2023-04-11 13 26 56" src="https://user-images.githubusercontent.com/17645053/231064529-26023c85-698b-4b2e-af02-45f9820c77ec.png"> Co-authored-by: Giteabot <teabot@gitea.io>	2 years ago
wxiaoguang	4e33481357	Make label templates have consistent behavior and priority (#23749) ... Fix https://github.com/go-gitea/gitea/issues/23715 Other related PRs: * #23717 * #23716 * #23719 This PR is different from others, it tries to resolve the problem fundamentally (and brings more benefits) Although it looks like some more lines are added, actually many new lines are for tests. ---- Before, the code was just "guessing" the file type and try to parse them. <details>  </details> This PR: * Always remember the original option file names, and always use correct parser for them. * Another benefit is that we can sort the Label Templates now (before there was a map, its key order is undefined) 	2 years ago
yp05327	8bc8ca1953	Improve GetBoards and getDefaultBoard (#22981) ... Change `GetBoards(ctx context.Context, projectID int64)` to `(p *Project) GetBoards(ctx context.Context) (BoardList, error)` `getDefaultBoard` is same.	2 years ago
wxiaoguang	5cc0801de9	Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) ... The first step of the plan * #23290 Thanks to @silverwind for the first try in #15394 . Close #10729 and a lot of related issues. The EasyMDE is not removed, now it works as a fallback, users can switch between these two editors. Editor list: * Issue / PR comment * Issue / PR comment edit * Issue / PR comment quote reply * PR diff view, inline comment * PR diff view, inline comment edit * PR diff view, inline comment quote reply * Release editor * Wiki editor Some editors have attached dropzone Screenshots: <details>     </details> --------- Co-authored-by: silverwind <me@silverwind.io>	2 years ago
sillyguodong	d02e83a2c3	Fix cancel button in the page of project edit not work (#23655) ... Before, in project edit page, the cancel button is not work. https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov 1. The wrong classname `cancel` was added to the `<a>` tag. That classname caused the default click event of `<a>` tag to be cancelled. Because we have the following settings in the global. So I remove the classname `cancel`. 9be90a5875/web_src/js/features/common-global.js (L325-L327) 2. Another change is that page will redirect to the previous page. https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov	2 years ago
yp05327	8e45fcb63a	Do not store user projects as organization projects (#23353) ... A part of https://github.com/go-gitea/gitea/pull/22865 At first, I think we do not need 3 ProjectTypes, as we can check user type, but it seems that it is not database friendly. --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de>	2 years ago
techknowlogick	03591f0f95	add user rename endpoint to admin api (#22789) ... this is a simple endpoint that adds the ability to rename users to the admin API. Note: this is not in a mergeable state. It would be better if this was handled by a PATCH/POST to the /api/v1/admin/users/{username} endpoint and the username is modified. --------- Co-authored-by: Jason Song <i@wolfogre.com>	2 years ago
yp05327	cf29ee6dd2	Add missing tabs to org projects page (#22705) ... Fixes https://github.com/go-gitea/gitea/issues/22676 Context Data `IsOrganizationMember` and `IsOrganizationOwner` is used to control the visibility of `people` and `team` tab. 2871ea0809/templates/org/menu.tmpl (L19-L40) And because of the reuse of user projects page, User Context is changed to Organization Context. But the value of `IsOrganizationMember` and `IsOrganizationOwner` are not being given. I reused func `HandleOrgAssignment` to add them to the ctx, but may have some unnecessary variables, idk whether it is ok. I found there is a missing `PageIsViewProjects` at create project page.	2 years ago
KN4CK3R	2173f14708	Add user webhooks (#21563) ... Currently we can add webhooks for organizations but not for users. This PR adds the latter. You can access it from the current users settings. 	2 years ago
yp05327	e6df743eca	Rename `canWriteUnit` to `canWriteProjects` (#23386) ... A part of https://github.com/go-gitea/gitea/pull/22865	2 years ago
yp05327	689770c928	Fix incorrect NotFound conditions in org/projects.go (#23384) ... A part of https://github.com/go-gitea/gitea/pull/22865 user/org project's `RepoID` is always 0, we need to check `OwnerID`	2 years ago
yp05327	e52ac62d8e	Redirect to project again after editing it (#23326) ... A part of https://github.com/go-gitea/gitea/pull/22865 We have edit buttons in projects list page and project view page. But after user edit a project, it will always redirect to the projects list page.	2 years ago