858 Commits (ec1feedbf582b05b6a5e8c59fb2457f25d053ba2)

Author	SHA1	Message	Date
yp05327	e88377470a	Fix project counter in organization/individual profile (#28068) ... Fix #28052 Before:   After:  	1 year ago
yp05327	089ac06969	Improve profile for Organizations (#27982) ... Fixes some problems in #27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In #26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: https://github.com/go-gitea/gitea/pull/27955#issuecomment-1803178239 But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>	1 year ago
Lunny Xiao	61ff91f960	Fix the wrong oauth2 name (#27993) ... Fix #27989 Regression #27798	1 year ago
silverwind	6447b3e6b2	Use flex-container on user dashboard (#27956) ... Same as https://github.com/go-gitea/gitea/pull/26046 but for user dashboard, the sidebar got a bit smaller and there is less padding between sections. <img width="1265" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/0c8d2faa-03ec-4515-a4f2-0a106ef2a928">	1 year ago
Lunny Xiao	1bf5527eac	Refactor Find Sources and fix bug when view a user who belongs to an unactive auth source (#27798) ... The steps to reproduce it. First, create a new oauth2 source. Then, a user login with this oauth2 source. Disable the oauth2 source. Visit users -> settings -> security, 500 will be displayed. This is because this page only load active Oauth2 sources but not all Oauth2 sources.	1 year ago
yp05327	0e021cd33e	Fix display member unit in the menu bar if there are no hidden members in public org (#27795) ... Follow #26363. I missed that org templates also using `templates/user/overview/header.tmpl`. You can confirm this problem in https://gitea.com/gitea/-/projects with anonymous access. Before: (no login)  After: 	1 year ago
Gerd Katzenbeisser	31f8880bc2	Show placeholder email in privacy popup (#27770) ... This PR will show the _noreply_ address in the privacy popup _keep_email_private_popup_. I had to look into the source code to figure out which E-Mail Adress I had to use on gitea.com to hide it from public access. According to the contribution guidelines I only updated the en-US translation file. Co-authored-by: Hakito <hakito@git.example.com>	1 year ago
JakobDev	328da56a28	Don't show Link to TOTP if not set up (#27585)	1 year ago
Lunny Xiao	fb74fe99d6	Fix template bug (#27581) ... Regression from #27414	1 year ago
JakobDev	ebe803e514	Penultimate round of `db.DefaultContext` refactor (#27414) ... Part of #27065 --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	1 year ago
silverwind	3b139fa3a3	Improve feed icons and feed merge text color (#27498) ... 1. Improve various feed icons 2. Fix merge message color <img width="763" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/3f5bcb23-6d90-4c63-85f2-46bd7e1c96d6"> <img width="769" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/466c37b4-e2f4-42bb-922d-b86596cdc6d0"> Fixes: https://github.com/go-gitea/gitea/issues/27495 Continues: https://github.com/go-gitea/gitea/pull/27356	1 year ago
CaiCandong	6b65c41ebf	Fix missing ctx for GetRepoLink in dashboard (#27372) ... As title Fix #27369 Regression of #27265	1 year ago
silverwind	83f571628d	Feed UI Improvements (#27356) ... Various improvements related to feeds: - Fix markdown rendering - Increase font size from 13px to default 14px via `flex-item` - Add style to hashes - Move the timestamp to title line. I realize it's not optimal for translation, we may need to change all these translations Before: <img width="768" alt="Screenshot 2023-09-29 at 22 52 58" src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c"> After: <img width="781" alt="Screenshot 2023-09-29 at 22 58 09" src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8">	1 year ago
JakobDev	cf0df023be	More `db.DefaultContext` refactor (#27265) ... Part of #27065 This PR touches functions used in templates. As templates are not static typed, errors are harder to find, but I hope I catch it all. I think some tests from other persons do not hurt.	1 year ago
yp05327	5ef5a0ade6	Fix divider in subscription page (#27298) ... the divider should always display in the subscription page. Co-authored-by: techknowlogick <techknowlogick@gitea.com>	1 year ago
wxiaoguang	939d410a93	Add missing IconHTML size (#27269) ... Fix #27223 Regression of #27122	1 year ago
wxiaoguang	93bd4351bf	Fix more "locale" usages (#27259)	1 year ago
delvh	7960ba7e2b	Always use `ctx.Locale.Tr` inside templates (#27231)	1 year ago
Denys Konovalov	2325fe777d	cleanup locale function usage (#27227)	1 year ago
wxiaoguang	1f026bcb7e	Fix dropdown icon position (#27175) ... According to https://fomantic-ui.com/modules/dropdown.html and our "devtest" page, many dropdown elements has incorrect "icon" position. This PR fixes all of them. Fix #27173	1 year ago
silverwind	1b1c55f73f	Increase auth provider icon size on login page (#27122) ... Before, 20px: <img width="474" alt="Screenshot 2023-09-19 at 00 10 05" src="https://github.com/go-gitea/gitea/assets/115237/4bed4edb-219d-4844-9d3c-0d747033b09f"> After, 28px: <img width="576" alt="Screenshot 2023-09-19 at 00 20 40" src="https://github.com/go-gitea/gitea/assets/115237/f482ac09-38ae-4c84-80d9-0bd39b7f9772"> Dropdown in account settings is unchanged at 20px: <img width="157" alt="Screenshot 2023-09-19 at 00 09 11" src="https://github.com/go-gitea/gitea/assets/115237/9c998cdf-eeed-4118-9262-664faaa56092"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	8099238618	Change green buttons to primary color (#27099) ... I think it's better if the primary actions have primary color instead of green which fits better into the overall single-color UI design. This PR currently replaces every green button with primary: <img width="141" alt="Screenshot 2023-09-16 at 14 07 59" src="https://github.com/go-gitea/gitea/assets/115237/843c1e50-4fb2-4ec6-84ba-0efb9472dcbe"> <img width="161" alt="Screenshot 2023-09-16 at 14 07 51" src="https://github.com/go-gitea/gitea/assets/115237/9442195a-a3b2-4a42-b262-8377d6f5c0d1"> Modal actions now use uncolored/primary instead of previous green/red colors. I also removed the box-shadow on all basic buttons: <img width="259" alt="Screenshot 2023-09-16 at 14 16 39" src="https://github.com/go-gitea/gitea/assets/115237/5beea529-127a-44b0-8d4c-afa7b034a490"> <img width="261" alt="Screenshot 2023-09-16 at 14 17 42" src="https://github.com/go-gitea/gitea/assets/115237/4757f7b2-4d46-49bc-a797-38bb28437b88"> The change currently includes the "Merge PR" button, for which we might want to make an exception to match the icon color there: <img width="442" alt="Screenshot 2023-09-16 at 14 33 53" src="https://github.com/go-gitea/gitea/assets/115237/993ac1a5-c94d-4895-b76c-0d872181a70b">	1 year ago
Dmitry Sharshakov	63b53af933	Show OpenID Connect and OAuth on signup page (#20242) ... Fix #19809 --------- Signed-off-by: Dmitry Sharshakov <d3dx12.xx@gmail.com> Co-authored-by: jackHay22 <jack@allspice.io>	1 year ago
wxiaoguang	ffa4949eaa	Improve flex list UI (#26970) ... 1. There is already `gt-ac`, so no need to introduce `flex-item-center` 2. The `flex-item-baseline` and `.flex-item-icon svg { margin-top: 1px }` seem to be a tricky patch, they don't resolve the root problem, and still cause misalignment in some cases. * The root problem is: the "icon" needs to align with the sibling "title" * So, make the "icon" and the "title" both have the same height 3. `flex-text-inline` could only be used if the element is really "inline", otherwise its `vertical-align` would make the box size change. In most cases, `flex-text-block` is good enough.  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
CaiCandong	30cea70dd8	Refactor dashboard/feed.tmpl (#26956) ... - ~~Refactor `ActionType` to `models/activities/action_type.go`~~ - Replace the magic number in `feed.tmlp` with `InAction`	1 year ago
wxiaoguang	419003adb2	Improve SSH Key / GPG Key / Deploy Key UI (#26949) ... 1. In many cases, the `flex-list` has previous and next `gt-hidden` siblings, so relax the CSS selector to remove all ".segument .flex-list" paddings. 2. Make the "Add key" button can toggle 3. Move help message into the related segment(panel). Otherwise users would misread the message, eg: the SSH help seemed for GPG because they are so near 4. Move modal element into the segment element, otherwise it affects the layout	1 year ago
Kerwin Bryant	9b0743ae33	Extract common code to new template (#26933) ... Same as #26903	1 year ago
Kerwin Bryant	65588b732c	Extract common code to new template (#26903) ... I noticed that the code of several new webhook pages is highly repetitive, so I pulled out the common parts to a new template, unified reference, unified maintenance --------- Co-authored-by: KN4CK3R <admin@oldschoolhack.me>	1 year ago
silverwind	a625f3a761	Enable djlint H008 and fix issues (#26869) ... Enable `H008 | Attributes should be double quoted` and fix issues.	1 year ago
Jack Hay	9881b8a4e2	Add more descriptive error on forgot password page (#26848) ... ## Changes - Forces flashed error to render immediately when forgot password code is incorrect or has expired. - Adds a link back to the `forgot_password` page so that the user can restart the process (in the event that their link has expired)	1 year ago
silverwind	9b76df53dc	Minor dashboard tweaks, fix flex-list margins (#26829) ... Some small dashboard tweaks: - Remove margin-bottom from divider so first item does not appear to have un-equal margins - Restore previous icon color - Add slight margin-right to icon Before: <img width="783" alt="Screenshot 2023-08-31 at 00 10 28" src="https://github.com/go-gitea/gitea/assets/115237/b75f70d7-8704-4afb-866d-fea0484c52d4"> After: <img width="783" alt="Screenshot 2023-08-31 at 00 10 08" src="https://github.com/go-gitea/gitea/assets/115237/50ed0c47-6f7c-449e-a054-13091369d43f"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
wxiaoguang	19a1e1b20e	Remove polluted `.ui.right` (#26825) ... Each change is tested manually line by line. There are too many changes so I can't share dozens of screenshots. In short: 1. `ui right` could be still used in `ui top attached header`, because there is a special case. 2. A lot of `ui right` are just no-op, so they can be removed safely. 3. Some of the `ui right` should be replaced by `gt-float-right` (to avoid breaking, leave them to the future). 4. A few of the `ui right` could be rewritten by flex.	1 year ago
Lunny Xiao	476b9d1589	Use docs.gitea.com instead of docs.gitea.io (#26739)	1 year ago
wxiaoguang	4fdb09de58	Fix incorrect "tabindex" attributes (#26733) ... Fix #26731 Almost all "tabindex" in code are incorrect. 1. All "input/button" by default are focusable, so no need to use "tabindex=0" 2. All "div/span" by default are not focusable, so no need to use "tabindex=-1" 3. All "dropdown" are focusable by framework, so no need to use "tabindex" 4. Some tabindex values are incorrect (eg: `new_form.tmpl`), so remove them Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
wxiaoguang	576644d815	Simplify helper CSS classes and avoid abuse (#26728) ... Removed CSS helper classes (some of them are not useful while some of them are abused often) * `gt-db`: in most cases it could be replaced by `gt-df` and the flex layout should be encouraged. Other cases: either it does need the `gt-df` (eg: by using `div` directly) or it is an abuse (eg: the warning message in a form) * `gt-di`: it doesn't seem useful, or it could be replaced by `gt-dib` in most cases. * `gt-dif`: not useful, it could be replaced by `flex-text-inline` or `gt-df` * `gt-js`: never used * All `<i class="icon gt-df gt-ac gt-jc">` could be written as `<i class="icon">` ## Some UI samples ### Admin Notice  ### Admin Stacktrace  ### Org Home  ### Org Team Repo  ### Release List  ### User Setting Application Token Scope  Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
silverwind	8b5c081d76	Remove fomantic loader module (#26670) ... Replace Fomantic `loader` CSS module with our existing `is-loading` spinner. Only three places in the UI used this module, which are pictured here: imagediff: <img width="1237" alt="Screenshot 2023-08-22 at 22 18 01" src="https://github.com/go-gitea/gitea/assets/115237/b0d82531-f05e-43c6-9e5b-1bfc268c056d"> webauthn: <img width="894" alt="Screenshot 2023-08-22 at 22 05 05" src="https://github.com/go-gitea/gitea/assets/115237/7b583425-d944-474a-a57a-22a65bbd8b29"> heatmap (I removed the previous loading text, it was unreadable because it was tiny and on fast machines only visible for a fraction of a second): <img width="764" alt="Screenshot 2023-08-22 at 22 18 44" src="https://github.com/go-gitea/gitea/assets/115237/1c7472d6-3e17-4224-a992-d8c0b380cc73"> Also, heatmap container does not resize any more after loading now and previous duplicate id `user-heatmap` is gone. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
wxiaoguang	ee9e83b230	Remove incorrect CSS helper classes (#26712)	1 year ago
wxiaoguang	e8b990999f	Make "link-action" backend code respond correct JSON content (#26680) ... Otherwise the `link-action` JS code couldn't parse the response. Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
wxiaoguang	e4b2bdfbc0	More improvements for the "flex list" and the dashboard list (#26675) ... Follow #26649 and #25790 and add one more example (text truncate) in the devtest page	1 year ago
Jason Song	5db21ce7e1	Fix counting and filtering on the dashboard page for issues (#26657) ... This PR has multiple parts, and I didn't split them because it's not easy to test them separately since they are all about the dashboard page for issues. 1. Support counting issues via indexer to fix #26361 2. Fix repo selection so it also fixes #26653 3. Keep keywords in filter links. The first two are regressions of #26012. After: https://github.com/go-gitea/gitea/assets/9418365/71dfea7e-d9e2-42b6-851a-cc081435c946 Thanks to @CaiCandong for helping with some tests.	1 year ago
wxiaoguang	0731abc444	Remove avatarHTML from template helpers (#26598) ... The HTML code is more readable and more correct (it needs `"ui avatar"` class) Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
Jason Song	c179ab4236	Fix "issueReposQueryPattern does not match query" (#26556) ... Fix `https://github.com/go-gitea/gitea/pull/26545#discussion_r1295734340` --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
yp05327	9665622378	Differentiate better between user settings and admin settings (#26538) ... User settings page and admin settings page are too similar. I thinlk this will be better of using `User Settings` and `Admin Settings` as the navbar's title. Before:   After:  	1 year ago
JakobDev	f3fbb7c67d	Count only visible repos on profile (#25928) ... Fixes #25914	1 year ago
wxiaoguang	a370efc13f	Use template context function for avatar rendering (#26385) ... Introduce `AvatarUtils`, no need to pass `$.Context` to every sub-template, and simplify the template helper functions.	1 year ago
Denys Konovalov	63ab92d797	Pre-register OAuth2 applications for git credential helpers (#26291) ... This PR is an extended implementation of #25189 and builds upon the proposal by @hickford in #25653, utilizing some ideas proposed internally by @wxiaoguang. Mainly, this PR consists of a mechanism to pre-register OAuth2 applications on startup, which can be enabled or disabled by modifying the `[oauth2].DEFAULT_APPLICATIONS` parameter in app.ini. The OAuth2 applications registered this way are being marked as "locked" and neither be deleted nor edited over UI to prevent confusing/unexpected behavior. Instead, they're being removed if no longer enabled in config.  The implemented mechanism can also be used to pre-register other OAuth2 applications in the future, if wanted. Co-authored-by: hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> --------- Co-authored-by: M Hickford <mirth.hickford@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
wxiaoguang	71d253f42e	Remove unnecessary template helper DisableGravatar (#26386) ... And one "AllowedUserVisibilityModes" was missing, add it. Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
Denys Konovalov	b9baed2c74	Introduce `flex-list` & `flex-item` elements for Gitea UI (#25790) ... This PR introduces a new UI element type for Gitea called `flex-item`. It consists of a horizontal card with a leading, main and trailing part:  The idea behind it is that in Gitea UI, we have many cases where we use this kind of layout, but it is achieved in many different ways: - grid layout - `.ui.list` with additional hacky flexbox - `.ui.key.list` - looks to me like a style set originally created for ssh/gpg key list, was used in many other places - `.issue.list` - created for issue cards, used in many other places - ... This new style is based on `.issue.list`, specifically the refactoring of it done in #25750. In this PR, the new element is introduced and lots of templates are being refactored to use that style. This allows to remove a lot of page-specific css, makes many of the elements responsive or simply provides a cleaner/better-looking way to present information. A devtest section with the new style is also available. <details> <summary>Screenshots (left: before, right: after)</summary>                    </details> --------- Co-authored-by: Giteabot <teabot@gitea.io>	1 year ago
Panagiotis "Ivory" Vasilopoulos	d58c542579	Add 'Show on a map' button to Location in profile, fix layout (#26214) ... Not too important, but I think that it'd be a pretty neat touch. Also fixes some layout bugs introduced by a previous PR. --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Caesar Schinas <caesar@caesarschinas.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	1 year ago
silverwind	72363be7ca	Use shared template for webhook icons (#26242) ... Fixes: https://github.com/go-gitea/gitea/issues/26241	1 year ago