gitea

Git with a cup of tea, painless self-hosted git service Mirror for internal git.with.parts use https://git.with.parts

History

wxiaoguang f4538791f5 Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687 ) # Why this PR comes At first, I'd like to help users like #23636 (there are a lot) The unclear "Internal Server Error" is quite anonying, scare users, frustrate contributors, nobody knows what happens. So, it's always good to provide meaningful messages to end users (of course, do not leak sensitive information). When I started working on the "response message to end users", I found that the related code has a lot of technical debt. A lot of copy&paste code, unclear fields and usages. So I think it's good to make everything clear. # Tech Backgrounds Gitea has many sub-commands, some are used by admins, some are used by SSH servers or Git Hooks. Many sub-commands use "internal API" to communicate with Gitea web server. Before, Gitea server always use `StatusCode + Json "err" field` to return messages. * The CLI sub-commands: they expect to show all error related messages to site admin * The Serv/Hook sub-commands (for git clients): they could only show safe messages to end users, the error log could only be recorded by "SSHLog" to Gitea web server. In the old design, it assumes that: * If the StatusCode is 500 (in some functions), then the "err" field is error log, shouldn't be exposed to git client. * If the StatusCode is 40x, then the "err" field could be exposed. And some functions always read the "err" no matter what the StatusCode is. The old code is not strict, and it's difficult to distinguish the messages clearly and then output them correctly. # This PR To help to remove duplicate code and make everything clear, this PR introduces `ResponseExtra` and `requestJSONResp`. * `ResponseExtra` is a struct which contains "extra" information of a internal API response, including StatusCode, UserMsg, Error * `requestJSONResp` is a generic function which can be used for all cases to help to simplify the calls. * Remove all `map["err"]`, always use `private.Response{Err}` to construct error messages. * User messages and error messages are separated clearly, the `fail` and `handleCliResponseExtra` will output correct messages. * Replace all `Internal Server Error` messages with meaningful (still safe) messages. This PR saves more than 300 lines, while makes the git client messages more clear. Many gitea-serv/git-hook related essential functions are covered by tests. --------- Co-authored-by: delvh <dev.lh@web.de>		2 years ago
..
actions	Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (#22804 )	2 years ago
activitypub	Add Chef package registry (#22554 )	2 years ago
analyze	Implement FSFE REUSE for golang files (#21840 )	2 years ago
auth	Fix various bugs for "install" page (#23194 )	2 years ago
avatar	Use minio/sha256-simd for accelerated SHA256 (#23052 )	2 years ago
base	Use minio/sha256-simd for accelerated SHA256 (#23052 )	2 years ago
cache	Improve cache context (#23330 )	2 years ago
charset	Use data-tooltip-content for tippy tooltip (#23649 )	2 years ago
container	Implement FSFE REUSE for golang files (#21840 )	2 years ago
context	Implement Issue Config (#20956 )	2 years ago
csv	Add context when rendering labels or emojis (#23281 )	2 years ago
doctor	Check LFS/Packages settings in dump and doctor command (#23631 )	2 years ago
emoji	Fix unstable emoji sort (#22346 )	2 years ago
eventsource	Move `convert` package to services (#22264 )	2 years ago
generate	Implement FSFE REUSE for golang files (#21840 )	2 years ago
git	Add git dashes separator to some "log" and "diff" commands (#23606 )	2 years ago
gitgraph	Add context cache as a request level cache (#22294 )	2 years ago
graceful	Implement FSFE REUSE for golang files (#21840 )	2 years ago
hcaptcha	Consume hcaptcha and pwn deps (#22610 )	2 years ago
highlight	test_env: hardcode major go version in use (#23464 )	2 years ago
hostmatcher	Implement FSFE REUSE for golang files (#21840 )	2 years ago
html	Implement FSFE REUSE for golang files (#21840 )	2 years ago
httpcache	Set `X-Gitea-Debug` header once (#23361 )	2 years ago
httplib	Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687 )	2 years ago
indexer	Add meilisearch support (#23136 )	2 years ago
issue/template	Allow issue templates to not render title (#22589 )	2 years ago
json	Update gitea-vet to check FSFE REUSE (#22004 )	2 years ago
label	Reduce duplicate and useless code in options (#23369 )	2 years ago
lfs	Make minio package support legacy MD5 checksum (#23768 )	2 years ago
log	Improve trace logging for pulls and processes (#22633 )	2 years ago
markup	Editor preview support for external renderers (#23333 )	2 years ago
mcaptcha	Implement FSFE REUSE for golang files (#21840 )	2 years ago
metrics	include build info in Prometheus metrics (#22819 )	2 years ago
migration	Scoped labels (#22585 )	2 years ago
mirror	Implement FSFE REUSE for golang files (#21840 )	2 years ago
nosql	Implement FSFE REUSE for golang files (#21840 )	2 years ago
notification	Implement actions (#21937 )	2 years ago
options	Introduce path Clean/Join helper functions (#23495 )	2 years ago
packages	Return `repository` in npm package metadata endpoint (#23539 )	2 years ago
paginator	Update gitea-vet to check FSFE REUSE (#22004 )	2 years ago
pprof	Implement FSFE REUSE for golang files (#21840 )	2 years ago
private	Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687 )	2 years ago
process	Improve trace logging for pulls and processes (#22633 )	2 years ago
proxy	Use proxy for pull mirror (#22771 )	2 years ago
proxyprotocol	Implement FSFE REUSE for golang files (#21840 )	2 years ago
public	Introduce path Clean/Join helper functions (#23495 )	2 years ago
queue	Properly flush unique queues on startup (#23154 )	2 years ago
recaptcha	Implement FSFE REUSE for golang files (#21840 )	2 years ago
references	Use correct captured group range when parsing cross-reference (#22672 )	2 years ago
regexplru	Implement FSFE REUSE for golang files (#21840 )	2 years ago
repository	Fix pull request update showing too many commits with multiple branches (#22856 )	2 years ago
secret	Use minio/sha256-simd for accelerated SHA256 (#23052 )	2 years ago
session	Update gitea-vet to check FSFE REUSE (#22004 )	2 years ago
setting	Add meilisearch support (#23136 )	2 years ago
sitemap	Fix sitemap (#22272 )	2 years ago
ssh	Implement FSFE REUSE for golang files (#21840 )	2 years ago
storage	Make minio package support legacy MD5 checksum (#23768 )	2 years ago
structs	Implement Issue Config (#20956 )	2 years ago
svg	Keep (add if not existing) xmlns attribute for generated SVG images (#23410 )	2 years ago
sync	Implement FSFE REUSE for golang files (#21840 )	2 years ago
system	Implement FSFE REUSE for golang files (#21840 )	2 years ago
templates	Improve template error reporting (#23396 )	2 years ago
test	Rename `repo.GetOwner` to `repo.LoadOwner` (#22967 )	2 years ago
timeutil	Use data-tooltip-content for tippy tooltip (#23649 )	2 years ago
translation	Implement FSFE REUSE for golang files (#21840 )	2 years ago
turnstile	Add new captcha: cloudflare turnstile (#22369 )	2 years ago
typesniffer	Do not recognize text files as audio (#23355 )	2 years ago
updatechecker	Implement FSFE REUSE for golang files (#21840 )	2 years ago
upload	Implement FSFE REUSE for golang files (#21840 )	2 years ago
uri	Implement FSFE REUSE for golang files (#21840 )	2 years ago
user	Implement FSFE REUSE for golang files (#21840 )	2 years ago
util	Introduce path Clean/Join helper functions (#23495 )	2 years ago
validation	Map OIDC groups to Orgs/Teams (#21441 )	2 years ago
watcher	Implement FSFE REUSE for golang files (#21840 )	2 years ago
web	Map OIDC groups to Orgs/Teams (#21441 )	2 years ago
webhook	Restructure `webhook` module (#22256 )	2 years ago