|
|
@ -3,7 +3,7 @@ title: Code Review Guidelines |
|
|
|
sort_key: B |
|
|
|
sort_key: B |
|
|
|
--- |
|
|
|
--- |
|
|
|
|
|
|
|
|
|
|
|
The only way to get code into go-ethereum is to send a pull request. Those pull requests |
|
|
|
The only way to get code into Geth is to submit a pull request (PR). Those pull requests |
|
|
|
need to be reviewed by someone. This document is a guide that explains our expectations |
|
|
|
need to be reviewed by someone. This document is a guide that explains our expectations |
|
|
|
around PRs for both authors and reviewers. |
|
|
|
around PRs for both authors and reviewers. |
|
|
|
|
|
|
|
|
|
|
@ -11,9 +11,12 @@ around PRs for both authors and reviewers. |
|
|
|
|
|
|
|
|
|
|
|
* The **author** of a pull request is the entity who wrote the diff and submitted it to |
|
|
|
* The **author** of a pull request is the entity who wrote the diff and submitted it to |
|
|
|
GitHub. |
|
|
|
GitHub. |
|
|
|
|
|
|
|
|
|
|
|
* The **team** consists of people with commit rights on the go-ethereum repository. |
|
|
|
* The **team** consists of people with commit rights on the go-ethereum repository. |
|
|
|
|
|
|
|
|
|
|
|
* The **reviewer** is the person assigned to review the diff. The reviewer must be a team |
|
|
|
* The **reviewer** is the person assigned to review the diff. The reviewer must be a team |
|
|
|
member. |
|
|
|
member. |
|
|
|
|
|
|
|
|
|
|
|
* The **code owner** is the person responsible for the subsystem being modified by the PR. |
|
|
|
* The **code owner** is the person responsible for the subsystem being modified by the PR. |
|
|
|
|
|
|
|
|
|
|
|
## The Process |
|
|
|
## The Process |