rlp: fix staticcheck warnings (#20368)

* rlp: fix staticcheck warnings

* rlp: fix ExampleDecode test
pull/20388/head
Felix Lange 5 years ago committed by Péter Szilágyi
parent 9ef90dbf30
commit 44b41641f8
  1. 11
      rlp/decode.go
  2. 9
      rlp/decode_test.go

@ -29,12 +29,13 @@ import (
"sync" "sync"
) )
var ( //lint:ignore ST1012 EOL is not an error.
// EOL is returned when the end of the current list
// has been reached during streaming. // EOL is returned when the end of the current list
EOL = errors.New("rlp: end of list") // has been reached during streaming.
var EOL = errors.New("rlp: end of list")
// Actual Errors var (
ErrExpectedString = errors.New("rlp: expected String or Byte") ErrExpectedString = errors.New("rlp: expected String or Byte")
ErrExpectedList = errors.New("rlp: expected List") ErrExpectedList = errors.New("rlp: expected List")
ErrCanonInt = errors.New("rlp: non-canonical integer format") ErrCanonInt = errors.New("rlp: non-canonical integer format")

@ -354,7 +354,7 @@ type tailUint struct {
type tailPrivateFields struct { type tailPrivateFields struct {
A uint A uint
Tail []uint `rlp:"tail"` Tail []uint `rlp:"tail"`
x, y bool x, y bool //lint:ignore U1000 unused fields required for testing purposes.
} }
type nilListUint struct { type nilListUint struct {
@ -806,9 +806,8 @@ func ExampleDecode() {
input, _ := hex.DecodeString("C90A1486666F6F626172") input, _ := hex.DecodeString("C90A1486666F6F626172")
type example struct { type example struct {
A, B uint A, B uint
private uint // private fields are ignored String string
String string
} }
var s example var s example
@ -819,7 +818,7 @@ func ExampleDecode() {
fmt.Printf("Decoded value: %#v\n", s) fmt.Printf("Decoded value: %#v\n", s)
} }
// Output: // Output:
// Decoded value: rlp.example{A:0xa, B:0x14, private:0x0, String:"foobar"} // Decoded value: rlp.example{A:0xa, B:0x14, String:"foobar"}
} }
func ExampleDecode_structTagNil() { func ExampleDecode_structTagNil() {

Loading…
Cancel
Save