mirror
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum
2
0
Fork 1
Code Issues Releases Wiki Activity

Address pull request comments

Browse Source 
* Remove flags field from key struct
* Change JSON struct fields from string to []byte
* Change GenerateNewKey API to take io.Reader for random source
* Remove mixing entropy source function
* Use testing Fatal in tests
pull/259/head
Gustav Simonsson 10 years ago
parent a1c2749380
commit 47d3b3dd58
4 changed files with 88 additions and 215 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 150
      crypto/key.go
  2. 75
      crypto/key_store_passphrase.go
  3. 12
      crypto/key_store_plain.go
  4. 66
      crypto/key_store_test.go

150
crypto/key.go
Unescape View File

@ -28,43 +28,31 @@ import (
"code.google.com/p/go-uuid/uuid" "code.google.com/p/go-uuid/uuid"
"crypto/ecdsa" "crypto/ecdsa"
"crypto/elliptic" "crypto/elliptic"
crand "crypto/rand"
"encoding/binary"
"encoding/hex"
"encoding/json" "encoding/json"
"errors"
"fmt"
"io" "io"
"os"
"runtime"
"strings"
"time"
) )
type Key struct { type Key struct {
Id *uuid.UUID // Version 4 "random" for unique id not derived from key data Id *uuid.UUID // Version 4 "random" for unique id not derived from key data
Flags [4]byte // RFU
// we only store privkey as pubkey/address can be derived from it // we only store privkey as pubkey/address can be derived from it
// privkey in this struct is always in plaintext // privkey in this struct is always in plaintext
PrivateKey *ecdsa.PrivateKey PrivateKey *ecdsa.PrivateKey
} }
type PlainKeyJSON struct { type plainKeyJSON struct {
Id string Id []byte
Flags string PrivateKey []byte
PrivateKey string
} }
type CipherJSON struct { type cipherJSON struct {
Salt string Salt []byte
IV string IV []byte
CipherText string CipherText []byte
} }
type EncryptedKeyJSON struct { type encryptedKeyJSON struct {
Id string Id []byte
Flags string Crypto cipherJSON
Crypto CipherJSON
} }
func (k *Key) Address() []byte { func (k *Key) Address() []byte {
@ -73,48 +61,40 @@ func (k *Key) Address() []byte {
} }
func (k *Key) MarshalJSON() (j []byte, err error) { func (k *Key) MarshalJSON() (j []byte, err error) {
stringStruct := PlainKeyJSON{ jStruct := plainKeyJSON{
k.Id.String(), *k.Id,
hex.EncodeToString(k.Flags[:]), FromECDSA(k.PrivateKey),
hex.EncodeToString(FromECDSA(k.PrivateKey)),
} }
j, err = json.Marshal(stringStruct) j, err = json.Marshal(jStruct)
return j, err return j, err
} }
func (k *Key) UnmarshalJSON(j []byte) (err error) { func (k *Key) UnmarshalJSON(j []byte) (err error) {
keyJSON := new(PlainKeyJSON) keyJSON := new(plainKeyJSON)
err = json.Unmarshal(j, &keyJSON) err = json.Unmarshal(j, &keyJSON)
if err != nil { if err != nil {
return err return err
} }
u := new(uuid.UUID) u := new(uuid.UUID)
*u = uuid.Parse(keyJSON.Id) *u = keyJSON.Id
if *u == nil {
err = errors.New("UUID parsing failed")
return err
}
k.Id = u k.Id = u
flagsBytes, err := hex.DecodeString(keyJSON.Flags) k.PrivateKey = ToECDSA(keyJSON.PrivateKey)
if err != nil {
return err
}
PrivateKeyBytes, err := hex.DecodeString(keyJSON.PrivateKey)
if err != nil {
return err
}
copy(k.Flags[:], flagsBytes[0:4])
k.PrivateKey = ToECDSA(PrivateKeyBytes)
return err return err
} }
func NewKey() *Key { func NewKey(rand io.Reader) *Key {
randBytes := GetEntropyCSPRNG(32) randBytes := make([]byte, 32)
n, err := rand.Read(randBytes)
if err != nil {
panic("key generation: could not read from random source: " + err.Error())
} else {
if n != 32 {
panic("key generation: read less than required bytes from random source: " + err.Error())
}
}
reader := bytes.NewReader(randBytes) reader := bytes.NewReader(randBytes)
_, x, y, err := elliptic.GenerateKey(S256(), reader) _, x, y, err := elliptic.GenerateKey(S256(), reader)
if err != nil { if err != nil {
@ -126,80 +106,6 @@ func NewKey() *Key {
key := new(Key) key := new(Key)
id := uuid.NewRandom() id := uuid.NewRandom()
key.Id = &id key.Id = &id
// flags := new([4]byte)
// key.Flags = flags
key.PrivateKey = privateKeyECDSA key.PrivateKey = privateKeyECDSA
return key return key
} }
// plain crypto/rand. this is /dev/urandom on Unix-like systems.
func GetEntropyCSPRNG(n int) []byte {
mainBuff := make([]byte, n)
_, err := io.ReadFull(crand.Reader, mainBuff)
if err != nil {
panic("key generation: reading from crypto/rand failed: " + err.Error())
}
return mainBuff
}
// TODO: verify. Do not use until properly discussed.
// we start with crypt/rand, then mix in additional sources of entropy.
// These sources are from three types: OS, go runtime and ethereum client state.
func GetEntropyTinFoilHat() []byte {
startTime := time.Now().UnixNano()
// for each source, we XOR in it's SHA3 hash.
mainBuff := GetEntropyCSPRNG(32)
// 1. OS entropy sources
startTimeBytes := make([]byte, 32)
binary.PutVarint(startTimeBytes, startTime)
startTimeHash := Sha3(startTimeBytes)
mix32Byte(mainBuff, startTimeHash)
pid := os.Getpid()
pidBytes := make([]byte, 32)
binary.PutUvarint(pidBytes, uint64(pid))
pidHash := Sha3(pidBytes)
mix32Byte(mainBuff, pidHash)
osEnv := os.Environ()
osEnvBytes := []byte(strings.Join(osEnv, ""))
osEnvHash := Sha3(osEnvBytes)
mix32Byte(mainBuff, osEnvHash)
// not all OS have hostname in env variables
osHostName, err := os.Hostname()
if err != nil {
osHostNameBytes := []byte(osHostName)
osHostNameHash := Sha3(osHostNameBytes)
mix32Byte(mainBuff, osHostNameHash)
}
// 2. go runtime entropy sources
memStats := new(runtime.MemStats)
runtime.ReadMemStats(memStats)
memStatsBytes := []byte(fmt.Sprintf("%v", memStats))
memStatsHash := Sha3(memStatsBytes)
mix32Byte(mainBuff, memStatsHash)
// 3. Mix in ethereum / client state
// TODO: list of network peers structs (IP, port, etc)
// TODO: merkle patricia tree root hash for world state and tx list
// 4. Yo dawg we heard you like entropy so we'll grab some entropy from how
// long it took to grab the above entropy. And a yield, for good measure.
runtime.Gosched()
diffTime := time.Now().UnixNano() - startTime
diffTimeBytes := make([]byte, 32)
binary.PutVarint(diffTimeBytes, diffTime)
diffTimeHash := Sha3(diffTimeBytes)
mix32Byte(mainBuff, diffTimeHash)
return mainBuff
}
func mix32Byte(buff []byte, mixBuff []byte) []byte {
for i := 0; i < 32; i++ {
buff[i] ^= mixBuff[i]
}
return buff
}

75
crypto/key_store_passphrase.go
Unescape View File

@ -69,9 +69,10 @@ import (
"code.google.com/p/go.crypto/scrypt" "code.google.com/p/go.crypto/scrypt"
"crypto/aes" "crypto/aes"
"crypto/cipher" "crypto/cipher"
"encoding/hex" crand "crypto/rand"
"encoding/json" "encoding/json"
"errors" "errors"
"io"
"os" "os"
"path" "path"
) )
@ -94,25 +95,24 @@ func NewKeyStorePassphrase(path string) KeyStore2 {
return ks return ks
} }
func (ks keyStorePassphrase) GenerateNewKey(auth string) (key *Key, err error) { func (ks keyStorePassphrase) GenerateNewKey(rand io.Reader, auth string) (key *Key, err error) {
return GenerateNewKeyDefault(ks, auth) return GenerateNewKeyDefault(ks, rand, auth)
} }
func (ks keyStorePassphrase) GetKey(keyId *uuid.UUID, auth string) (key *Key, err error) { func (ks keyStorePassphrase) GetKey(keyId *uuid.UUID, auth string) (key *Key, err error) {
keyBytes, flags, err := DecryptKey(ks, keyId, auth) keyBytes, err := DecryptKey(ks, keyId, auth)
if err != nil { if err != nil {
return nil, err return nil, err
} }
key = new(Key) key = new(Key)
key.Id = keyId key.Id = keyId
copy(key.Flags[:], flags[0:4])
key.PrivateKey = ToECDSA(keyBytes) key.PrivateKey = ToECDSA(keyBytes)
return key, err return key, err
} }
func (ks keyStorePassphrase) StoreKey(key *Key, auth string) (err error) { func (ks keyStorePassphrase) StoreKey(key *Key, auth string) (err error) {
authArray := []byte(auth) authArray := []byte(auth)
salt := GetEntropyCSPRNG(32) salt := getEntropyCSPRNG(32)
derivedKey, err := scrypt.Key(authArray, salt, scryptN, scryptr, scryptp, scryptdkLen) derivedKey, err := scrypt.Key(authArray, salt, scryptN, scryptr, scryptp, scryptdkLen)
if err != nil { if err != nil {
return err return err
@ -127,19 +127,18 @@ func (ks keyStorePassphrase) StoreKey(key *Key, auth string) (err error) {
return err return err
} }
iv := GetEntropyCSPRNG(aes.BlockSize) // 16 iv := getEntropyCSPRNG(aes.BlockSize) // 16
AES256CBCEncrypter := cipher.NewCBCEncrypter(AES256Block, iv) AES256CBCEncrypter := cipher.NewCBCEncrypter(AES256Block, iv)
cipherText := make([]byte, len(toEncrypt)) cipherText := make([]byte, len(toEncrypt))
AES256CBCEncrypter.CryptBlocks(cipherText, toEncrypt) AES256CBCEncrypter.CryptBlocks(cipherText, toEncrypt)
cipherStruct := CipherJSON{ cipherStruct := cipherJSON{
hex.EncodeToString(salt), salt,
hex.EncodeToString(iv), iv,
hex.EncodeToString(cipherText), cipherText,
} }
keyStruct := EncryptedKeyJSON{ keyStruct := encryptedKeyJSON{
key.Id.String(), *key.Id,
hex.EncodeToString(key.Flags[:]),
cipherStruct, cipherStruct,
} }
keyJSON, err := json.Marshal(keyStruct) keyJSON, err := json.Marshal(keyStruct)
@ -152,7 +151,7 @@ func (ks keyStorePassphrase) StoreKey(key *Key, auth string) (err error) {
func (ks keyStorePassphrase) DeleteKey(keyId *uuid.UUID, auth string) (err error) { func (ks keyStorePassphrase) DeleteKey(keyId *uuid.UUID, auth string) (err error) {
// only delete if correct passphrase is given // only delete if correct passphrase is given
_, _, err = DecryptKey(ks, keyId, auth) _, err = DecryptKey(ks, keyId, auth)
if err != nil { if err != nil {
return err return err
} }
@ -161,44 +160,30 @@ func (ks keyStorePassphrase) DeleteKey(keyId *uuid.UUID, auth string) (err error
return os.RemoveAll(keyDirPath) return os.RemoveAll(keyDirPath)
} }
func DecryptKey(ks keyStorePassphrase, keyId *uuid.UUID, auth string) (keyBytes []byte, flags []byte, err error) { func DecryptKey(ks keyStorePassphrase, keyId *uuid.UUID, auth string) (keyBytes []byte, err error) {
fileContent, err := GetKeyFile(ks.keysDirPath, keyId) fileContent, err := GetKeyFile(ks.keysDirPath, keyId)
if err != nil { if err != nil {
return nil, nil, err return nil, err
} }
keyProtected := new(EncryptedKeyJSON) keyProtected := new(encryptedKeyJSON)
err = json.Unmarshal(fileContent, keyProtected) err = json.Unmarshal(fileContent, keyProtected)
flags, err = hex.DecodeString(keyProtected.Flags) salt := keyProtected.Crypto.Salt
if err != nil {
return nil, nil, err
}
salt, err := hex.DecodeString(keyProtected.Crypto.Salt) iv := keyProtected.Crypto.IV
if err != nil {
return nil, nil, err
}
iv, err := hex.DecodeString(keyProtected.Crypto.IV) cipherText := keyProtected.Crypto.CipherText
if err != nil {
return nil, nil, err
}
cipherText, err := hex.DecodeString(keyProtected.Crypto.CipherText)
if err != nil {
return nil, nil, err
}
authArray := []byte(auth) authArray := []byte(auth)
derivedKey, err := scrypt.Key(authArray, salt, scryptN, scryptr, scryptp, scryptdkLen) derivedKey, err := scrypt.Key(authArray, salt, scryptN, scryptr, scryptp, scryptdkLen)
if err != nil { if err != nil {
return nil, nil, err return nil, err
} }
AES256Block, err := aes.NewCipher(derivedKey) AES256Block, err := aes.NewCipher(derivedKey)
if err != nil { if err != nil {
return nil, nil, err return nil, err
} }
AES256CBCDecrypter := cipher.NewCBCDecrypter(AES256Block, iv) AES256CBCDecrypter := cipher.NewCBCDecrypter(AES256Block, iv)
@ -208,16 +193,26 @@ func DecryptKey(ks keyStorePassphrase, keyId *uuid.UUID, auth string) (keyBytes
plainText := PKCS7Unpad(paddedPlainText) plainText := PKCS7Unpad(paddedPlainText)
if plainText == nil { if plainText == nil {
err = errors.New("Decryption failed: PKCS7Unpad failed after decryption") err = errors.New("Decryption failed: PKCS7Unpad failed after decryption")
return nil, nil, err return nil, err
} }
keyBytes = plainText[:len(plainText)-32] keyBytes = plainText[:len(plainText)-32]
keyBytesHash := plainText[len(plainText)-32:] keyBytesHash := plainText[len(plainText)-32:]
if !bytes.Equal(Sha3(keyBytes), keyBytesHash) { if !bytes.Equal(Sha3(keyBytes), keyBytesHash) {
err = errors.New("Decryption failed: checksum mismatch") err = errors.New("Decryption failed: checksum mismatch")
return nil, nil, err return nil, err
}
return keyBytes, err
}
// plain crypto/rand. this is /dev/urandom on Unix-like systems.
func getEntropyCSPRNG(n int) []byte {
mainBuff := make([]byte, n)
_, err := io.ReadFull(crand.Reader, mainBuff)
if err != nil {
panic("key generation: reading from crypto/rand failed: " + err.Error())
} }
return keyBytes, flags, err return mainBuff
} }
// From https://leanpub.com/gocrypto/read#leanpub-auto-block-cipher-modes // From https://leanpub.com/gocrypto/read#leanpub-auto-block-cipher-modes

12
crypto/key_store_plain.go
Unescape View File

@ -27,6 +27,7 @@ import (
"code.google.com/p/go-uuid/uuid" "code.google.com/p/go-uuid/uuid"
"encoding/json" "encoding/json"
"fmt" "fmt"
"io"
"io/ioutil" "io/ioutil"
"os" "os"
"os/user" "os/user"
@ -35,7 +36,8 @@ import (
// TODO: rename to KeyStore when replacing existing KeyStore // TODO: rename to KeyStore when replacing existing KeyStore
type KeyStore2 interface { type KeyStore2 interface {
GenerateNewKey(string) (*Key, error) // create and store new key, optionally using auth string // create new key using io.Reader entropy source and optionally using auth string
GenerateNewKey(io.Reader, string) (*Key, error)
GetKey(*uuid.UUID, string) (*Key, error) // key from id and auth string GetKey(*uuid.UUID, string) (*Key, error) // key from id and auth string
StoreKey(*Key, string) error // store key optionally using auth string StoreKey(*Key, string) error // store key optionally using auth string
DeleteKey(*uuid.UUID, string) error // delete key by id and auth string DeleteKey(*uuid.UUID, string) error // delete key by id and auth string
@ -57,17 +59,17 @@ func NewKeyStorePlain(path string) KeyStore2 {
return ks return ks
} }
func (ks keyStorePlain) GenerateNewKey(auth string) (key *Key, err error) { func (ks keyStorePlain) GenerateNewKey(rand io.Reader, auth string) (key *Key, err error) {
return GenerateNewKeyDefault(ks, auth) return GenerateNewKeyDefault(ks, rand, auth)
} }
func GenerateNewKeyDefault(ks KeyStore2, auth string) (key *Key, err error) { func GenerateNewKeyDefault(ks KeyStore2, rand io.Reader, auth string) (key *Key, err error) {
defer func() { defer func() {
if r := recover(); r != nil { if r := recover(); r != nil {
err = fmt.Errorf("GenerateNewKey error: %v", r) err = fmt.Errorf("GenerateNewKey error: %v", r)
} }
}() }()
key = NewKey() key = NewKey(rand)
err = ks.StoreKey(key, auth) err = ks.StoreKey(key, auth)
return key, err return key, err
} }

66
crypto/key_store_test.go
Unescape View File

@ -1,7 +1,7 @@
package crypto package crypto
import ( import (
"fmt" crand "crypto/rand"
"reflect" "reflect"
"testing" "testing"
) )
@ -9,107 +9,77 @@ import (
func TestKeyStorePlain(t *testing.T) { func TestKeyStorePlain(t *testing.T) {
ks := NewKeyStorePlain(DefaultDataDir()) ks := NewKeyStorePlain(DefaultDataDir())
pass := "" // not used but required by API pass := "" // not used but required by API
k1, err := ks.GenerateNewKey(pass) k1, err := ks.GenerateNewKey(crand.Reader, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
k2 := new(Key) k2 := new(Key)
k2, err = ks.GetKey(k1.Id, pass) k2, err = ks.GetKey(k1.Id, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
if !reflect.DeepEqual(k1.Id, k2.Id) { if !reflect.DeepEqual(k1.Id, k2.Id) {
fmt.Println("key Id mismatch") t.Fatal(err)
t.FailNow()
}
if k1.Flags != k2.Flags {
fmt.Println("key Flags mismatch")
t.FailNow()
} }
if !reflect.DeepEqual(k1.PrivateKey, k2.PrivateKey) { if !reflect.DeepEqual(k1.PrivateKey, k2.PrivateKey) {
fmt.Println("key PrivateKey mismatch") t.Fatal(err)
t.FailNow()
} }
err = ks.DeleteKey(k2.Id, pass) err = ks.DeleteKey(k2.Id, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
} }
func TestKeyStorePassphrase(t *testing.T) { func TestKeyStorePassphrase(t *testing.T) {
ks := NewKeyStorePassphrase(DefaultDataDir()) ks := NewKeyStorePassphrase(DefaultDataDir())
pass := "foo" pass := "foo"
k1, err := ks.GenerateNewKey(pass) k1, err := ks.GenerateNewKey(crand.Reader, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
k2 := new(Key) k2 := new(Key)
k2, err = ks.GetKey(k1.Id, pass) k2, err = ks.GetKey(k1.Id, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
if !reflect.DeepEqual(k1.Id, k2.Id) { if !reflect.DeepEqual(k1.Id, k2.Id) {
fmt.Println("key Id mismatch") t.Fatal(err)
t.FailNow()
}
if k1.Flags != k2.Flags {
fmt.Println("key Flags mismatch")
t.FailNow()
} }
if !reflect.DeepEqual(k1.PrivateKey, k2.PrivateKey) { if !reflect.DeepEqual(k1.PrivateKey, k2.PrivateKey) {
fmt.Println("key PrivateKey mismatch") t.Fatal(err)
t.FailNow()
} }
err = ks.DeleteKey(k2.Id, pass) // also to clean up created files err = ks.DeleteKey(k2.Id, pass) // also to clean up created files
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
} }
func TestKeyStorePassphraseDecryptionFail(t *testing.T) { func TestKeyStorePassphraseDecryptionFail(t *testing.T) {
ks := NewKeyStorePassphrase(DefaultDataDir()) ks := NewKeyStorePassphrase(DefaultDataDir())
pass := "foo" pass := "foo"
k1, err := ks.GenerateNewKey(pass) k1, err := ks.GenerateNewKey(crand.Reader, pass)
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
_, err = ks.GetKey(k1.Id, "bar") // wrong passphrase _, err = ks.GetKey(k1.Id, "bar") // wrong passphrase
// t.Error(err)
if err == nil { if err == nil {
t.FailNow() t.Fatal(err)
} }
err = ks.DeleteKey(k1.Id, "bar") // wrong passphrase err = ks.DeleteKey(k1.Id, "bar") // wrong passphrase
if err == nil { if err == nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
err = ks.DeleteKey(k1.Id, pass) // to clean up err = ks.DeleteKey(k1.Id, pass) // to clean up
if err != nil { if err != nil {
t.Error(err) t.Fatal(err)
t.FailNow()
} }
} }
func TestKeyMixedEntropy(t *testing.T) {
GetEntropyTinFoilHat()
}

Write Preview
Loading…
Cancel
Save