mirror
/
go-ethereum
mirror of https://github.com/ethereum/go-ethereum
2
0
Fork 1
Code Issues Releases Wiki Activity

Update code-review-guidelines.md

Browse Source 
Removing this whitespace might make the final page look cleaner (Not as much whitespace between terminology and process)
pull/26459/head^2
Marius van der Wijden 2 years ago committed by GitHub
parent db0b46953b
commit 61214ee283
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 1
      docs/developers/geth-developer/code-review-guidelines.md

1
docs/developers/geth-developer/code-review-guidelines.md
Unescape View File

@ -8,7 +8,6 @@ The only way to get code into Geth is to submit a pull request (PR). Those pull
## Terminology {#terminology} ## Terminology {#terminology}
- The **author** of a pull request is the entity who wrote the diff and submitted it to GitHub. - The **author** of a pull request is the entity who wrote the diff and submitted it to GitHub.
- The **team** consists of people with commit rights on the go-ethereum repository. - The **team** consists of people with commit rights on the go-ethereum repository.
- The **reviewer** is the person assigned to review the diff. The reviewer must be a team member. - The **reviewer** is the person assigned to review the diff. The reviewer must be a team member.
- The **code owner** is the person responsible for the subsystem being modified by the PR. - The **code owner** is the person responsible for the subsystem being modified by the PR.

Write Preview
Loading…
Cancel
Save