accounts: remove deadcode isSigned (#16990)

pull/17046/head
Wenbiao Zheng 6 years ago committed by Guillaume Ballet
parent 88c42ab4e7
commit 61a5976368
  1. 15
      accounts/abi/numbers.go
  2. 11
      accounts/abi/numbers_test.go

@ -31,29 +31,14 @@ var (
uint16T = reflect.TypeOf(uint16(0)) uint16T = reflect.TypeOf(uint16(0))
uint32T = reflect.TypeOf(uint32(0)) uint32T = reflect.TypeOf(uint32(0))
uint64T = reflect.TypeOf(uint64(0)) uint64T = reflect.TypeOf(uint64(0))
intT = reflect.TypeOf(int(0))
int8T = reflect.TypeOf(int8(0)) int8T = reflect.TypeOf(int8(0))
int16T = reflect.TypeOf(int16(0)) int16T = reflect.TypeOf(int16(0))
int32T = reflect.TypeOf(int32(0)) int32T = reflect.TypeOf(int32(0))
int64T = reflect.TypeOf(int64(0)) int64T = reflect.TypeOf(int64(0))
addressT = reflect.TypeOf(common.Address{}) addressT = reflect.TypeOf(common.Address{})
intTS = reflect.TypeOf([]int(nil))
int8TS = reflect.TypeOf([]int8(nil))
int16TS = reflect.TypeOf([]int16(nil))
int32TS = reflect.TypeOf([]int32(nil))
int64TS = reflect.TypeOf([]int64(nil))
) )
// U256 converts a big Int into a 256bit EVM number. // U256 converts a big Int into a 256bit EVM number.
func U256(n *big.Int) []byte { func U256(n *big.Int) []byte {
return math.PaddedBigBytes(math.U256(n), 32) return math.PaddedBigBytes(math.U256(n), 32)
} }
// checks whether the given reflect value is signed. This also works for slices with a number type
func isSigned(v reflect.Value) bool {
switch v.Type() {
case intTS, int8TS, int16TS, int32TS, int64TS, intT, int8T, int16T, int32T, int64T:
return true
}
return false
}

@ -19,7 +19,6 @@ package abi
import ( import (
"bytes" "bytes"
"math/big" "math/big"
"reflect"
"testing" "testing"
) )
@ -32,13 +31,3 @@ func TestNumberTypes(t *testing.T) {
t.Errorf("expected %x got %x", ubytes, unsigned) t.Errorf("expected %x got %x", ubytes, unsigned)
} }
} }
func TestSigned(t *testing.T) {
if isSigned(reflect.ValueOf(uint(10))) {
t.Error("signed")
}
if !isSigned(reflect.ValueOf(int(10))) {
t.Error("not signed")
}
}

Loading…
Cancel
Save